c41540931e
* code review checklist Change-Id: Id8e6c2d7e42d5b9b79e6f646e07f9c7c1f077405 * updates Change-Id: I1db2e3c09dc6d5cda89071e5f66783cc276352c0 * update Change-Id: Icf6d44795d024e67c630464db6cb2eb774f4f53e
863 B
863 B
Code Review Checklist
- Does the PR describe what changes are being made?
- Does the PR describe why the changes are being made?
- Does the code follow our style guide?
- Does the code follow our testing guide?
- Could the PR be broken into smaller PRs?
- Does the new code have enough tests? (every PR should have tests or justification otherwise. Bug-fix PRs especially)
- Does the new code have enough documentation that answers "how do I use it?" and "what does it do?"? (both source documentation and higher level, diagrams?)
- Does any documentation need updating?
Thanks for submitting a PR!