JakeHillion/storj
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

code review checklist (#1536)

Browse Source 
* code review checklist

Change-Id: Id8e6c2d7e42d5b9b79e6f646e07f9c7c1f077405

* updates

Change-Id: I1db2e3c09dc6d5cda89071e5f66783cc276352c0

* update

Change-Id: Icf6d44795d024e67c630464db6cb2eb774f4f53e
This commit is contained in:
JT Olio 2019-03-20 14:48:10 -06:00 committed by GitHub
parent 316bfed043
commit c41540931e
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 17 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
.github/pull_request_template.md vendored Normal file
View File

@ -0,0 +1,17 @@
## Code Review Checklist
- [ ] Does the PR describe what changes are being made?
- [ ] Does the PR describe why the changes are being made?
- [ ] Does the code follow [our style guide](https://github.com/storj/docs/blob/master/code/Style.md)?
- [ ] Does the code follow [our testing guide](https://github.com/storj/docs/blob/master/code/Testing.md)?
- [ ] Could the PR be broken into smaller PRs?
- [ ] Does the new code have enough tests? (*every* PR should have tests or justification otherwise. Bug-fix PRs especially)
- [ ] Does the new code have enough documentation that answers "how do I use it?" and "what does it do?"? (both source documentation and [higher level](https://github.com/storj/docs), diagrams?)
- [ ] Does any documentation need updating?
Thanks for submitting a PR!
![](https://media.giphy.com/media/14nakW0jC4HA6k/giphy.gif)