2019-03-20 20:48:10 +00:00
2019-04-08 20:01:52 +01:00
What:
Why:
2019-03-20 20:48:10 +00:00
2019-06-19 20:11:48 +01:00
Please describe the tests:
- Test 1:
- Test 2:
Please describe the performance impact:
2019-03-27 23:19:22 +00:00
## Code Review Checklist (to be filled out by reviewer)
2019-10-31 15:27:46 +00:00
- [ ] NEW: Are there any Satellite database migrations? Are they forwards _and_ backwards compatible?
2019-03-20 20:48:10 +00:00
- [ ] Does the PR describe what changes are being made?
- [ ] Does the PR describe why the changes are being made?
2020-12-28 21:59:06 +00:00
- [ ] Does the code follow [our style guide ](https://github.com/storj/docs/blob/main/code/Style.md )?
- [ ] Does the code follow [our testing guide ](https://github.com/storj/docs/blob/main/code/Testing.md )?
2019-06-19 20:11:48 +01:00
- [ ] Is the PR appropriately sized? (If it could be broken into smaller PRs it should be)
2019-03-20 20:48:10 +00:00
- [ ] Does the new code have enough tests? (*every* PR should have tests or justification otherwise. Bug-fix PRs especially)
- [ ] Does the new code have enough documentation that answers "how do I use it?" and "what does it do?"? (both source documentation and [higher level ](https://github.com/storj/docs ), diagrams?)
- [ ] Does any documentation need updating?
2019-06-19 20:11:48 +01:00
- [ ] Do the database access patterns make sense?
2019-10-31 15:27:46 +00:00
