JakeHillion/storj
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Update pr template (#2237)

Browse Source
This commit is contained in:
JT Olio 2019-06-19 13:11:48 -06:00 committed by Egon Elbre
parent 3706bd78ef
commit 402902563e
1 changed files with 7 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
.github/pull_request_template.md vendored
View File

@ -3,14 +3,19 @@ What:
Why:
Thanks for submitting a PR!
Please describe the tests:
- Test 1:
- Test 2:
Please describe the performance impact:
## Code Review Checklist (to be filled out by reviewer)
- [ ] Does the PR describe what changes are being made?
- [ ] Does the PR describe why the changes are being made?
- [ ] Does the code follow [our style guide](https://github.com/storj/docs/blob/master/code/Style.md)?
- [ ] Does the code follow [our testing guide](https://github.com/storj/docs/blob/master/code/Testing.md)?
- [ ] Could the PR be broken into smaller PRs?
- [ ] Is the PR appropriately sized? (If it could be broken into smaller PRs it should be)
- [ ] Does the new code have enough tests? (*every* PR should have tests or justification otherwise. Bug-fix PRs especially)
- [ ] Does the new code have enough documentation that answers "how do I use it?" and "what does it do?"? (both source documentation and [higher level](https://github.com/storj/docs), diagrams?)
- [ ] Does any documentation need updating?
- [ ] Do the database access patterns make sense?