storj/.github/pull_request_template.md
JT Olio 0a0984707c
clarify who fills in the code review checklist (#1555)
Change-Id: Ifabc09c6ed8dd10fcda6b0298d127b19d76e4674
2019-03-27 17:19:22 -06:00

16 lines
892 B
Markdown

Thanks for submitting a PR!
![](https://media.giphy.com/media/14nakW0jC4HA6k/giphy.gif)
## Code Review Checklist (to be filled out by reviewer)
- [ ] Does the PR describe what changes are being made?
- [ ] Does the PR describe why the changes are being made?
- [ ] Does the code follow [our style guide](https://github.com/storj/docs/blob/master/code/Style.md)?
- [ ] Does the code follow [our testing guide](https://github.com/storj/docs/blob/master/code/Testing.md)?
- [ ] Could the PR be broken into smaller PRs?
- [ ] Does the new code have enough tests? (*every* PR should have tests or justification otherwise. Bug-fix PRs especially)
- [ ] Does the new code have enough documentation that answers "how do I use it?" and "what does it do?"? (both source documentation and [higher level](https://github.com/storj/docs), diagrams?)
- [ ] Does any documentation need updating?