c136796308
testplanet executes cockroach and postgress tests parallel, therefore using http.DefaultClient is safe only as long as we don't modify it. TestActivationRouting modifies it (client.CheckRedirect=...), therefore it should use a local version instead of the default one. Problem reported by a jenkins build: ``` ================== WARNING: DATA RACE Write at 0x000003486af0 by goroutine 143: storj.io/storj/satellite/console/consoleweb_test.TestActivationRouting.func1() /home/jenkins/workspace/storj-testing-experiments/satellite/console/consoleweb/server_test.go:66 +0x378 storj.io/storj/private/testplanet.Run.func1.1() ... Previous read at 0x000003486af0 by goroutine 104: net/http.(*Client).checkRedirect() /usr/local/go/src/net/http/client.go:494 +0xd73 net/http.(*Client).do() /usr/local/go/src/net/http/client.go:691 +0xd31 net/http.(*Client).Do() /usr/local/go/src/net/http/client.go:593 +0x204 storj.io/storj/satellite/console/consoleweb_test.TestActivationRouting.func1.1() /home/jenkins/workspace/storj-testing-experiments/satellite/console/consoleweb/server_test.go:48 +0x1e5 storj.io/storj/satellite/console/consoleweb_test.TestActivationRouting.func1() /home/jenkins/workspace/storj-testing-experiments/satellite/console/consoleweb/server_test.go:74 +0x49d storj.io/storj/private/testplanet.Run.func1.1() ... ``` Change-Id: I73319a5a593e067b906ec1fda70a44ca1e5a49a2 |
||
---|---|---|
.. | ||
consoleauth | ||
consolewasm | ||
consoleweb | ||
emailreminders | ||
restkeys | ||
wasm | ||
apikeys_test.go | ||
apikeys.go | ||
attribution_test.go | ||
auth.go | ||
billinghistoryitem.go | ||
buckets.go | ||
captcha_test.go | ||
captcha.go | ||
database.go | ||
mfa.go | ||
projectmembers_test.go | ||
projectmembers.go | ||
projects_test.go | ||
projects.go | ||
projectusagelimits.go | ||
registrationtoken.go | ||
request.go | ||
resetpasswordtoken_test.go | ||
resetpasswordtoken.go | ||
service_test.go | ||
service.go | ||
sortdirection.go | ||
users_test.go | ||
users.go | ||
validation.go |