JakeHillion/storj
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
9153f37055
storj/satellite
History
Márton Elek c136796308 test: make http client in TestActivationRouting thread-safe 
testplanet executes cockroach and postgress tests parallel, therefore using http.DefaultClient is safe only as long as we don't modify it.

TestActivationRouting modifies it (client.CheckRedirect=...), therefore it should use a local version instead of the default one.

Problem reported by a jenkins build:

```
==================
WARNING: DATA RACE
Write at 0x000003486af0 by goroutine 143:
  storj.io/storj/satellite/console/consoleweb_test.TestActivationRouting.func1()
      /home/jenkins/workspace/storj-testing-experiments/satellite/console/consoleweb/server_test.go:66 +0x378
  storj.io/storj/private/testplanet.Run.func1.1()
...

Previous read at 0x000003486af0 by goroutine 104:
  net/http.(*Client).checkRedirect()
      /usr/local/go/src/net/http/client.go:494 +0xd73
  net/http.(*Client).do()
      /usr/local/go/src/net/http/client.go:691 +0xd31
  net/http.(*Client).Do()
      /usr/local/go/src/net/http/client.go:593 +0x204
  storj.io/storj/satellite/console/consoleweb_test.TestActivationRouting.func1.1()
      /home/jenkins/workspace/storj-testing-experiments/satellite/console/consoleweb/server_test.go:48 +0x1e5
  storj.io/storj/satellite/console/consoleweb_test.TestActivationRouting.func1()
      /home/jenkins/workspace/storj-testing-experiments/satellite/console/consoleweb/server_test.go:74 +0x49d
  storj.io/storj/private/testplanet.Run.func1.1()
...

```

Change-Id: I73319a5a593e067b906ec1fda70a44ca1e5a49a2
2022-05-25 15:27:02 +00:00
..
accounting satellite: use more optimal monkit call for loop observers methods 2022-05-20 11:03:41 +00:00
admin satellite: Rename "acct mgmt api" to "rest api" 2022-04-25 18:51:46 +00:00
analytics satellite/analytics: Track events generated from navigation and dashboard (#4795) 2022-05-18 12:49:10 -07:00
attribution {cmd/satellite/reports, satellite/attribution}: type and variable name adjustments 2022-04-26 20:12:38 +00:00
audit satellite/{repair,audit}: simplify reputation reporter 2022-05-10 14:04:43 +00:00
buckets satellite/metainfo: propagate geofencing between buckets and stream id 2021-11-24 08:05:05 +00:00
compensation satellite/compensation: add a code that crypthopper-go now uses 2022-04-25 10:46:51 +00:00
console test: make http client in TestActivationRouting thread-safe 2022-05-25 15:27:02 +00:00
contact satellite/contact: fix connection leak in PingMe endpoint 2022-01-20 14:20:24 +00:00
gc satellite: use more optimal monkit call for loop observers methods 2022-05-20 11:03:41 +00:00
geoip satellite/geoip: update node check-in to associate a country code 2021-11-10 16:44:41 +01:00
gracefulexit satellite: use more optimal monkit call for loop observers methods 2022-05-20 11:03:41 +00:00
inspector satellite/metabase: drop GetObjectLatestVersion method 2022-02-02 09:40:53 +00:00
internalpb satellite/reputation: don't need 3 identical AuditHistory types 2022-05-24 05:48:46 +00:00
mailservice satellite/{mailservice,oidc}: improvements to debugging 2022-05-11 19:59:42 +00:00
metabase satellite/metabase/test: extend default time diff for comparison 2022-05-23 10:24:58 +00:00
metainfo satellite/metainfo: skip TestUserAgentTransferStats 2022-05-25 11:15:23 +00:00
metrics satellite/{audit,metrics}: optimize loop methods 2022-05-05 15:10:56 +00:00
nodeapiversion satellite/nodeapiversion: new table for tracking node api usage 2020-07-09 15:02:25 +00:00
nodeselection/uploadselection satellite/repairer: handle excluded countries 2022-03-14 10:59:36 -04:00
nodestats satellite/reputation: don't need 3 identical AuditHistory types 2022-05-24 05:48:46 +00:00
oidc satellite/{mailservice,oidc}: improvements to debugging 2022-05-11 19:59:42 +00:00
orders satellite: use PieceIDDeriver for derivation 2022-05-19 06:31:42 +00:00
overlay satellite/overlay: add disqualification reason 2022-04-20 13:29:31 +00:00
payments satellite/{payments/storjscan,satellitedb}: Add storjscan wallet DB 2022-05-24 08:42:02 +00:00
repair satellite: use more optimal monkit call for loop observers methods 2022-05-20 11:03:41 +00:00
reputation satellite/reputation: move Config fields into a Config struct 2022-05-24 20:57:51 +00:00
revocation satellite/satellitedb: move tests to their domains 2021-02-19 17:29:15 +02:00
rewards satellite/rewards: adding SeaweedFS to partners list (#4230) 2021-10-19 21:30:31 +02:00
satellitedb satellite/reputation: move Config fields into a Config struct 2022-05-24 20:57:51 +00:00
snopayouts all: fix error naming 2021-04-29 15:38:21 +03:00
admin.go satellite: more detailed goroutine labels 2022-05-11 17:50:55 +00:00
api.go web/satellite: create chore that will resend verification emails to unverified users 2022-05-18 08:08:33 +00:00
configlock_test.go all: fix linter complaints 2020-10-13 15:59:01 +03:00
core.go web/satellite: create chore that will resend verification emails to unverified users 2022-05-18 08:08:33 +00:00
gc.go satellite: more detailed goroutine labels 2022-05-11 17:50:55 +00:00
peer.go satellite/{payments/storjscan,satellitedb}: Add storjscan wallet DB 2022-05-24 08:42:02 +00:00
repairer.go satellite: more detailed goroutine labels 2022-05-11 17:50:55 +00:00