Egon Elbre
c7679b9b30
Fix some leaks and add notes about close handling ( #2334 )
2019-06-25 23:00:51 +03:00
Fadila
20de18feec
[v3-1952 test 6] Disqualification is a one way ticket. Storage Node can't get around it. ( #2328 )
2019-06-25 13:10:22 -04:00
Ivan Fraixedes
fa802dc429
pkg/audit: Improve Reporter.ReporterAudits doc ( #2266 )
...
Add what the method returns because from the method name and the
signature name, it wasn't clear why and when a report is returned.
2019-06-25 11:23:41 +02:00
Fadila
70f28ae41b
[v3-1952 tests 4 & 5] DQ nodes should not be used for download or upload ( #2272 )
2019-06-25 00:04:06 +02:00
Fadila
8226024ca8
Do not use disqualified nodes when asking for get order limits ( #2303 )
...
Add checks about disqualification when creating order limits
2019-06-24 16:46:10 +02:00
Ivan Fraixedes
3d6b25a043
[v3-1952 test 1 & 3] pkg/audit: Add DQ test for too many failed audits ( #2265 )
...
* pkg/audit: Add DQ test for too many failed audits
Add an integration test which checks that a node which fails several
audits gets disqualified but not before it reaches the audit reputation
disqualification cut-off.
* internal/testplanet: Set DQ cut-off config values
Set the values of the Overlay cache DQ cut-off configuration parameters
used by testplanet.
2019-06-21 18:27:19 +02:00
Natalie Villasana
169fc9594c
pkg/audit: fix maxRetries bug ( #2271 )
2019-06-21 11:10:03 -04:00
Ivan Fraixedes
5b31086757
pkg/audit: Move test helper funcs to separated file ( #2259 )
...
Move 2 helper function used for test which relay on testplanet from the
test file where they were created to separated file to contain them
because they are not only used in the test file were initially they were
created.
2019-06-20 17:38:08 +02:00
Natalie Villasana
9386187fe6
add disqualification and new reputation system into overlay cache ( #2227 )
2019-06-20 09:56:04 -04:00
Kaloyan Raev
ac65d19753
Avoid reporting audit failures for files deleted during audit ( #2233 )
2019-06-19 12:02:25 +03:00
Maximillian von Briesen
8398fae9b5
Add node churn and containment/reverify monkit stats ( #2217 )
...
* add counters for nodes that have/have not been seen in the past 24 hours/week
* add additional uptime counters
* add monkit stats for containment mode
2019-06-18 08:54:52 -04:00
Kaloyan Raev
8e29ef8a6b
Use zap.Stringer instead of zap.String ( #2223 )
2019-06-18 01:37:43 +02:00
littleskunk
319cc77a34
increase audit timeout ( #2208 )
2019-06-14 13:53:49 +02:00
Egon Elbre
1a1a084477
testcontext: sanitize folder name ( #2195 )
2019-06-13 15:46:08 +03:00
Natalie Villasana
5314c950cc
pkg/audit: add more reverify tests ( #2144 )
2019-06-11 16:14:40 -04:00
Kaloyan Raev
f0880b9b3c
Audit service should download erasure shares in parallel ( #2164 )
2019-06-11 11:00:59 +03:00
Natalie Villasana
16acb58546
rename verifier test files ( #2154 )
...
Despite the confusing git trail, this is two pure file renames, no other changes.
2019-06-07 16:02:36 -05:00
Kaloyan Raev
8ddb1dee0d
Improve error analysis in audit service ( #2125 )
...
Co-authored-by: Natalie Ventura Villasana <nat@storj.io>
2019-06-07 15:38:41 +03:00
Ivan Fraixedes
503fe0e5ec
pkg/audit: Fix code style named result params ( #2136 )
2019-06-06 15:55:06 +03:00
Kaloyan Raev
099cf921d3
Fix flaky audit test ( #2093 )
...
* Show full unexpected error when assertion fails
* restart jenkins
* restart jenkins
* restart jenkins
* restart jenkins
* Even better display of the unexpected error
* Fix flakiness using kaloyan-raev/errs fork
* Add more logs
* restart jenkins
* restart jenkins
* Better print for unexpected errors
* "error" instead of "err"
* restart jenkins
* Switch to zeebo/errs v1.2.0
* restart jenkins
* restart jenkins
* restart jenkins
* restart jenkins
* restart jenkins
* restart jenkins
* Remove some extra logs
* restart jenkins
2019-06-05 12:33:35 -06:00
JT Olio
f1641af802
storage: add monkit task to missing places ( #2122 )
...
* storage: add monkit task to missing places
Change-Id: I9e17a6b14f7c25bbf698eeecf32785e9add3f26e
* fix tests
Change-Id: Id078276fa3de61a28eb3d01d4e751732ecbb173f
* import order
Change-Id: I814e33755b9f10b5219af37cd828cd75eb3da1a4
* remove part of other commit
Change-Id: Idaa4c95cd65e97567fb466de49718db8203cfbe1
2019-06-05 16:23:10 +02:00
JT Olio
9c5708da32
pkg/*: add monkit task to missing places ( #2109 )
2019-06-04 13:36:27 +02:00
Kaloyan Raev
2ab95b533e
Check errors for possible outcomes from audit's DownloadShares ( #2072 )
2019-06-03 12:17:09 +03:00
Maximillian von Briesen
294fddcece
Add audit monkit stats ( #2087 )
2019-05-31 16:46:25 -04:00
Fadila
5b730e3073
Make maxReverifyCount configurable ( #2071 )
...
* make max reverify count configurable
2019-05-31 17:23:00 +02:00
ethanadams
16e3b77cf5
Enable Scopelint Linter ( #2049 )
...
* added scopelint and correcte issues found
* corrected scopelint issue
* made updates based on Ivan's suggestions
Most were around naming conventions
Some were false positives, but I kept them since the test.Run could eventually be changed to run in parallel, which could cause a bug
Others were false positives. Added // nolint: scopelint
2019-05-29 09:30:16 -04:00
ethanadams
268dc6b7e4
Enable gocritic linter ( #2051 )
...
* first round cleanup based on go-critic
* more issues resolved for ifelsechain and unlambda checks
* updated from master and gocritic found a new ifElseChain issue
* disable appendAssign. i reports false positives
* re-enabled go-critic appendAssign and disabled lint check at code line level
* fixed go-critic lint error
* fixed // nolint add gocritic specifically
2019-05-29 09:14:25 -04:00
Natalie Villasana
aa6ff17b70
add Reverify to auditing ( #2041 )
...
Co-authored-by: Maximillian von Briesen <mobyvb@gmail.com>
Co-authored-by: Kaloyan Raev <kaloyan@storj.io>
2019-05-27 14:13:47 +03:00
Ivan Fraixedes
5c50aac661
pkg/audit: Readdress ignored Verifier tests ( #2048 )
2019-05-24 19:57:07 +03:00
Natalie Villasana
e862382a6f
rename audit.RecordAuditsInfo to audit.Report ( #2044 )
...
* rename RecordAuditsInfo to Report
* change comment
2019-05-24 00:32:19 +02:00
Kaloyan Raev
de8070730a
Save hash of expected share from missing audited node ( #2025 )
2019-05-23 16:07:19 -04:00
Natalie Villasana
8b31c4b91f
remove unnecessary containmentDB wrapper ( #2027 )
2019-05-23 10:37:23 -04:00
Natalie Villasana
acfb59ae48
adds db layer functions for containment ( #1972 )
2019-05-22 10:50:22 -04:00
Bill Thorp
b23afb7aaa
remove downloader from verifier ( #1983 )
...
* remove downloader from verifier
2019-05-17 14:48:32 -04:00
Natalie Villasana
edd0a880ec
Removes 0 offline nodes assertion from verifier test ( #1982 )
2019-05-17 15:24:23 +03:00
Maximillian von Briesen
2ee390d07d
check results in verifier test ( #1956 )
2019-05-13 18:43:24 -04:00
Maximillian von Briesen
900ede151a
do not return error if no stripe in audit selection ( #1867 )
2019-05-01 14:59:30 -04:00
Maximillian von Briesen
50a0bffa0a
Improve audit cursor NextStripe ( #1821 )
2019-04-25 11:43:26 -04:00
Michal Niewrzal
fe3dfc1587
Move pointerdb.Service to satellite ( #1826 )
2019-04-25 10:46:32 +02:00
Egon Elbre
274fd53ace
Skip verifier tests early ( #1793 )
2019-04-22 15:14:59 +03:00
Kaloyan Raev
8fc5fe1d6f
Refactor pb.Node protobuf ( #1785 )
2019-04-22 12:07:50 +03:00
Maximillian von Briesen
b29d875326
Enable TestGetShareTimeout ( #1774 )
2019-04-22 08:54:08 +03:00
Kaloyan Raev
bfdee78f05
Introduce NodeDossier type and cleanup overlay.DB interface ( #1626 )
...
Co-authored-by: Natalie Villasana <navillasa@gmail.com>
Co-authored-by: Bill Thorp <bill3000@hotmail.com>
2019-04-04 19:34:36 +03:00
JT Olio
f96724df91
Forward port Bill and Stefan's changes to master ( #1590 )
...
* timeout calculation
* Initial Migration Draft to wipe the network gracefully (#1578 )
* Initial Migration Draft to wipe the network gracefully
* Change from DATE to UNIX Timestamp (INT)
* SQL Derps
* Remove Satellite Migration - gets done manually
* Move from possible STRING to INT Vars
* Add TestTable for Migration Tests
* Adjust Test data
* Update TestData Part 2
* Update Wipeout to 28th 00:00
* merge spelling
2019-04-03 19:17:29 +02:00
Natalie Villasana
e2a43c3fb6
adds defer close for node conn in audit verifier ( #1634 )
2019-04-03 09:42:24 -04:00
Natalie Villasana
2aeab10d50
skips flaky audit verifier test ( #1645 )
2019-04-02 13:44:33 -04:00
Natalie Villasana
c7c6d3d597
skips flaky TestGetShareTimeout ( #1635 )
2019-04-02 09:16:13 -04:00
Natalie Villasana
42a141965d
fixes infinite loop in audit TestVerifierHappyPath ( #1617 )
2019-04-01 17:27:07 -04:00
Michal Niewrzal
f80750693c
Store bandwidth from orders on satellite ( #1586 )
2019-04-01 16:14:58 -04:00
littleskunk
43ef0eb4c3
Don't crash on audit and repair failures ( #1622 )
...
* Fix satellite crash on repair
(cherry picked from commit cabf6c9f97780f900d76e2388ffa54b916f14528)
* Fix satellite crash on audit
(cherry picked from commit 9da67488c4b36a378f346fbb27651316284b0f36)
2019-04-01 11:16:17 +02:00
