testcontext: sanitize folder name (#2195)

cmd/uplink/cmd/setup_test.go

@@ -8,6 +8,7 @@ import (
 
 	"github.com/spf13/cobra"
 	"github.com/stretchr/testify/assert"
+
 	"storj.io/storj/cmd/uplink/cmd"
 )
 

internal/testcontext/context.go

@@ -9,7 +9,6 @@ import (
 	"io/ioutil"
 	"os"
 	"path/filepath"
-	"regexp"
 	"runtime"
 	"strings"
 	"sync"
@@ -113,9 +112,15 @@ func (ctx *Context) Dir(elem ...string) string {
 	ctx.test.Helper()
 
 	ctx.once.Do(func() {
+		sanitized := strings.Map(func(r rune) rune {
+			if ('a' <= r && r <= 'z') || ('A' <= r && r <= 'Z') || ('0' <= r && r <= '9') || r == '-' {
+				return r
+			}
+			return '_'
+		}, ctx.test.Name())
+
 		var err error
-		pattern := regexp.MustCompile(`[\\/]`)
-		ctx.directory, err = ioutil.TempDir("", pattern.ReplaceAllString(ctx.test.Name(), "_"))
+		ctx.directory, err = ioutil.TempDir("", sanitized)
 		if err != nil {
 			ctx.test.Fatal(err)
 		}

pkg/accounting/db_test.go

@@ -10,6 +10,7 @@ import (
 
 	"github.com/skyrings/skyring-common/tools/uuid"
 	"github.com/stretchr/testify/require"
+
 	"storj.io/storj/internal/testcontext"
 	"storj.io/storj/pkg/accounting"
 	"storj.io/storj/pkg/storj"

pkg/audit/verifier_unit_test.go

@@ -11,6 +11,7 @@ import (
 	"github.com/stretchr/testify/assert"
 	"github.com/stretchr/testify/require"
 	"github.com/vivint/infectious"
+
 	"storj.io/storj/pkg/pb"
 	"storj.io/storj/pkg/pkcrypto"
 	"storj.io/storj/pkg/storj"

pkg/macaroon/macaroon_test.go

@@ -7,6 +7,7 @@ import (
 	"testing"
 
 	assert "github.com/stretchr/testify/require"
+
 	"storj.io/storj/pkg/macaroon"
 )
 

pkg/storj/encryption_test.go

@@ -9,6 +9,7 @@ import (
 
 	"github.com/stretchr/testify/assert"
 	"github.com/stretchr/testify/require"
+
 	"storj.io/storj/pkg/storj"
 )
 

storage/boltdb/client_test.go

@@ -13,6 +13,7 @@ import (
 	"testing"
 
 	"github.com/zeebo/errs"
+
 	"storj.io/storj/internal/testcontext"
 	"storj.io/storj/storage"
 	"storj.io/storj/storage/testsuite"

storagenode/collector/service_test.go

@@ -9,6 +9,7 @@ import (
 	"time"
 
 	"github.com/stretchr/testify/require"
+
 	"storj.io/storj/internal/memory"
 	"storj.io/storj/internal/testcontext"
 	"storj.io/storj/internal/testplanet"

uplink/encryption_key_test.go

@@ -12,6 +12,7 @@ import (
 
 	"github.com/stretchr/testify/assert"
 	"github.com/stretchr/testify/require"
+
 	"storj.io/storj/internal/testcontext"
 	"storj.io/storj/pkg/storj"
 	"storj.io/storj/uplink"