JakeHillion/storj
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

storagenode/retain: Move summary and start logs to info level (#4954)

Browse Source 
We currently do not log the GC information/stats under normal circumstances.
This is not good for monitoring and troubleshooting.
This commit is contained in:
Stefan Benten 2022-07-08 18:19:08 +02:00 committed by GitHub
parent 43286dbc37
commit c3171b4ba4
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
storagenode/retain/retain.go
View File

@ -367,7 +367,7 @@ func (s *Service) retainPieces(ctx context.Context, req Request) (err error) {
mon.IntVal("garbage_collection_filter_size").Observe(filter.Size()) mon.IntVal("garbage_collection_filter_size").Observe(filter.Size())
mon.IntVal("garbage_collection_started").Observe(started.Unix()) mon.IntVal("garbage_collection_started").Observe(started.Unix())
s.log.Debug("Prepared to run a Retain request.", s.log.Info("Prepared to run a Retain request.",
zap.Time("Created Before", createdBefore), zap.Time("Created Before", createdBefore),
zap.Int64("Filter Size", filter.Size()), zap.Int64("Filter Size", filter.Size()),
zap.Stringer("Satellite ID", satelliteID)) zap.Stringer("Satellite ID", satelliteID))
@ -430,7 +430,7 @@ func (s *Service) retainPieces(ctx context.Context, req Request) (err error) {
mon.IntVal("garbage_collection_pieces_to_delete_count").Observe(piecesToDeleteCount) mon.IntVal("garbage_collection_pieces_to_delete_count").Observe(piecesToDeleteCount)
mon.IntVal("garbage_collection_pieces_deleted").Observe(int64(numDeleted)) mon.IntVal("garbage_collection_pieces_deleted").Observe(int64(numDeleted))
mon.DurationVal("garbage_collection_loop_duration").Observe(time.Now().UTC().Sub(started)) mon.DurationVal("garbage_collection_loop_duration").Observe(time.Now().UTC().Sub(started))
s.log.Debug("Moved pieces to trash during retain", zap.Int("num deleted", numDeleted), zap.String("Retain Status", s.config.Status.String())) s.log.Info("Moved pieces to trash during retain", zap.Int("num deleted", numDeleted), zap.String("Retain Status", s.config.Status.String()))
return nil return nil
} }