From c3171b4ba4294890ac4699f4ef3626e7a0c825e5 Mon Sep 17 00:00:00 2001 From: Stefan Benten Date: Fri, 8 Jul 2022 18:19:08 +0200 Subject: [PATCH] storagenode/retain: Move summary and start logs to info level (#4954) We currently do not log the GC information/stats under normal circumstances. This is not good for monitoring and troubleshooting. --- storagenode/retain/retain.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/storagenode/retain/retain.go b/storagenode/retain/retain.go index 435a9a736..522754a15 100644 --- a/storagenode/retain/retain.go +++ b/storagenode/retain/retain.go @@ -367,7 +367,7 @@ func (s *Service) retainPieces(ctx context.Context, req Request) (err error) { mon.IntVal("garbage_collection_filter_size").Observe(filter.Size()) mon.IntVal("garbage_collection_started").Observe(started.Unix()) - s.log.Debug("Prepared to run a Retain request.", + s.log.Info("Prepared to run a Retain request.", zap.Time("Created Before", createdBefore), zap.Int64("Filter Size", filter.Size()), zap.Stringer("Satellite ID", satelliteID)) @@ -430,7 +430,7 @@ func (s *Service) retainPieces(ctx context.Context, req Request) (err error) { mon.IntVal("garbage_collection_pieces_to_delete_count").Observe(piecesToDeleteCount) mon.IntVal("garbage_collection_pieces_deleted").Observe(int64(numDeleted)) mon.DurationVal("garbage_collection_loop_duration").Observe(time.Now().UTC().Sub(started)) - s.log.Debug("Moved pieces to trash during retain", zap.Int("num deleted", numDeleted), zap.String("Retain Status", s.config.Status.String())) + s.log.Info("Moved pieces to trash during retain", zap.Int("num deleted", numDeleted), zap.String("Retain Status", s.config.Status.String())) return nil }