JakeHillion/storj
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

pr template: migrations run concurrently with api servers now

Browse Source
This commit is contained in:
JT Olio 2019-10-31 09:27:46 -06:00 committed by GitHub
parent 43103ae13f
commit 8601f54f32
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
.github/pull_request_template.md vendored
View File

@ -10,6 +10,7 @@ Please describe the tests:
Please describe the performance impact: Please describe the performance impact:
## Code Review Checklist (to be filled out by reviewer) ## Code Review Checklist (to be filled out by reviewer)
- [ ] NEW: Are there any Satellite database migrations? Are they forwards _and_ backwards compatible?
- [ ] Does the PR describe what changes are being made? - [ ] Does the PR describe what changes are being made?
- [ ] Does the PR describe why the changes are being made? - [ ] Does the PR describe why the changes are being made?
- [ ] Does the code follow [our style guide](https://github.com/storj/docs/blob/master/code/Style.md)? - [ ] Does the code follow [our style guide](https://github.com/storj/docs/blob/master/code/Style.md)?
@ -19,3 +20,4 @@ Please describe the performance impact:
- [ ] Does the new code have enough documentation that answers "how do I use it?" and "what does it do?"? (both source documentation and [higher level](https://github.com/storj/docs), diagrams?) - [ ] Does the new code have enough documentation that answers "how do I use it?" and "what does it do?"? (both source documentation and [higher level](https://github.com/storj/docs), diagrams?)
- [ ] Does any documentation need updating? - [ ] Does any documentation need updating?
- [ ] Do the database access patterns make sense? - [ ] Do the database access patterns make sense?