From 8601f54f321681eb6e800dc57f8802380d3736bf Mon Sep 17 00:00:00 2001 From: JT Olio Date: Thu, 31 Oct 2019 09:27:46 -0600 Subject: [PATCH] pr template: migrations run concurrently with api servers now --- .github/pull_request_template.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 24e138dfa..be64b9ee6 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -10,6 +10,7 @@ Please describe the tests: Please describe the performance impact: ## Code Review Checklist (to be filled out by reviewer) + - [ ] NEW: Are there any Satellite database migrations? Are they forwards _and_ backwards compatible? - [ ] Does the PR describe what changes are being made? - [ ] Does the PR describe why the changes are being made? - [ ] Does the code follow [our style guide](https://github.com/storj/docs/blob/master/code/Style.md)? @@ -19,3 +20,4 @@ Please describe the performance impact: - [ ] Does the new code have enough documentation that answers "how do I use it?" and "what does it do?"? (both source documentation and [higher level](https://github.com/storj/docs), diagrams?) - [ ] Does any documentation need updating? - [ ] Do the database access patterns make sense? +