JakeHillion/storj
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

clarify who fills in the code review checklist (#1555)

Browse Source 
Change-Id: Ifabc09c6ed8dd10fcda6b0298d127b19d76e4674
This commit is contained in:
JT Olio 2019-03-27 17:19:22 -06:00 committed by GitHub
parent 7336e87e1c
commit 0a0984707c
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
.github/pull_request_template.md vendored
View File

@ -1,7 +1,10 @@
Thanks for submitting a PR!
## Code Review Checklist ![](https://media.giphy.com/media/14nakW0jC4HA6k/giphy.gif)
## Code Review Checklist (to be filled out by reviewer)
- [ ] Does the PR describe what changes are being made? - [ ] Does the PR describe what changes are being made?
- [ ] Does the PR describe why the changes are being made? - [ ] Does the PR describe why the changes are being made?
- [ ] Does the code follow [our style guide](https://github.com/storj/docs/blob/master/code/Style.md)? - [ ] Does the code follow [our style guide](https://github.com/storj/docs/blob/master/code/Style.md)?
@ -10,8 +13,3 @@
- [ ] Does the new code have enough tests? (*every* PR should have tests or justification otherwise. Bug-fix PRs especially) - [ ] Does the new code have enough tests? (*every* PR should have tests or justification otherwise. Bug-fix PRs especially)
- [ ] Does the new code have enough documentation that answers "how do I use it?" and "what does it do?"? (both source documentation and [higher level](https://github.com/storj/docs), diagrams?) - [ ] Does the new code have enough documentation that answers "how do I use it?" and "what does it do?"? (both source documentation and [higher level](https://github.com/storj/docs), diagrams?)
- [ ] Does any documentation need updating? - [ ] Does any documentation need updating?
Thanks for submitting a PR!
![](https://media.giphy.com/media/14nakW0jC4HA6k/giphy.gif)