From 0a0984707cc26843c6120c4545833c2d9e07a674 Mon Sep 17 00:00:00 2001 From: JT Olio Date: Wed, 27 Mar 2019 17:19:22 -0600 Subject: [PATCH] clarify who fills in the code review checklist (#1555) Change-Id: Ifabc09c6ed8dd10fcda6b0298d127b19d76e4674 --- .github/pull_request_template.md | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index b0c09ebec..746c70276 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -1,7 +1,10 @@ +Thanks for submitting a PR! -## Code Review Checklist +![](https://media.giphy.com/media/14nakW0jC4HA6k/giphy.gif) + +## Code Review Checklist (to be filled out by reviewer) - [ ] Does the PR describe what changes are being made? - [ ] Does the PR describe why the changes are being made? - [ ] Does the code follow [our style guide](https://github.com/storj/docs/blob/master/code/Style.md)? @@ -10,8 +13,3 @@ - [ ] Does the new code have enough tests? (*every* PR should have tests or justification otherwise. Bug-fix PRs especially) - [ ] Does the new code have enough documentation that answers "how do I use it?" and "what does it do?"? (both source documentation and [higher level](https://github.com/storj/docs), diagrams?) - [ ] Does any documentation need updating? - - -Thanks for submitting a PR! - -![](https://media.giphy.com/media/14nakW0jC4HA6k/giphy.gif)