4424697d7f
live accounting used to be a cache to store writes before they are picked up during the tally iteration, after which the cache is cleared. This created a window in which users could potentially exceed the storage limit. This PR refactors live accounting to hold current estimations of space used per project. This should also reduce DB load since we no longer need to query the satellite DB when checking space used for limiting. The mechanism by which the new live accounting system works is as follows: During the upload of any segment, the size of that segment is added to its respective project total in live accounting. At the beginning of the tally iteration we record the current values in live accounting as `initialLiveTotals`. At the end of the tally iteration we again record the current totals in live accounting as `latestLiveTotals`. The metainfo loop observer in tally allows us to get the project totals from what it observed in metainfo DB which are stored in `tallyProjectTotals`. However, for any particular segment uploaded during the metainfo loop, the observer may or may not have seen it. Thus, we take half of the difference between `latestLiveTotals` and `initialLiveTotals`, and add that to the total that was found during tally and set that as the new live accounting total. Initially, live accounting was storing the total stored amount across all nodes rather than the segment size, which is inconsistent with how we record amounts stored in the project accounting DB, so we have refactored live accounting to record segment size Change-Id: Ie48bfdef453428fcdc180b2d781a69d58fd927fb
44 lines
1.2 KiB
Go
44 lines
1.2 KiB
Go
// Copyright (C) 2019 Storj Labs, Inc.
|
|
// See LICENSE for copying information.
|
|
|
|
package live
|
|
|
|
import (
|
|
"strings"
|
|
|
|
"github.com/zeebo/errs"
|
|
"go.uber.org/zap"
|
|
"gopkg.in/spacemonkeygo/monkit.v2"
|
|
|
|
"storj.io/storj/satellite/accounting"
|
|
)
|
|
|
|
var (
|
|
// Error is the default error class for live-accounting
|
|
Error = errs.Class("live-accounting")
|
|
mon = monkit.Package()
|
|
)
|
|
|
|
// Config contains configurable values for the live accounting service.
|
|
type Config struct {
|
|
StorageBackend string `help:"what to use for storing real-time accounting data"`
|
|
}
|
|
|
|
// NewCache creates a new accounting.Cache instance using the type specified backend in
|
|
// the provided config.
|
|
func NewCache(log *zap.Logger, config Config) (accounting.Cache, error) {
|
|
parts := strings.SplitN(config.StorageBackend, ":", 2)
|
|
var backendType string
|
|
if len(parts) == 0 || parts[0] == "" {
|
|
return nil, Error.New("please specify a backend for live accounting")
|
|
}
|
|
|
|
backendType = parts[0]
|
|
switch backendType {
|
|
case "redis":
|
|
return newRedisLiveAccounting(log, config.StorageBackend)
|
|
default:
|
|
return nil, Error.New("unrecognized live accounting backend specifier %q. Currently only redis is supported", backendType)
|
|
}
|
|
}
|