e37435602f
Two things were done to optimize audit observer: * monik call was removed as we have different way to track it * no new allocation for audit.Segment struct inside observer Benchmark against 'main': name old time/op new time/op delta RemoteSegment/Cockroach/multiple_segments-8 5.85µs ± 1% 0.74µs ± 4% -87.28% (p=0.008 n=5+5) name old alloc/op new alloc/op delta RemoteSegment/Cockroach/multiple_segments-8 2.72kB ± 0% 0.00kB ~ (p=0.079 n=4+5) name old allocs/op new allocs/op delta RemoteSegment/Cockroach/multiple_segments-8 50.0 ± 0% 0.0 -100.00% (p=0.008 n=5+5) Change-Id: Ib973e48782bad4346eee1cd5aee77f0a50f69258
104 lines
2.3 KiB
Go
104 lines
2.3 KiB
Go
// Copyright (C) 2019 Storj Labs, Inc.
|
|
// See LICENSE for copying information.
|
|
|
|
package audit
|
|
|
|
import (
|
|
"context"
|
|
"math/rand"
|
|
"time"
|
|
|
|
"go.uber.org/zap"
|
|
|
|
"storj.io/common/sync2"
|
|
"storj.io/common/uuid"
|
|
"storj.io/storj/satellite/metabase/segmentloop"
|
|
)
|
|
|
|
// Chore populates reservoirs and the audit queue.
|
|
//
|
|
// architecture: Chore
|
|
type Chore struct {
|
|
log *zap.Logger
|
|
rand *rand.Rand
|
|
queues *Queues
|
|
Loop *sync2.Cycle
|
|
|
|
segmentLoop *segmentloop.Service
|
|
config Config
|
|
}
|
|
|
|
// NewChore instantiates Chore.
|
|
func NewChore(log *zap.Logger, queues *Queues, loop *segmentloop.Service, config Config) *Chore {
|
|
return &Chore{
|
|
log: log,
|
|
rand: rand.New(rand.NewSource(time.Now().Unix())),
|
|
queues: queues,
|
|
Loop: sync2.NewCycle(config.ChoreInterval),
|
|
|
|
segmentLoop: loop,
|
|
config: config,
|
|
}
|
|
}
|
|
|
|
// Run starts the chore.
|
|
func (chore *Chore) Run(ctx context.Context) (err error) {
|
|
defer mon.Task()(&ctx)(&err)
|
|
return chore.Loop.Run(ctx, func(ctx context.Context) (err error) {
|
|
defer mon.Task()(&ctx)(&err)
|
|
|
|
// If the previously pushed queue is still waiting to be swapped in, wait.
|
|
err = chore.queues.WaitForSwap(ctx)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
collector := NewCollector(chore.config.Slots, chore.rand)
|
|
err = chore.segmentLoop.Join(ctx, collector)
|
|
if err != nil {
|
|
chore.log.Error("error joining segmentloop", zap.Error(err))
|
|
return nil
|
|
}
|
|
|
|
type SegmentKey struct {
|
|
StreamID uuid.UUID
|
|
Position uint64
|
|
}
|
|
|
|
var newQueue []Segment
|
|
queueSegments := make(map[SegmentKey]struct{})
|
|
|
|
// Add reservoir segments to queue in pseudorandom order.
|
|
for i := 0; i < chore.config.Slots; i++ {
|
|
for _, res := range collector.Reservoirs {
|
|
// Skip reservoir if no segment at this index.
|
|
if len(res.Segments) <= i {
|
|
continue
|
|
}
|
|
segment := res.Segments[i]
|
|
segmentKey := SegmentKey{
|
|
StreamID: segment.StreamID,
|
|
Position: segment.Position.Encode(),
|
|
}
|
|
if segmentKey == (SegmentKey{}) {
|
|
continue
|
|
}
|
|
|
|
if _, ok := queueSegments[segmentKey]; !ok {
|
|
newQueue = append(newQueue, NewSegment(segment))
|
|
queueSegments[segmentKey] = struct{}{}
|
|
}
|
|
}
|
|
}
|
|
|
|
// Push new queue to queues struct so it can be fetched by worker.
|
|
return chore.queues.Push(newQueue)
|
|
})
|
|
}
|
|
|
|
// Close closes chore.
|
|
func (chore *Chore) Close() error {
|
|
chore.Loop.Close()
|
|
return nil
|
|
}
|