35c022ebf9
TestRollupNoDeletes is very flaky (passes locally but fails in the main branch build). The exact reason is not clear, but stopping the loop seems to be async, the following lines may not stop the loops immediatelly which is a potential problem: ``` satellitePeer.Accounting.Rollup.Loop.Pause() satellitePeer.Accounting.Tally.Loop.Pause() ``` Fortunatelly these test check only the database interfaces. Instead of testplanet.Run we can run only satellitedbtest.Run which is faster and more predictable (no background loops). Other potential problem: comment claims that the default of DeleteTallies is false: ``` // In testplanet the setting config.Rollup.DeleteTallies defaults to false. ``` But it seems to be true (rollup.go): ``` DeleteTallies bool `help:"option for deleting tallies after they are rolled up" default:"true"` ``` This is also fixed in the patch (as we need set it explicit), but TBH it can be fixed with testplanet, too. Change-Id: Id7ec80d5c069bed2c556f4d001c71aa23fc5af23 |
||
|---|---|---|
| .. | ||
| common.go | ||
| rollup_test.go | ||
| rollup.go | ||