d20db90cff
it was noticed that if you had a long lived transaction A that was blocking some other transaction B and A was being aborted due to retriable errors, then transaction B was never given priority. this was due to using savepoints to do lightweight retries. this behavior was problematic becaue we had some queries blocked for over 16 hours, so this commit addresses the issue with two prongs: 1. bound the amount of time we will retry a transaction 2. create new transactions when a retry is needed the first ensures that we never wait for 16 hours, and the value chosen is 10 minutes. that should be long enough for an ample amount of retries for small queries, and huge queries probably shouldn't be retried, even if possible: it's more preferrable to find a way to make them smaller. the second ensures that even in the case of retries, queries that are blocked on the aborted transaction gain priority to run. between those two changes, the maximum stall time due to retries should be bounded to around 10 minutes. Change-Id: Icf898501ef505a89738820a3fae2580988f9f5f4
264 lines
7.1 KiB
Go
264 lines
7.1 KiB
Go
// Copyright (C) 2019 Storj Labs, Inc.
|
|
// See LICENSE for copying information.
|
|
|
|
package migrate
|
|
|
|
import (
|
|
"context"
|
|
"database/sql"
|
|
"regexp"
|
|
"sort"
|
|
"strconv"
|
|
"time"
|
|
|
|
"github.com/zeebo/errs"
|
|
"go.uber.org/zap"
|
|
|
|
"storj.io/storj/private/dbutil/txutil"
|
|
"storj.io/storj/private/tagsql"
|
|
)
|
|
|
|
var (
|
|
// ErrValidateVersionQuery is when there is an error querying version table
|
|
ErrValidateVersionQuery = errs.Class("validate db version query error")
|
|
// ErrValidateVersionMismatch is when the migration version does not match the current database version
|
|
ErrValidateVersionMismatch = errs.Class("validate db version mismatch error")
|
|
// ErrValidateMinVersion is when the migration version does not match the current database version
|
|
ErrValidateMinVersion = errs.Class("validate minimum version error")
|
|
)
|
|
|
|
/*
|
|
|
|
Scenarios it doesn't handle properly.
|
|
|
|
1. Rollback to initial state on multi-step migration.
|
|
|
|
Let's say there's a scenario where we run migration steps:
|
|
1. update a table schema
|
|
2. move files
|
|
3. update a table schema
|
|
4. update a table schema, which fails
|
|
|
|
In this case there's no easy way to rollback the moving of files.
|
|
|
|
2. Undoing migrations.
|
|
|
|
Intentionally left out, because we do not gain that much from currently.
|
|
|
|
3. Snapshotting the whole state.
|
|
|
|
This probably should be done by the user of this library, when there's disk-space available.
|
|
|
|
4. Figuring out what the exact executed steps are.
|
|
*/
|
|
|
|
// Migration describes a migration steps
|
|
type Migration struct {
|
|
Table string
|
|
Steps []*Step
|
|
}
|
|
|
|
// Step describes a single step in migration.
|
|
type Step struct {
|
|
DB tagsql.DB // The DB to execute this step on
|
|
Description string
|
|
Version int // Versions should start at 0
|
|
Action Action
|
|
}
|
|
|
|
// Action is something that needs to be done
|
|
type Action interface {
|
|
Run(ctx context.Context, log *zap.Logger, db tagsql.DB, tx tagsql.Tx) error
|
|
}
|
|
|
|
// TargetVersion returns migration with steps upto specified version
|
|
func (migration *Migration) TargetVersion(version int) *Migration {
|
|
m := *migration
|
|
m.Steps = nil
|
|
for _, step := range migration.Steps {
|
|
if step.Version <= version {
|
|
m.Steps = append(m.Steps, step)
|
|
}
|
|
}
|
|
return &m
|
|
}
|
|
|
|
// ValidTableName checks whether the specified table name is valid
|
|
func (migration *Migration) ValidTableName() error {
|
|
matched, err := regexp.MatchString(`^[a-z_]+$`, migration.Table)
|
|
if !matched || err != nil {
|
|
return Error.New("invalid table name: %v", migration.Table)
|
|
}
|
|
return nil
|
|
}
|
|
|
|
// ValidateSteps checks that the version for each migration step increments in order
|
|
func (migration *Migration) ValidateSteps() error {
|
|
sorted := sort.SliceIsSorted(migration.Steps, func(i, j int) bool {
|
|
return migration.Steps[i].Version <= migration.Steps[j].Version
|
|
})
|
|
if !sorted {
|
|
return Error.New("steps have incorrect order")
|
|
}
|
|
return nil
|
|
}
|
|
|
|
// ValidateVersions checks that the version of the migration matches the state of the database
|
|
func (migration *Migration) ValidateVersions(ctx context.Context, log *zap.Logger) error {
|
|
for _, step := range migration.Steps {
|
|
dbVersion, err := migration.getLatestVersion(ctx, log, step.DB)
|
|
if err != nil {
|
|
return ErrValidateVersionQuery.Wrap(err)
|
|
}
|
|
|
|
if step.Version > dbVersion {
|
|
return ErrValidateVersionMismatch.New("expected %d <= %d", step.Version, dbVersion)
|
|
}
|
|
}
|
|
|
|
if len(migration.Steps) > 0 {
|
|
last := migration.Steps[len(migration.Steps)-1]
|
|
log.Debug("Database version is up to date", zap.Int("version", last.Version))
|
|
} else {
|
|
log.Debug("No Versions")
|
|
}
|
|
|
|
return nil
|
|
}
|
|
|
|
// Run runs the migration steps
|
|
func (migration *Migration) Run(ctx context.Context, log *zap.Logger) error {
|
|
err := migration.ValidTableName()
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
err = migration.ValidateSteps()
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
initialSetup := false
|
|
for i, step := range migration.Steps {
|
|
step := step
|
|
if step.DB == nil {
|
|
return Error.New("step.DB is nil for step %d", step.Version)
|
|
}
|
|
|
|
err = migration.ensureVersionTable(ctx, log, step.DB)
|
|
if err != nil {
|
|
return Error.New("creating version table failed: %w", err)
|
|
}
|
|
|
|
version, err := migration.getLatestVersion(ctx, log, step.DB)
|
|
if err != nil {
|
|
return Error.Wrap(err)
|
|
}
|
|
if i == 0 && version < 0 {
|
|
initialSetup = true
|
|
}
|
|
|
|
if step.Version <= version {
|
|
continue
|
|
}
|
|
|
|
stepLog := log.Named(strconv.Itoa(step.Version))
|
|
if !initialSetup {
|
|
stepLog.Info(step.Description)
|
|
}
|
|
|
|
err = txutil.WithTx(ctx, step.DB, nil, func(ctx context.Context, tx tagsql.Tx) error {
|
|
err = step.Action.Run(ctx, stepLog, step.DB, tx)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
err = migration.addVersion(ctx, tx, step.DB, step.Version)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
return nil
|
|
})
|
|
if err != nil {
|
|
return Error.Wrap(err)
|
|
}
|
|
}
|
|
|
|
if len(migration.Steps) > 0 {
|
|
last := migration.Steps[len(migration.Steps)-1]
|
|
if initialSetup {
|
|
log.Info("Database Created", zap.Int("version", last.Version))
|
|
} else {
|
|
log.Info("Database Version", zap.Int("version", last.Version))
|
|
}
|
|
} else {
|
|
log.Info("No Versions")
|
|
}
|
|
|
|
return nil
|
|
}
|
|
|
|
// createVersionTable creates a new version table
|
|
func (migration *Migration) ensureVersionTable(ctx context.Context, log *zap.Logger, db tagsql.DB) error {
|
|
err := txutil.WithTx(ctx, db, nil, func(ctx context.Context, tx tagsql.Tx) error {
|
|
_, err := tx.Exec(ctx, rebind(db, `CREATE TABLE IF NOT EXISTS `+migration.Table+` (version int, commited_at text)`)) //nolint:misspell
|
|
return err
|
|
})
|
|
return Error.Wrap(err)
|
|
}
|
|
|
|
// getLatestVersion finds the latest version table
|
|
func (migration *Migration) getLatestVersion(ctx context.Context, log *zap.Logger, db tagsql.DB) (int, error) {
|
|
var version sql.NullInt64
|
|
err := txutil.WithTx(ctx, db, nil, func(ctx context.Context, tx tagsql.Tx) error {
|
|
err := tx.QueryRow(ctx, rebind(db, `SELECT MAX(version) FROM `+migration.Table)).Scan(&version)
|
|
if err == sql.ErrNoRows || !version.Valid {
|
|
version.Int64 = -1
|
|
return nil
|
|
}
|
|
return err
|
|
})
|
|
|
|
return int(version.Int64), Error.Wrap(err)
|
|
}
|
|
|
|
// addVersion adds information about a new migration
|
|
func (migration *Migration) addVersion(ctx context.Context, tx tagsql.Tx, db tagsql.DB, version int) error {
|
|
_, err := tx.Exec(ctx, rebind(db, `
|
|
INSERT INTO `+migration.Table+` (version, commited_at) VALUES (?, ?)`), //nolint:misspell
|
|
version, time.Now().String(),
|
|
)
|
|
return err
|
|
}
|
|
|
|
// CurrentVersion finds the latest version for the db
|
|
func (migration *Migration) CurrentVersion(ctx context.Context, log *zap.Logger, db tagsql.DB) (int, error) {
|
|
err := migration.ensureVersionTable(ctx, log, db)
|
|
if err != nil {
|
|
return -1, Error.Wrap(err)
|
|
}
|
|
return migration.getLatestVersion(ctx, log, db)
|
|
}
|
|
|
|
// SQL statements that are executed on the database
|
|
type SQL []string
|
|
|
|
// Run runs the SQL statements
|
|
func (sql SQL) Run(ctx context.Context, log *zap.Logger, db tagsql.DB, tx tagsql.Tx) (err error) {
|
|
for _, query := range sql {
|
|
_, err := tx.Exec(ctx, rebind(db, query))
|
|
if err != nil {
|
|
return err
|
|
}
|
|
}
|
|
return nil
|
|
}
|
|
|
|
// Func is an arbitrary operation
|
|
type Func func(ctx context.Context, log *zap.Logger, db tagsql.DB, tx tagsql.Tx) error
|
|
|
|
// Run runs the migration
|
|
func (fn Func) Run(ctx context.Context, log *zap.Logger, db tagsql.DB, tx tagsql.Tx) error {
|
|
return fn(ctx, log, db, tx)
|
|
}
|