storj/satellite/orders
Márton Elek 98921f9faa satellite/overlay: fix placement selection config parsing
When we do `satellite run api --placement '...'`, the placement rules are not parsed well.

The problem is based on `viper.AllSettings()`, and the main logic is sg. like this (from a new unit test):

```
		r := ConfigurablePlacementRule{}
		err := r.Set(p)
		require.NoError(t, err)
		serialized := r.String()

		r2 := ConfigurablePlacementRule{}
		err = r2.Set(serialized)
		require.NoError(t, err)

		require.Equal(t, p, r2.String())
```

All settings evaluates the placement rules in `ConfigurablePlacementRules` and stores the string representation.

The problem is that we don't have proper `String()` implementation (it prints out the structs instead of the original definition.

There are two main solutions for this problem:

 1. We can fix the `String()`. When we parse a placement rule, the `String()` method should print out the original definition
 2. We can switch to use pure string as configuration parameter, and parse the rules only when required.

I feel that 1 is error prone, we can do it (and in this patch I added a lot of `String()` implementations, but it's hard to be sure that our `String()` logic is inline with the parsing logic.

Therefore I decided to make the configuration value of the placements a string (or a wrapper around string).

That's the main reason why this patch seems to be big, as I updated all the usages.

But the main part is in beginning of the `placement.go` (configuration parsing is not a pflag.Value implementation any more, but a separated step).

And `filter.go`, (a few more String implementation for filters.

https://github.com/storj/storj/issues/6248

Change-Id: I47c762d3514342b76a2e85683b1c891502a0756a
2023-09-21 14:31:41 +00:00
..
encryptionkey_test.go satellite/orders: add factory function to encryption key 2020-11-20 11:40:15 -08:00
encryptionkey.go satellite/orders: use smaller encrypted metadata 2021-01-08 16:40:31 +00:00
endpoint_test.go satellite/metabase: move package one level higher 2021-04-21 15:54:22 +03:00
endpoint.go satellite/orders: cleanup after altering primary key 2023-03-06 16:03:11 +00:00
mock_test.go satellite: move satellite/nodeselection/uploadselection => satellite/nodeselection 2023-07-07 10:32:03 +02:00
orders_test.go satellites/orders: populate egress_dead in project_bandwidth_daily_rollups 2021-10-06 16:54:49 +00:00
rollups_chore.go satellite/orders: Flush all pending bandwidth rollup writes on shutdown 2020-01-23 08:12:41 -07:00
rollups_write_cache_test.go satellite/orders: ignore context canceled when updating bucket bandwidth 2023-02-08 13:21:42 +00:00
rollups_write_cache.go satellite/orders: don't cancel flushing bandwidth orders 2023-03-01 17:10:05 +00:00
service_integration_test.go satellite/metainfo: support desired node number for download object/segment 2023-02-13 13:57:48 +00:00
service_test.go satellite/overlay: fix placement selection config parsing 2023-09-21 14:31:41 +00:00
service.go satellite/overlay: change Reliable and KnownReliable 2023-09-02 23:34:50 +00:00
signer_test.go satellite/overlay: return noise info with selected nodes 2023-02-02 15:46:27 +00:00
signer.go satellite/overlay: return noise info with selected nodes 2023-02-02 15:46:27 +00:00
window_endpoint_phase.go satellite/orders: 3-phase rollout 2020-08-03 17:01:42 +00:00