25df79a6bf
Check binary version on self-update instead of current process version to prevent updating already updated binary. Add info logs to report current version of service beeing updated. Change-Id: Id22dee188a99d6d45db925104786f49f5d3a61ae
78 lines
2.0 KiB
Go
78 lines
2.0 KiB
Go
// Copyright (C) 2020 Storj Labs, Inc.
|
|
// See LICENSE for copying information.
|
|
|
|
package main
|
|
|
|
import (
|
|
"context"
|
|
"os"
|
|
|
|
"github.com/zeebo/errs"
|
|
"go.uber.org/zap"
|
|
|
|
"storj.io/private/version"
|
|
)
|
|
|
|
func update(ctx context.Context, serviceName, binaryLocation string, ver version.Process) error {
|
|
suggestedVersion, err := ver.Suggested.SemVer()
|
|
if err != nil {
|
|
return errs.Wrap(err)
|
|
}
|
|
|
|
currentVersion, err := binaryVersion(binaryLocation)
|
|
if err != nil {
|
|
return errs.Wrap(err)
|
|
}
|
|
|
|
zap.L().Info("Current binary version",
|
|
zap.String("Service", serviceName),
|
|
zap.String("Version", currentVersion.String()),
|
|
)
|
|
|
|
// should update
|
|
shouldUpdate, reason, err := version.ShouldUpdateVersion(currentVersion, nodeID, ver)
|
|
if err != nil {
|
|
return errs.Wrap(err)
|
|
}
|
|
if !shouldUpdate {
|
|
zap.L().Info(reason, zap.String("Service", serviceName))
|
|
return nil
|
|
}
|
|
|
|
newVersionPath := prependExtension(binaryLocation, ver.Suggested.Version)
|
|
|
|
if err = downloadBinary(ctx, parseDownloadURL(ver.Suggested.URL), newVersionPath); err != nil {
|
|
return errs.Wrap(err)
|
|
}
|
|
|
|
downloadedVersion, err := binaryVersion(newVersionPath)
|
|
if err != nil {
|
|
return errs.Combine(errs.Wrap(err), os.Remove(newVersionPath))
|
|
}
|
|
|
|
if suggestedVersion.Compare(downloadedVersion) != 0 {
|
|
err := errs.New("invalid version downloaded: wants %s got %s",
|
|
suggestedVersion.String(),
|
|
downloadedVersion.String(),
|
|
)
|
|
return errs.Combine(err, os.Remove(newVersionPath))
|
|
}
|
|
|
|
var backupPath string
|
|
if serviceName == updaterServiceName {
|
|
// NB: don't include old version number for updater binary backup
|
|
backupPath = prependExtension(binaryLocation, "old")
|
|
} else {
|
|
backupPath = prependExtension(binaryLocation, "old."+currentVersion.String())
|
|
}
|
|
|
|
zap.L().Info("Restarting service.", zap.String("Service", serviceName))
|
|
|
|
if err = restartService(ctx, serviceName, binaryLocation, newVersionPath, backupPath); err != nil {
|
|
return errs.Wrap(err)
|
|
}
|
|
|
|
zap.L().Info("Service restarted successfully.", zap.String("Service", serviceName))
|
|
return nil
|
|
}
|