0ba516d405
the immediate need is to be able to move the repair queue back out of cockroach if we can't save it. Change-Id: If26001a4e6804f6bb8713b4aee7e4fd6254dc326
154 lines
4.6 KiB
Go
154 lines
4.6 KiB
Go
// Copyright (C) 2019 Storj Labs, Inc.
|
|
// See LICENSE for copying information.
|
|
|
|
package satellitedb
|
|
|
|
import (
|
|
"context"
|
|
"database/sql"
|
|
"errors"
|
|
"time"
|
|
|
|
"github.com/zeebo/errs"
|
|
|
|
"storj.io/storj/private/dbutil"
|
|
"storj.io/storj/satellite/internalpb"
|
|
"storj.io/storj/satellite/satellitedb/dbx"
|
|
"storj.io/storj/storage"
|
|
)
|
|
|
|
// RepairQueueSelectLimit defines how many items can be selected at the same time.
|
|
const RepairQueueSelectLimit = 1000
|
|
|
|
type repairQueue struct {
|
|
db *satelliteDB
|
|
}
|
|
|
|
func (r *repairQueue) TestDBAccess() *dbx.DB {
|
|
return r.db.DB
|
|
}
|
|
|
|
func (r *repairQueue) Insert(ctx context.Context, seg *internalpb.InjuredSegment, segmentHealth float64) (alreadyInserted bool, err error) {
|
|
defer mon.Task()(&ctx)(&err)
|
|
// insert if not exists, or update healthy count if does exist
|
|
var query string
|
|
|
|
// we want to insert the segment if it is not in the queue, but update the number of healthy pieces if it already is in the queue
|
|
// we also want to know if the result was an insert or an update - this is the reasoning for the xmax section of the postgres query
|
|
// and the separate cockroach query (which the xmax trick does not work for)
|
|
switch r.db.implementation {
|
|
case dbutil.Postgres:
|
|
query = `
|
|
INSERT INTO injuredsegments
|
|
(
|
|
path, data, segment_health
|
|
)
|
|
VALUES (
|
|
$1, $2, $3
|
|
)
|
|
ON CONFLICT (path)
|
|
DO UPDATE
|
|
SET segment_health=$3, updated_at=current_timestamp
|
|
RETURNING (xmax != 0) AS alreadyInserted
|
|
`
|
|
case dbutil.Cockroach:
|
|
query = `
|
|
WITH updater AS (
|
|
UPDATE injuredsegments SET segment_health = $3, updated_at = current_timestamp WHERE path = $1
|
|
RETURNING *
|
|
)
|
|
INSERT INTO injuredsegments (path, data, segment_health)
|
|
SELECT $1, $2, $3
|
|
WHERE NOT EXISTS (SELECT * FROM updater)
|
|
RETURNING false
|
|
`
|
|
}
|
|
rows, err := r.db.QueryContext(ctx, query, seg.Path, seg, segmentHealth)
|
|
if err != nil {
|
|
return false, err
|
|
}
|
|
defer func() { err = errs.Combine(err, rows.Close()) }()
|
|
|
|
if !rows.Next() {
|
|
// cockroach query does not return anything if the segment is already in the queue
|
|
alreadyInserted = true
|
|
} else {
|
|
err = rows.Scan(&alreadyInserted)
|
|
if err != nil {
|
|
return false, err
|
|
}
|
|
}
|
|
return alreadyInserted, rows.Err()
|
|
}
|
|
|
|
func (r *repairQueue) Select(ctx context.Context) (seg *internalpb.InjuredSegment, err error) {
|
|
defer mon.Task()(&ctx)(&err)
|
|
switch r.db.implementation {
|
|
case dbutil.Cockroach:
|
|
err = r.db.QueryRowContext(ctx, `
|
|
UPDATE injuredsegments SET attempted = now() WHERE path = (
|
|
SELECT path FROM injuredsegments
|
|
WHERE attempted IS NULL OR attempted < now() - interval '6 hours'
|
|
ORDER BY segment_health ASC, attempted LIMIT 1
|
|
) RETURNING data`).Scan(&seg)
|
|
case dbutil.Postgres:
|
|
err = r.db.QueryRowContext(ctx, `
|
|
UPDATE injuredsegments SET attempted = now() WHERE path = (
|
|
SELECT path FROM injuredsegments
|
|
WHERE attempted IS NULL OR attempted < now() - interval '6 hours'
|
|
ORDER BY segment_health ASC, attempted NULLS FIRST FOR UPDATE SKIP LOCKED LIMIT 1
|
|
) RETURNING data`).Scan(&seg)
|
|
default:
|
|
return seg, errs.New("invalid dbType: %v", r.db.implementation)
|
|
}
|
|
if errors.Is(err, sql.ErrNoRows) {
|
|
err = storage.ErrEmptyQueue.New("")
|
|
}
|
|
return seg, err
|
|
}
|
|
|
|
func (r *repairQueue) Delete(ctx context.Context, seg *internalpb.InjuredSegment) (err error) {
|
|
defer mon.Task()(&ctx)(&err)
|
|
_, err = r.db.ExecContext(ctx, r.db.Rebind(`DELETE FROM injuredsegments WHERE path = ?`), seg.Path)
|
|
return Error.Wrap(err)
|
|
}
|
|
|
|
func (r *repairQueue) Clean(ctx context.Context, before time.Time) (deleted int64, err error) {
|
|
defer mon.Task()(&ctx)(&err)
|
|
n, err := r.db.Delete_Injuredsegment_By_UpdatedAt_Less(ctx, dbx.Injuredsegment_UpdatedAt(before))
|
|
return n, Error.Wrap(err)
|
|
}
|
|
|
|
func (r *repairQueue) SelectN(ctx context.Context, limit int) (segs []internalpb.InjuredSegment, err error) {
|
|
defer mon.Task()(&ctx)(&err)
|
|
if limit <= 0 || limit > RepairQueueSelectLimit {
|
|
limit = RepairQueueSelectLimit
|
|
}
|
|
// TODO: strictly enforce order-by or change tests
|
|
rows, err := r.db.QueryContext(ctx, r.db.Rebind(`SELECT data FROM injuredsegments LIMIT ?`), limit)
|
|
if err != nil {
|
|
return nil, Error.Wrap(err)
|
|
}
|
|
defer func() { err = errs.Combine(err, rows.Close()) }()
|
|
|
|
for rows.Next() {
|
|
var seg internalpb.InjuredSegment
|
|
err = rows.Scan(&seg)
|
|
if err != nil {
|
|
return segs, Error.Wrap(err)
|
|
}
|
|
segs = append(segs, seg)
|
|
}
|
|
|
|
return segs, Error.Wrap(rows.Err())
|
|
}
|
|
|
|
func (r *repairQueue) Count(ctx context.Context) (count int, err error) {
|
|
defer mon.Task()(&ctx)(&err)
|
|
|
|
// Count every segment regardless of how recently repair was last attempted
|
|
err = r.db.QueryRowContext(ctx, r.db.Rebind(`SELECT COUNT(*) as count FROM injuredsegments`)).Scan(&count)
|
|
|
|
return count, Error.Wrap(err)
|
|
}
|