bb575ef739
Fix the Admin API endpoints when it response with a client error response code. The most of the client response error send a JSON body but the `Content-Type` header wasn't set to the appropriated value. This commit fixes them and it adds assertions to the tests to very the `Content-Type` header. Updates the README to briefly document about the format of the client errors endpoints responses. Change-Id: Ifaf2122def801701211438ce241046be1adc0e8c
85 lines
2.6 KiB
Go
85 lines
2.6 KiB
Go
// Copyright (C) 2020 Storj Labs, Inc.
|
|
// See LICENSE for copying information.
|
|
|
|
package admin_test
|
|
|
|
import (
|
|
"io/ioutil"
|
|
"net/http"
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/require"
|
|
"go.uber.org/zap"
|
|
|
|
"storj.io/common/testcontext"
|
|
"storj.io/storj/private/testplanet"
|
|
"storj.io/storj/satellite"
|
|
)
|
|
|
|
func TestBasic(t *testing.T) {
|
|
testplanet.Run(t, testplanet.Config{
|
|
SatelliteCount: 1,
|
|
StorageNodeCount: 0,
|
|
UplinkCount: 0,
|
|
Reconfigure: testplanet.Reconfigure{
|
|
Satellite: func(log *zap.Logger, index int, config *satellite.Config) {
|
|
config.Admin.Address = "127.0.0.1:0"
|
|
},
|
|
},
|
|
}, func(t *testing.T, ctx *testcontext.Context, planet *testplanet.Planet) {
|
|
sat := planet.Satellites[0]
|
|
address := sat.Admin.Admin.Listener.Addr()
|
|
|
|
t.Run("NoAccess", func(t *testing.T) {
|
|
req, err := http.NewRequestWithContext(ctx, http.MethodGet, "http://"+address.String(), nil)
|
|
require.NoError(t, err)
|
|
|
|
response, err := http.DefaultClient.Do(req)
|
|
require.NoError(t, err)
|
|
|
|
require.Equal(t, http.StatusForbidden, response.StatusCode)
|
|
require.Equal(t, "application/json", response.Header.Get("Content-Type"))
|
|
|
|
body, err := ioutil.ReadAll(response.Body)
|
|
require.NoError(t, response.Body.Close())
|
|
require.NoError(t, err)
|
|
require.Equal(t, `{"error":"Forbidden","detail":""}`, string(body))
|
|
})
|
|
|
|
t.Run("WrongAccess", func(t *testing.T) {
|
|
req, err := http.NewRequestWithContext(ctx, http.MethodGet, "http://"+address.String(), nil)
|
|
require.NoError(t, err)
|
|
req.Header.Set("Authorization", "wrong-key")
|
|
|
|
response, err := http.DefaultClient.Do(req)
|
|
require.NoError(t, err)
|
|
|
|
require.Equal(t, http.StatusForbidden, response.StatusCode)
|
|
require.Equal(t, "application/json", response.Header.Get("Content-Type"))
|
|
|
|
body, err := ioutil.ReadAll(response.Body)
|
|
require.NoError(t, response.Body.Close())
|
|
require.NoError(t, err)
|
|
require.Equal(t, `{"error":"Forbidden","detail":""}`, string(body))
|
|
})
|
|
|
|
t.Run("WithAccess", func(t *testing.T) {
|
|
req, err := http.NewRequestWithContext(ctx, http.MethodGet, "http://"+address.String(), nil)
|
|
require.NoError(t, err)
|
|
req.Header.Set("Authorization", planet.Satellites[0].Config.Console.AuthToken)
|
|
|
|
response, err := http.DefaultClient.Do(req)
|
|
require.NoError(t, err)
|
|
|
|
// currently no main page so 404
|
|
require.Equal(t, http.StatusNotFound, response.StatusCode)
|
|
require.Equal(t, "text/plain; charset=utf-8", response.Header.Get("Content-Type"))
|
|
|
|
body, err := ioutil.ReadAll(response.Body)
|
|
require.NoError(t, response.Body.Close())
|
|
require.NoError(t, err)
|
|
require.Contains(t, string(body), "not found")
|
|
})
|
|
})
|
|
}
|