b9d8ddaad1
* storagenode: remove datetime calls in favor of UTC datetime only has second level granularity whereas string comparisons don't. Since we're wiping everything anyway, it's easier to just use UTC everywhere rather than migrate to datetime calls. * add utcdb to check that arguments are utc * storagenodedb: add trivial tests to ensure calls work This at least tests that all of the timestamps passed in are in the UTC timezone. * fix truncated comment and change migrations to be UTC
78 lines
1.8 KiB
Go
78 lines
1.8 KiB
Go
// Copyright (C) 2019 Storj Labs, Inc.
|
|
// See LICENSE for copying information.
|
|
|
|
package storagenodedb
|
|
|
|
import (
|
|
"context"
|
|
"database/sql"
|
|
"database/sql/driver"
|
|
"testing"
|
|
"time"
|
|
|
|
"github.com/stretchr/testify/require"
|
|
)
|
|
|
|
func init() { utcChecks = true }
|
|
|
|
func TestUTCDB(t *testing.T) {
|
|
notUTC := time.FixedZone("not utc", -1)
|
|
db := utcDB{sql.OpenDB(emptyConnector{})}
|
|
|
|
{ // time.Time not in UTC
|
|
_, err := db.Exec("", time.Now().In(notUTC))
|
|
require.Error(t, err)
|
|
}
|
|
|
|
{ // *time.Time not in UTC
|
|
now := time.Now().In(notUTC)
|
|
_, err := db.Exec("", &now)
|
|
require.Error(t, err)
|
|
}
|
|
|
|
{ // time.Time in UTC
|
|
_, err := db.Exec("", time.Now().UTC())
|
|
require.NoError(t, err)
|
|
}
|
|
|
|
{ // *time.Time in UTC
|
|
now := time.Now().UTC()
|
|
_, err := db.Exec("", &now)
|
|
require.NoError(t, err)
|
|
}
|
|
|
|
{ // nil *time.Time
|
|
_, err := db.Exec("", (*time.Time)(nil))
|
|
require.NoError(t, err)
|
|
}
|
|
}
|
|
|
|
//
|
|
// empty driver
|
|
//
|
|
|
|
type emptyConnector struct{}
|
|
|
|
func (emptyConnector) Connect(context.Context) (driver.Conn, error) { return emptyConn{}, nil }
|
|
func (emptyConnector) Driver() driver.Driver { return nil }
|
|
|
|
type emptyConn struct{}
|
|
|
|
func (emptyConn) Prepare(query string) (driver.Stmt, error) { return emptyStmt{}, nil }
|
|
func (emptyConn) Close() error { return nil }
|
|
func (emptyConn) Begin() (driver.Tx, error) { return emptyTx{}, nil }
|
|
|
|
type emptyTx struct{}
|
|
|
|
func (emptyTx) Commit() error { return nil }
|
|
func (emptyTx) Rollback() error { return nil }
|
|
|
|
type emptyStmt struct{}
|
|
|
|
func (emptyStmt) Close() error { return nil }
|
|
func (emptyStmt) Exec(args []driver.Value) (driver.Result, error) { return nil, nil }
|
|
func (emptyStmt) Query(args []driver.Value) (driver.Rows, error) { return nil, nil }
|
|
|
|
// must be 1 so that we can pass 1 argument
|
|
func (emptyStmt) NumInput() int { return 1 }
|