ce1db97ce6
Satellite crashing on receiving a manipulated bandwidthagreement V3-1022
126 lines
3.4 KiB
Go
126 lines
3.4 KiB
Go
// Copyright (C) 2018 Storj Labs, Inc.
|
|
// See LICENSE for copying information.
|
|
|
|
package bwagreement
|
|
|
|
import (
|
|
"context"
|
|
"crypto"
|
|
"crypto/ecdsa"
|
|
"crypto/x509"
|
|
"time"
|
|
|
|
"github.com/gogo/protobuf/proto"
|
|
"github.com/gtank/cryptopasta"
|
|
"go.uber.org/zap"
|
|
|
|
"storj.io/storj/pkg/pb"
|
|
"storj.io/storj/pkg/peertls"
|
|
)
|
|
|
|
// DB stores bandwidth agreements.
|
|
type DB interface {
|
|
// CreateAgreement adds a new bandwidth agreement.
|
|
CreateAgreement(context.Context, Agreement) error
|
|
// GetAgreements gets all bandwidth agreements.
|
|
GetAgreements(context.Context) ([]Agreement, error)
|
|
// GetAgreementsSince gets all bandwidth agreements since specific time.
|
|
GetAgreementsSince(context.Context, time.Time) ([]Agreement, error)
|
|
}
|
|
|
|
// Server is an implementation of the pb.BandwidthServer interface
|
|
type Server struct {
|
|
db DB
|
|
pkey crypto.PublicKey
|
|
logger *zap.Logger
|
|
}
|
|
|
|
// Agreement is a struct that contains a bandwidth agreement and the associated signature
|
|
type Agreement struct {
|
|
Agreement []byte
|
|
Signature []byte
|
|
CreatedAt time.Time
|
|
}
|
|
|
|
// NewServer creates instance of Server
|
|
func NewServer(db DB, logger *zap.Logger, pkey crypto.PublicKey) *Server {
|
|
return &Server{
|
|
db: db,
|
|
logger: logger,
|
|
pkey: pkey,
|
|
}
|
|
}
|
|
|
|
// BandwidthAgreements receives and stores bandwidth agreements from storage nodes
|
|
func (s *Server) BandwidthAgreements(ctx context.Context, req *pb.RenterBandwidthAllocation) (reply *pb.AgreementsSummary, err error) {
|
|
defer mon.Task()(&ctx)(&err)
|
|
|
|
s.logger.Debug("Received Agreement...")
|
|
|
|
reply = &pb.AgreementsSummary{
|
|
Status: pb.AgreementsSummary_FAIL,
|
|
}
|
|
|
|
if err = s.verifySignature(ctx, req); err != nil {
|
|
return reply, err
|
|
}
|
|
|
|
err = s.db.CreateAgreement(ctx, Agreement{
|
|
Signature: req.GetSignature(),
|
|
Agreement: req.GetData(),
|
|
})
|
|
|
|
if err != nil {
|
|
return reply, err
|
|
}
|
|
|
|
reply.Status = pb.AgreementsSummary_OK
|
|
|
|
s.logger.Debug("Stored Agreement...")
|
|
|
|
return reply, nil
|
|
}
|
|
|
|
func (s *Server) verifySignature(ctx context.Context, ba *pb.RenterBandwidthAllocation) error {
|
|
// TODO(security): detect replay attacks
|
|
|
|
//Deserealize RenterBandwidthAllocation.GetData() so we can get public key
|
|
rbad := &pb.RenterBandwidthAllocation_Data{}
|
|
if err := proto.Unmarshal(ba.GetData(), rbad); err != nil {
|
|
return BwAgreementError.New("Failed to unmarshal RenterBandwidthAllocation: %+v", err)
|
|
}
|
|
|
|
pba := rbad.GetPayerAllocation()
|
|
pbad := &pb.PayerBandwidthAllocation_Data{}
|
|
if err := proto.Unmarshal(pba.GetData(), pbad); err != nil {
|
|
return BwAgreementError.New("Failed to unmarshal PayerBandwidthAllocation: %+v", err)
|
|
}
|
|
// Extract renter's public key from PayerBandwidthAllocation_Data
|
|
pubkey, err := x509.ParsePKIXPublicKey(pbad.GetPubKey())
|
|
if err != nil {
|
|
return BwAgreementError.New("Failed to extract Public Key from RenterBandwidthAllocation: %+v", err)
|
|
}
|
|
|
|
// Typecast public key
|
|
k, ok := pubkey.(*ecdsa.PublicKey)
|
|
if !ok {
|
|
return peertls.ErrUnsupportedKey.New("%T", pubkey)
|
|
}
|
|
|
|
// verify Renter's (uplink) signature
|
|
if ok := cryptopasta.Verify(ba.GetData(), ba.GetSignature(), k); !ok {
|
|
return BwAgreementError.New("Failed to verify Renter's Signature")
|
|
}
|
|
|
|
k, ok = s.pkey.(*ecdsa.PublicKey)
|
|
if !ok {
|
|
return peertls.ErrUnsupportedKey.New("%T", s.pkey)
|
|
}
|
|
|
|
// verify Payer's (satellite) signature
|
|
if ok := cryptopasta.Verify(rbad.GetPayerAllocation().GetData(), rbad.GetPayerAllocation().GetSignature(), k); !ok {
|
|
return BwAgreementError.New("Failed to verify Payer's Signature")
|
|
}
|
|
return nil
|
|
}
|