storj/satellite/overlay
paul cannon 07bbe7d340 satellite/overlay: don't insert new nodes if contact check failed
Currently, the satellite tracks connectivity information about all nodes
that have contacted it, even if we have never successfully contacted
the node back.

This behavior was leveraged during a security audit to create hundreds
of thousands of "junk nodes" in the nodes table on one satellite, which
affected performance of queries such as node selection.

With this change, we should no longer track information about nodes that
have never been successfully contacted.

Note that it will still be possible to cause the creation of "junk
node" entries in the db; the attacker just has to set up individual
publicly-routable IP+port pairs for each node as it is created, so it
can respond to a PingBack.

Change-Id: Ibb6da6cc908fd4fc85aae1ba00313ba2738409ab
2022-08-26 09:05:04 +00:00
..
straynodes satellite/overlay/straynodes: prevent disqualification in tests 2021-11-09 12:29:21 +00:00
benchmark_test.go satellite/overlay: use ReadCache in Download/UploadSelectionCache 2022-07-12 13:52:48 +03:00
checkin_test.go mod: bump common to fetch latest placement type changes 2021-11-16 12:42:25 +00:00
config.go satellite/{overlay,satellitedb}: add AS OF to download selection 2022-06-28 05:18:01 +00:00
db_test.go satellite/overlay: add disqualification reason 2022-04-20 13:29:31 +00:00
downloadselection_test.go satellite/{orders,overlay}: use cache for downloads 2022-07-12 11:04:34 +00:00
downloadselection.go satellite/{orders,overlay}: use cache for downloads 2022-07-12 11:04:34 +00:00
peeridentities_test.go satellite/satellitedb/satellitedbtest: pass ctx as an argument 2020-01-20 16:35:42 +02:00
peeridentities.go all: golangci-lint v1.33.0 fixes (#3985) 2020-12-05 17:01:42 +01:00
piececount_test.go ci: test benchmarks 2020-07-10 13:26:49 +00:00
selection_test.go satellite/reputation: reconfigure lambda and alpha 2022-08-17 18:52:53 +00:00
service_test.go satellite/overlay: use ReadCache in Download/UploadSelectionCache 2022-07-12 13:52:48 +03:00
service.go satellite/overlay: don't insert new nodes if contact check failed 2022-08-26 09:05:04 +00:00
statdb_test.go satellite/overlay: add disqualification reason 2022-04-20 13:29:31 +00:00
uploadselection_test.go satellite/overlay: use ReadCache in Download/UploadSelectionCache 2022-07-12 13:52:48 +03:00
uploadselection.go satellite/overlay: use ReadCache in Download/UploadSelectionCache 2022-07-12 13:52:48 +03:00