da9ca0c650
Satellites set their configuration values to default values using cfgstruct, however, it turns out our tests don't test these values at all! Instead, they have a completely separate definition system that is easy to forget about. As is to be expected, these values have drifted, and it appears in a few cases test planet is testing unreasonable values that we won't see in production, or perhaps worse, features enabled in production were missed and weren't enabled in testplanet. This change makes it so all values are configured the same, systematic way, so it's easy to see when test values are different than dev values or release values, and it's less hard to forget to enable features in testplanet. In terms of reviewing, this change should be actually fairly easy to review, considering private/testplanet/satellite.go keeps the current config system and the new one and confirms that they result in identical configurations, so you can be certain that nothing was missed and the config is all correct. You can also check the config lock to see what actual config values changed. Change-Id: I6715d0794887f577e21742afcf56fd2b9d12170e
93 lines
2.4 KiB
Go
93 lines
2.4 KiB
Go
// Copyright (C) 2020 Storj Labs, Inc.
|
|
// See LICENSE for copying information.
|
|
|
|
package expireddeletion
|
|
|
|
import (
|
|
"context"
|
|
"time"
|
|
|
|
"github.com/spacemonkeygo/monkit/v3"
|
|
"github.com/zeebo/errs"
|
|
"go.uber.org/zap"
|
|
|
|
"storj.io/common/sync2"
|
|
"storj.io/storj/satellite/metabase"
|
|
)
|
|
|
|
var (
|
|
// Error defines the expireddeletion chore errors class.
|
|
Error = errs.Class("expired deletion")
|
|
mon = monkit.Package()
|
|
)
|
|
|
|
// Config contains configurable values for expired segment cleanup.
|
|
type Config struct {
|
|
Interval time.Duration `help:"the time between each attempt to go through the db and clean up expired segments" releaseDefault:"24h" devDefault:"10s" testDefault:"$TESTINTERVAL"`
|
|
Enabled bool `help:"set if expired segment cleanup is enabled or not" releaseDefault:"true" devDefault:"true"`
|
|
ListLimit int `help:"how many expired objects to query in a batch" default:"100"`
|
|
}
|
|
|
|
// Chore implements the expired segment cleanup chore.
|
|
//
|
|
// architecture: Chore
|
|
type Chore struct {
|
|
log *zap.Logger
|
|
config Config
|
|
metabase *metabase.DB
|
|
|
|
nowFn func() time.Time
|
|
Loop *sync2.Cycle
|
|
}
|
|
|
|
// NewChore creates a new instance of the expireddeletion chore.
|
|
func NewChore(log *zap.Logger, config Config, metabase *metabase.DB) *Chore {
|
|
return &Chore{
|
|
log: log,
|
|
config: config,
|
|
metabase: metabase,
|
|
|
|
nowFn: time.Now,
|
|
Loop: sync2.NewCycle(config.Interval),
|
|
}
|
|
}
|
|
|
|
// Run starts the expireddeletion loop service.
|
|
func (chore *Chore) Run(ctx context.Context) (err error) {
|
|
defer mon.Task()(&ctx)(&err)
|
|
|
|
if !chore.config.Enabled {
|
|
return nil
|
|
}
|
|
|
|
return chore.Loop.Run(ctx, chore.deleteExpiredObjects)
|
|
}
|
|
|
|
// Close stops the expireddeletion chore.
|
|
func (chore *Chore) Close() error {
|
|
chore.Loop.Close()
|
|
return nil
|
|
}
|
|
|
|
// SetNow allows tests to have the server act as if the current time is whatever they want.
|
|
func (chore *Chore) SetNow(nowFn func() time.Time) {
|
|
chore.nowFn = nowFn
|
|
}
|
|
|
|
func (chore *Chore) deleteExpiredObjects(ctx context.Context) (err error) {
|
|
defer mon.Task()(&ctx)(&err)
|
|
chore.log.Debug("deleting expired objects")
|
|
|
|
// TODO log error instead of crashing core until we will be sure
|
|
// that queries for deleting expired objects are stable
|
|
err = chore.metabase.DeleteExpiredObjects(ctx, metabase.DeleteExpiredObjects{
|
|
ExpiredBefore: chore.nowFn(),
|
|
BatchSize: chore.config.ListLimit,
|
|
})
|
|
if err != nil {
|
|
chore.log.Error("deleting expired objects failed", zap.Error(err))
|
|
}
|
|
|
|
return nil
|
|
}
|