JakeHillion/storj
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
5abed63f53
storj/satellite
History
Márton Elek 9ddc8b4ca3 satellite/repair: piecescheck.OutOfPlacementPiecesSet should not contain offline nodes 
When we check the availability of the pieces, we do:

```
result.NumUnhealthyRetrievable = len(result.ClumpedPiecesSet) + len(result.OutOfPlacementPiecesSet)
// + some magic if there are overlaps between them
numHealthy := len(pieces) - len(piecesCheck.MissingPiecesSet) - piecesCheck.NumUnhealthyRetrievable
```

This works only if OutOfPlacementPieceSet doesn't contain the offline nodes (which are already included in MissingPieceSet).

But `result.OutOfPlacementPieces.Set` should include all the nodes (even offline), as in case of lucky conditions, we are able to remove those pieces from DB.

The solution is to remove all offline nodes from `NumUnhealthyRetrievable`.

Change-Id: I90baa0396352dd040e1e1516314b3271f8712034
2023-08-16 17:35:10 +00:00
..
abtesting console/abTesting: add support for AB testing 2022-10-27 10:57:12 +00:00
accounting satellite/accounting/live: ensure we don't panic when we get nil 2023-08-10 19:41:57 +03:00
admin all: fix golangci failures 2023-08-09 11:44:44 +03:00
analytics satellite/payments: Exclude users who pay via storjscan from autofreeze 2023-07-10 13:39:01 +00:00
attribution satellite/{db, admin}: added endpoints to update user's and project's user_agent 2023-06-16 19:41:05 +00:00
audit satellite/metainfo: remove ServerSideCopyDuplicateMetadata 2023-08-08 12:15:10 +00:00
buckets satellite/accounting/tally: handle well bucket names with escape char 2023-06-21 15:04:14 +00:00
compensation payments: don't redefine compensation rates twice 2023-06-10 12:40:43 +00:00
console satellite/console: Enable gallery view and limits area by default (#6177) 2023-08-14 17:05:19 +02:00
contact go.mod: bump lang to 1.19 and common 2023-08-10 18:41:15 +03:00
gc satellite/metainfo: remove ServerSideCopyDuplicateMetadata 2023-08-08 12:15:10 +00:00
geoip satellite/geoip: exclude nodes with represented_contry from geofencing 2023-08-14 12:36:33 +00:00
gracefulexit satellite/metainfo: remove ServerSideCopyDuplicateMetadata 2023-08-08 12:15:10 +00:00
internalpb satellite/metabase: adjust BeginObjectNextVersion to use pending_objects 2023-08-02 14:42:26 +00:00
mailservice satellite/consoleweb: fix flaky TestAuth tests 2022-08-04 19:06:07 +00:00
metabase all: fix golangci failures 2023-08-09 11:44:44 +03:00
metainfo satellite/{repair,rangedloop,overlay}: fix node tag placement selection for repair 2023-08-16 15:45:41 +00:00
metrics satellite/metabase/rangedloop: move Segment definition 2023-05-16 12:37:17 +00:00
nodeapiversion satellite/nodeapiversion: new table for tracking node api usage 2020-07-09 15:02:25 +00:00
nodeevents satellite/satellitedb/dbx: document node tables 2023-02-24 14:05:55 +00:00
nodeselection satellite/~placement: do not ignore placement check for placement=0 2023-08-16 07:06:56 +00:00
nodestats payments: don't redefine compensation rates twice 2023-06-10 12:40:43 +00:00
oidc satellite: add get user paged projects http endpoint 2023-08-08 14:02:53 +00:00
orders satellite/~placement: do not ignore placement check for placement=0 2023-08-16 07:06:56 +00:00
overlay satellite/~placement: do not ignore placement check for placement=0 2023-08-16 07:06:56 +00:00
payments satellite/{db,console,payments}: unfreeze user with no failed invoices 2023-08-01 17:54:39 +00:00
repair satellite/repair: piecescheck.OutOfPlacementPiecesSet should not contain offline nodes 2023-08-16 17:35:10 +00:00
reputation satellite/audit: remove pieces when audits fail 2023-06-22 14:19:00 +00:00
revocation satellite/satellitedb: move tests to their domains 2021-02-19 17:29:15 +02:00
satellitedb satellite/{repair,rangedloop,overlay}: fix node tag placement selection for repair 2023-08-16 15:45:41 +00:00
snopayouts all: fix error naming 2021-04-29 15:38:21 +03:00
admin.go satellite/payments: Remove expired package credits 2023-05-22 11:58:37 +00:00
api_test.go satellite/api: configuration option to set additional node tag authorities 2023-08-03 08:34:02 +00:00
api.go satellite/api: configuration option to set additional node tag authorities 2023-08-03 08:34:02 +00:00
auditor.go satellite: switch to use nodefilters instead of old placement.AllowedCountry 2023-07-07 16:55:45 +00:00
configlock_test.go all: fix deprecated ioutil commands 2022-10-11 15:27:29 +00:00
core.go satellite/payments: slightly refactor user upgrade observer of billing chore 2023-07-21 03:43:42 +00:00
gc-bf_test.go satellite/gc/bloomfilter: remove segments loop parts 2023-05-15 11:46:26 +00:00
gc-bf.go satellite/metabase: remove segmentsloop package 2023-05-18 19:08:29 +00:00
gc.go gc: remove segment loop dependency 2023-02-03 10:31:16 +00:00
peer.go satellite/api: configuration option to set additional node tag authorities 2023-08-03 08:34:02 +00:00
rangedloop.go satellite/repair/repairer: fix NumHealthyInExcludedCountries calculation 2023-07-10 12:01:19 +02:00
repairer.go satellite/repair/repairer: fix NumHealthyInExcludedCountries calculation 2023-07-10 12:01:19 +02:00
ui.go satellite/console: optional separate web app server 2023-07-11 12:17:35 -04:00