5b79970575
If project.UserAgent is set, use this for bucket.UserAgent on bucket creation. Otherwise, set bucket attribution as before (getting UserAgent from request headers). Tests were updated to create the bucket with a different user, added as a project member. Otherwise, the tests do not catch the bug. Change-Id: I7ecf79a8eac5957eed361cbea94823190f58b776
214 lines
6.9 KiB
Go
214 lines
6.9 KiB
Go
// Copyright (C) 2019 Storj Labs, Inc.
|
|
// See LICENSE for copying information.
|
|
|
|
package metainfo
|
|
|
|
import (
|
|
"context"
|
|
"sync"
|
|
|
|
"go.uber.org/zap"
|
|
|
|
"storj.io/common/errs2"
|
|
"storj.io/common/pb"
|
|
"storj.io/common/rpc/rpcstatus"
|
|
"storj.io/common/storj"
|
|
"storj.io/common/useragent"
|
|
"storj.io/common/uuid"
|
|
"storj.io/drpc/drpccache"
|
|
"storj.io/storj/satellite/attribution"
|
|
"storj.io/storj/satellite/console"
|
|
)
|
|
|
|
// MaxUserAgentLength is the maximum allowable length of the User Agent.
|
|
const MaxUserAgentLength = 500
|
|
|
|
// ensureAttribution ensures that the bucketName has the partner information specified by project-level user agent, header user agent, or keyInfo partner ID.
|
|
// PartnerID from keyInfo is a value associated with registered user and prevails over header user agent.
|
|
//
|
|
// Assumes that the user has permissions sufficient for authenticating.
|
|
func (endpoint *Endpoint) ensureAttribution(ctx context.Context, header *pb.RequestHeader, keyInfo *console.APIKeyInfo, bucketName, projectUserAgent []byte) (err error) {
|
|
defer mon.Task()(&ctx)(&err)
|
|
|
|
if header == nil {
|
|
return rpcstatus.Error(rpcstatus.InvalidArgument, "header is nil")
|
|
}
|
|
if keyInfo.PartnerID.IsZero() && len(header.UserAgent) == 0 && len(keyInfo.UserAgent) == 0 && len(projectUserAgent) == 0 {
|
|
return nil
|
|
}
|
|
|
|
if conncache := drpccache.FromContext(ctx); conncache != nil {
|
|
cache := conncache.LoadOrCreate(attributionCheckCacheKey{},
|
|
func() interface{} {
|
|
return &attributionCheckCache{}
|
|
}).(*attributionCheckCache)
|
|
if !cache.needsCheck(string(bucketName)) {
|
|
return nil
|
|
}
|
|
}
|
|
|
|
partnerID := keyInfo.PartnerID
|
|
userAgent := keyInfo.UserAgent
|
|
if len(projectUserAgent) > 0 {
|
|
userAgent = projectUserAgent
|
|
}
|
|
|
|
// first check keyInfo (user) attribution
|
|
if partnerID.IsZero() && userAgent == nil {
|
|
// otherwise, use header (partner tool) as attribution
|
|
userAgent = header.UserAgent
|
|
}
|
|
|
|
userAgent, err = TrimUserAgent(userAgent)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
err = endpoint.tryUpdateBucketAttribution(ctx, header, keyInfo.ProjectID, bucketName, partnerID, userAgent)
|
|
if errs2.IsRPC(err, rpcstatus.NotFound) || errs2.IsRPC(err, rpcstatus.AlreadyExists) {
|
|
return nil
|
|
}
|
|
return err
|
|
}
|
|
|
|
// TrimUserAgent returns userAgentBytes that consist of only the product portion of the user agent, and is bounded by
|
|
// the maxUserAgentLength.
|
|
func TrimUserAgent(userAgent []byte) ([]byte, error) {
|
|
if len(userAgent) == 0 {
|
|
return userAgent, nil
|
|
}
|
|
userAgentEntries, err := useragent.ParseEntries(userAgent)
|
|
if err != nil {
|
|
return userAgent, Error.New("error while parsing user agent: %w", err)
|
|
}
|
|
// strip comments, libraries, and empty products from the user agent
|
|
newEntries := userAgentEntries[:0]
|
|
for _, e := range userAgentEntries {
|
|
switch product := e.Product; product {
|
|
case "uplink", "common", "drpc", "Gateway-ST", "":
|
|
default:
|
|
e.Comment = ""
|
|
newEntries = append(newEntries, e)
|
|
}
|
|
}
|
|
userAgent, err = useragent.EncodeEntries(newEntries)
|
|
if err != nil {
|
|
return userAgent, Error.New("error while encoding user agent entries: %w", err)
|
|
}
|
|
|
|
// bound the user agent length
|
|
if len(userAgent) > MaxUserAgentLength && len(newEntries) > 0 {
|
|
// try to preserve the first entry
|
|
if (len(newEntries[0].Product) + len(newEntries[0].Version)) <= MaxUserAgentLength {
|
|
userAgent, err = useragent.EncodeEntries(newEntries[:1])
|
|
if err != nil {
|
|
return userAgent, Error.New("error while encoding first user agent entry: %w", err)
|
|
}
|
|
} else {
|
|
// first entry is too large, truncate
|
|
userAgent = userAgent[:MaxUserAgentLength]
|
|
}
|
|
}
|
|
return userAgent, nil
|
|
}
|
|
|
|
func (endpoint *Endpoint) tryUpdateBucketAttribution(ctx context.Context, header *pb.RequestHeader, projectID uuid.UUID, bucketName []byte, partnerID uuid.UUID, userAgent []byte) (err error) {
|
|
defer mon.Task()(&ctx)(&err)
|
|
|
|
if header == nil {
|
|
return rpcstatus.Error(rpcstatus.InvalidArgument, "header is nil")
|
|
}
|
|
|
|
// check if attribution is set for given bucket
|
|
_, err = endpoint.attributions.Get(ctx, projectID, bucketName)
|
|
if err == nil {
|
|
// bucket has already an attribution, no need to update
|
|
return nil
|
|
}
|
|
if !attribution.ErrBucketNotAttributed.Has(err) {
|
|
// try only to set the attribution, when it's missing
|
|
endpoint.log.Error("error while getting attribution from DB", zap.Error(err))
|
|
return rpcstatus.Error(rpcstatus.Internal, err.Error())
|
|
}
|
|
|
|
empty, err := endpoint.isBucketEmpty(ctx, projectID, bucketName)
|
|
if err != nil {
|
|
endpoint.log.Error("internal", zap.Error(err))
|
|
return rpcstatus.Error(rpcstatus.Internal, Error.Wrap(err).Error())
|
|
}
|
|
if !empty {
|
|
return rpcstatus.Errorf(rpcstatus.AlreadyExists, "bucket %q is not empty, PartnerID %q cannot be attributed", bucketName, partnerID)
|
|
}
|
|
|
|
// checks if bucket exists before updates it or makes a new entry
|
|
bucket, err := endpoint.buckets.GetBucket(ctx, bucketName, projectID)
|
|
if err != nil {
|
|
if storj.ErrBucketNotFound.Has(err) {
|
|
return rpcstatus.Errorf(rpcstatus.NotFound, "bucket %q does not exist", bucketName)
|
|
}
|
|
endpoint.log.Error("error while getting bucket", zap.ByteString("bucketName", bucketName), zap.Error(err))
|
|
return rpcstatus.Error(rpcstatus.Internal, "unable to set bucket attribution")
|
|
}
|
|
if !bucket.PartnerID.IsZero() || bucket.UserAgent != nil {
|
|
return rpcstatus.Errorf(rpcstatus.AlreadyExists, "bucket %q already has attribution, PartnerID %q cannot be attributed", bucketName, partnerID)
|
|
}
|
|
|
|
// update bucket information
|
|
bucket.PartnerID = partnerID
|
|
bucket.UserAgent = userAgent
|
|
_, err = endpoint.buckets.UpdateBucket(ctx, bucket)
|
|
if err != nil {
|
|
endpoint.log.Error("error while updating bucket", zap.ByteString("bucketName", bucketName), zap.Error(err))
|
|
return rpcstatus.Error(rpcstatus.Internal, "unable to set bucket attribution")
|
|
}
|
|
|
|
// update attribution table
|
|
_, err = endpoint.attributions.Insert(ctx, &attribution.Info{
|
|
ProjectID: projectID,
|
|
BucketName: bucketName,
|
|
PartnerID: partnerID,
|
|
UserAgent: userAgent,
|
|
})
|
|
if err != nil {
|
|
endpoint.log.Error("error while inserting attribution to DB", zap.Error(err))
|
|
return rpcstatus.Error(rpcstatus.Internal, err.Error())
|
|
}
|
|
|
|
return nil
|
|
}
|
|
|
|
// maxAttributionCacheSize determines how many buckets attributionCheckCache remembers.
|
|
const maxAttributionCacheSize = 10
|
|
|
|
// attributionCheckCacheKey is used as a key for the connection cache.
|
|
type attributionCheckCacheKey struct{}
|
|
|
|
// attributionCheckCache implements a basic lru cache, with a constant size.
|
|
type attributionCheckCache struct {
|
|
mu sync.Mutex
|
|
pos int
|
|
buckets []string
|
|
}
|
|
|
|
// needsCheck returns true when the bucket should be tested for setting the useragent.
|
|
func (cache *attributionCheckCache) needsCheck(bucket string) bool {
|
|
cache.mu.Lock()
|
|
defer cache.mu.Unlock()
|
|
|
|
for _, b := range cache.buckets {
|
|
if b == bucket {
|
|
return false
|
|
}
|
|
}
|
|
|
|
if len(cache.buckets) >= maxAttributionCacheSize {
|
|
cache.pos = (cache.pos + 1) % len(cache.buckets)
|
|
cache.buckets[cache.pos] = bucket
|
|
} else {
|
|
cache.pos = len(cache.buckets)
|
|
cache.buckets = append(cache.buckets, bucket)
|
|
}
|
|
|
|
return true
|
|
}
|