369 lines
11 KiB
Go
369 lines
11 KiB
Go
// Copyright (C) 2020 Storj Labs, Inc.
|
|
// See LICENSE for copying information.
|
|
|
|
package metainfo_test
|
|
|
|
import (
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
"github.com/stretchr/testify/require"
|
|
"go.uber.org/zap/zaptest"
|
|
|
|
"storj.io/common/memory"
|
|
"storj.io/common/rpc"
|
|
"storj.io/common/storj"
|
|
"storj.io/common/testcontext"
|
|
"storj.io/common/testrand"
|
|
"storj.io/storj/cmd/uplink/cmd"
|
|
"storj.io/storj/private/testplanet"
|
|
"storj.io/storj/satellite/metainfo"
|
|
"storj.io/storj/storagenode/pieces"
|
|
)
|
|
|
|
func TestDeletePiecesService_New_Error(t *testing.T) {
|
|
log := zaptest.NewLogger(t)
|
|
dialer := rpc.NewDefaultDialer(nil)
|
|
|
|
_, err := metainfo.NewDeletePiecesService(nil, dialer, 8)
|
|
require.True(t, metainfo.ErrDeletePieces.Has(err), err)
|
|
require.Contains(t, err.Error(), "logger cannot be nil")
|
|
|
|
_, err = metainfo.NewDeletePiecesService(log, rpc.Dialer{}, 87)
|
|
require.True(t, metainfo.ErrDeletePieces.Has(err), err)
|
|
require.Contains(t, err.Error(), "dialer cannot be its zero value")
|
|
|
|
_, err = metainfo.NewDeletePiecesService(log, dialer, 0)
|
|
require.True(t, metainfo.ErrDeletePieces.Has(err), err)
|
|
require.Contains(t, err.Error(), "greater than 0")
|
|
|
|
_, err = metainfo.NewDeletePiecesService(log, dialer, -3)
|
|
require.True(t, metainfo.ErrDeletePieces.Has(err), err)
|
|
require.Contains(t, err.Error(), "greater than 0")
|
|
}
|
|
|
|
func TestDeletePiecesService_DeletePieces_AllNodesUp(t *testing.T) {
|
|
testplanet.Run(t, testplanet.Config{
|
|
SatelliteCount: 1, StorageNodeCount: 4, UplinkCount: 1,
|
|
}, func(t *testing.T, ctx *testcontext.Context, planet *testplanet.Planet) {
|
|
uplnk := planet.Uplinks[0]
|
|
satelliteSys := planet.Satellites[0]
|
|
|
|
{
|
|
data := testrand.Bytes(10 * memory.KiB)
|
|
// Use RSConfig for ensuring that we don't have long-tail cancellations
|
|
// and the upload doesn't leave garbage in the SNs
|
|
err := uplnk.UploadWithClientConfig(ctx, satelliteSys, cmd.Config{
|
|
Client: cmd.ClientConfig{
|
|
SegmentSize: 10 * memory.KiB,
|
|
},
|
|
RS: cmd.RSConfig{
|
|
MinThreshold: 2,
|
|
RepairThreshold: 2,
|
|
SuccessThreshold: 4,
|
|
MaxThreshold: 4,
|
|
},
|
|
},
|
|
"a-bucket", "object-filename", data,
|
|
)
|
|
require.NoError(t, err)
|
|
}
|
|
|
|
var (
|
|
totalUsedSpace int64
|
|
nodesPieces metainfo.NodesPieces
|
|
)
|
|
for _, sn := range planet.StorageNodes {
|
|
// calculate the SNs total used space after data upload
|
|
piecesTotal, _, err := sn.Storage2.Store.SpaceUsedForPieces(ctx)
|
|
require.NoError(t, err)
|
|
totalUsedSpace += piecesTotal
|
|
|
|
// Get pb node and all the pieces of the storage node
|
|
dossier, err := satelliteSys.Overlay.Service.Get(ctx, sn.ID())
|
|
require.NoError(t, err)
|
|
|
|
nodePieces := metainfo.NodePieces{
|
|
Node: &dossier.Node,
|
|
}
|
|
|
|
err = sn.Storage2.Store.WalkSatellitePieces(ctx, satelliteSys.ID(),
|
|
func(store pieces.StoredPieceAccess) error {
|
|
nodePieces.Pieces = append(nodePieces.Pieces, store.PieceID())
|
|
return nil
|
|
},
|
|
)
|
|
require.NoError(t, err)
|
|
|
|
nodesPieces = append(nodesPieces, nodePieces)
|
|
}
|
|
|
|
err := satelliteSys.API.Metainfo.DeletePiecesService.DeletePieces(ctx, nodesPieces, 0.75)
|
|
require.NoError(t, err)
|
|
|
|
// calculate the SNs used space after delete the pieces
|
|
var totalUsedSpaceAfterDelete int64
|
|
for _, sn := range planet.StorageNodes {
|
|
piecesTotal, _, err := sn.Storage2.Store.SpaceUsedForPieces(ctx)
|
|
require.NoError(t, err)
|
|
totalUsedSpaceAfterDelete += piecesTotal
|
|
}
|
|
|
|
// At this point we can only guarantee that the 75% of the SNs pieces
|
|
// are delete due to the success threshold
|
|
deletedUsedSpace := float64(totalUsedSpace-totalUsedSpaceAfterDelete) / float64(totalUsedSpace)
|
|
if deletedUsedSpace < 0.75 {
|
|
t.Fatalf("deleted used space is less than 0.75%%. Got %f", deletedUsedSpace)
|
|
}
|
|
})
|
|
}
|
|
|
|
func TestDeletePiecesService_DeletePieces_SomeNodesDown(t *testing.T) {
|
|
testplanet.Run(t, testplanet.Config{
|
|
SatelliteCount: 1, StorageNodeCount: 4, UplinkCount: 1,
|
|
}, func(t *testing.T, ctx *testcontext.Context, planet *testplanet.Planet) {
|
|
uplnk := planet.Uplinks[0]
|
|
satelliteSys := planet.Satellites[0]
|
|
|
|
{
|
|
data := testrand.Bytes(10 * memory.KiB)
|
|
// Use RSConfig for ensuring that we don't have long-tail cancellations
|
|
// and the upload doesn't leave garbage in the SNs
|
|
err := uplnk.UploadWithClientConfig(ctx, satelliteSys, cmd.Config{
|
|
Client: cmd.ClientConfig{
|
|
SegmentSize: 10 * memory.KiB,
|
|
},
|
|
RS: cmd.RSConfig{
|
|
MinThreshold: 2,
|
|
RepairThreshold: 2,
|
|
SuccessThreshold: 4,
|
|
MaxThreshold: 4,
|
|
},
|
|
},
|
|
"a-bucket", "object-filename", data,
|
|
)
|
|
require.NoError(t, err)
|
|
}
|
|
|
|
var nodesPieces metainfo.NodesPieces
|
|
for i, sn := range planet.StorageNodes {
|
|
// Get pb node and all the pieces of the storage node
|
|
dossier, err := satelliteSys.Overlay.Service.Get(ctx, sn.ID())
|
|
require.NoError(t, err)
|
|
|
|
nodePieces := metainfo.NodePieces{
|
|
Node: &dossier.Node,
|
|
}
|
|
|
|
err = sn.Storage2.Store.WalkSatellitePieces(ctx, satelliteSys.ID(),
|
|
func(store pieces.StoredPieceAccess) error {
|
|
nodePieces.Pieces = append(nodePieces.Pieces, store.PieceID())
|
|
return nil
|
|
},
|
|
)
|
|
require.NoError(t, err)
|
|
|
|
nodesPieces = append(nodesPieces, nodePieces)
|
|
|
|
// stop the first 2 SNs before deleting pieces
|
|
if i < 2 {
|
|
require.NoError(t, planet.StopPeer(sn))
|
|
}
|
|
}
|
|
|
|
err := satelliteSys.API.Metainfo.DeletePiecesService.DeletePieces(ctx, nodesPieces, 0.9999)
|
|
require.NoError(t, err)
|
|
|
|
// Check that storage nodes which are online when deleting pieces don't
|
|
// hold any piece
|
|
var totalUsedSpace int64
|
|
for i := 2; i < len(planet.StorageNodes); i++ {
|
|
piecesTotal, _, err := planet.StorageNodes[i].Storage2.Store.SpaceUsedForPieces(ctx)
|
|
require.NoError(t, err)
|
|
totalUsedSpace += piecesTotal
|
|
}
|
|
|
|
require.Zero(t, totalUsedSpace, "totalUsedSpace online nodes")
|
|
})
|
|
}
|
|
|
|
func TestDeletePiecesService_DeletePieces_AllNodesDown(t *testing.T) {
|
|
testplanet.Run(t, testplanet.Config{
|
|
SatelliteCount: 1, StorageNodeCount: 4, UplinkCount: 1,
|
|
}, func(t *testing.T, ctx *testcontext.Context, planet *testplanet.Planet) {
|
|
uplnk := planet.Uplinks[0]
|
|
satelliteSys := planet.Satellites[0]
|
|
|
|
{
|
|
data := testrand.Bytes(10 * memory.KiB)
|
|
// Use RSConfig for ensuring that we don't have long-tail cancellations
|
|
// and the upload doesn't leave garbage in the SNs
|
|
err := uplnk.UploadWithClientConfig(ctx, satelliteSys, cmd.Config{
|
|
Client: cmd.ClientConfig{
|
|
SegmentSize: 10 * memory.KiB,
|
|
},
|
|
RS: cmd.RSConfig{
|
|
MinThreshold: 2,
|
|
RepairThreshold: 2,
|
|
SuccessThreshold: 4,
|
|
MaxThreshold: 4,
|
|
},
|
|
},
|
|
"a-bucket", "object-filename", data,
|
|
)
|
|
require.NoError(t, err)
|
|
}
|
|
|
|
var (
|
|
expectedTotalUsedSpace int64
|
|
nodesPieces metainfo.NodesPieces
|
|
)
|
|
for _, sn := range planet.StorageNodes {
|
|
// calculate the SNs total used space after data upload
|
|
piecesTotal, _, err := sn.Storage2.Store.SpaceUsedForPieces(ctx)
|
|
require.NoError(t, err)
|
|
expectedTotalUsedSpace += piecesTotal
|
|
|
|
// Get pb node and all the pieces of the storage node
|
|
dossier, err := satelliteSys.Overlay.Service.Get(ctx, sn.ID())
|
|
require.NoError(t, err)
|
|
|
|
nodePieces := metainfo.NodePieces{
|
|
Node: &dossier.Node,
|
|
}
|
|
|
|
err = sn.Storage2.Store.WalkSatellitePieces(ctx, satelliteSys.ID(),
|
|
func(store pieces.StoredPieceAccess) error {
|
|
nodePieces.Pieces = append(nodePieces.Pieces, store.PieceID())
|
|
return nil
|
|
},
|
|
)
|
|
require.NoError(t, err)
|
|
|
|
nodesPieces = append(nodesPieces, nodePieces)
|
|
require.NoError(t, planet.StopPeer(sn))
|
|
}
|
|
|
|
err := satelliteSys.API.Metainfo.DeletePiecesService.DeletePieces(ctx, nodesPieces, 0.9999)
|
|
require.NoError(t, err)
|
|
|
|
var totalUsedSpace int64
|
|
for _, sn := range planet.StorageNodes {
|
|
// calculate the SNs total used space after data upload
|
|
piecesTotal, _, err := sn.Storage2.Store.SpaceUsedForPieces(ctx)
|
|
require.NoError(t, err)
|
|
totalUsedSpace += piecesTotal
|
|
}
|
|
|
|
require.Equal(t, expectedTotalUsedSpace, totalUsedSpace, "totalUsedSpace")
|
|
})
|
|
}
|
|
|
|
func TestDeletePiecesService_DeletePieces_InvalidDialer(t *testing.T) {
|
|
testplanet.Run(t, testplanet.Config{
|
|
SatelliteCount: 1, StorageNodeCount: 4, UplinkCount: 1,
|
|
}, func(t *testing.T, ctx *testcontext.Context, planet *testplanet.Planet) {
|
|
uplnk := planet.Uplinks[0]
|
|
satelliteSys := planet.Satellites[0]
|
|
|
|
{
|
|
data := testrand.Bytes(10 * memory.KiB)
|
|
// Use RSConfig for ensuring that we don't have long-tail cancellations
|
|
// and the upload doesn't leave garbage in the SNs
|
|
err := uplnk.UploadWithClientConfig(ctx, satelliteSys, cmd.Config{
|
|
Client: cmd.ClientConfig{
|
|
SegmentSize: 10 * memory.KiB,
|
|
},
|
|
RS: cmd.RSConfig{
|
|
MinThreshold: 2,
|
|
RepairThreshold: 2,
|
|
SuccessThreshold: 4,
|
|
MaxThreshold: 4,
|
|
},
|
|
},
|
|
"a-bucket", "object-filename", data,
|
|
)
|
|
require.NoError(t, err)
|
|
}
|
|
|
|
var (
|
|
expectedTotalUsedSpace int64
|
|
nodesPieces metainfo.NodesPieces
|
|
)
|
|
for _, sn := range planet.StorageNodes {
|
|
// calculate the SNs total used space after data upload
|
|
piecesTotal, _, err := sn.Storage2.Store.SpaceUsedForPieces(ctx)
|
|
require.NoError(t, err)
|
|
expectedTotalUsedSpace += piecesTotal
|
|
|
|
// Get pb node and all the pieces of the storage node
|
|
dossier, err := satelliteSys.Overlay.Service.Get(ctx, sn.ID())
|
|
require.NoError(t, err)
|
|
|
|
nodePieces := metainfo.NodePieces{
|
|
Node: &dossier.Node,
|
|
}
|
|
|
|
err = sn.Storage2.Store.WalkSatellitePieces(ctx, satelliteSys.ID(),
|
|
func(store pieces.StoredPieceAccess) error {
|
|
nodePieces.Pieces = append(nodePieces.Pieces, store.PieceID())
|
|
return nil
|
|
},
|
|
)
|
|
require.NoError(t, err)
|
|
|
|
nodesPieces = append(nodesPieces, nodePieces)
|
|
}
|
|
|
|
// The passed dialer cannot dial nodes because it doesn't have TLSOptions
|
|
dialer := satelliteSys.API.Dialer
|
|
dialer.TLSOptions = nil
|
|
service, err := metainfo.NewDeletePiecesService(
|
|
zaptest.NewLogger(t), dialer, len(nodesPieces)-1,
|
|
)
|
|
require.NoError(t, err)
|
|
defer ctx.Check(service.Close)
|
|
|
|
err = service.DeletePieces(ctx, nodesPieces, 0.75)
|
|
require.NoError(t, err)
|
|
|
|
var totalUsedSpaceAfterDelete int64
|
|
for _, sn := range planet.StorageNodes {
|
|
piecesTotal, _, err := sn.Storage2.Store.SpaceUsedForPieces(ctx)
|
|
require.NoError(t, err)
|
|
totalUsedSpaceAfterDelete += piecesTotal
|
|
}
|
|
|
|
// because no node can be dialed the SNs used space should be the same
|
|
require.Equal(t, expectedTotalUsedSpace, totalUsedSpaceAfterDelete)
|
|
})
|
|
}
|
|
|
|
func TestDeletePiecesService_DeletePieces_Invalid(t *testing.T) {
|
|
testplanet.Run(t, testplanet.Config{
|
|
SatelliteCount: 1, StorageNodeCount: 4, UplinkCount: 1,
|
|
}, func(t *testing.T, ctx *testcontext.Context, planet *testplanet.Planet) {
|
|
deletePiecesService := planet.Satellites[0].API.Metainfo.DeletePiecesService
|
|
|
|
t.Run("empty node pieces", func(t *testing.T) {
|
|
t.Parallel()
|
|
err := deletePiecesService.DeletePieces(ctx, metainfo.NodesPieces{}, 0.75)
|
|
require.Error(t, err)
|
|
assert.False(t, metainfo.ErrDeletePieces.Has(err), err)
|
|
assert.Contains(t, err.Error(), "invalid number of tasks")
|
|
})
|
|
|
|
t.Run("invalid threshold", func(t *testing.T) {
|
|
t.Parallel()
|
|
nodesPieces := metainfo.NodesPieces{
|
|
{Pieces: make([]storj.PieceID, 1)},
|
|
{Pieces: make([]storj.PieceID, 1)},
|
|
}
|
|
err := deletePiecesService.DeletePieces(ctx, nodesPieces, 1)
|
|
require.Error(t, err)
|
|
assert.False(t, metainfo.ErrDeletePieces.Has(err), err)
|
|
assert.Contains(t, err.Error(), "invalid successThreshold")
|
|
})
|
|
})
|
|
}
|