b39a99bae6
Previously if a node did not have audit history data for each of the windows over the tracking period, we would give them the benefit of the doubt and set their score to 1. This was to prevent nodes from being suspended right out the gate. We need a minimum amount of data to evaluate them. However, a node who is actually failing at being online will have no idea until they have received enough audits and we suspend them. Instead, we will always use their real score, but use a flag to determine whether they are eligible for suspension/dq. Change-Id: I382218f12e8770f95d4bcddcf101ef348940cadf
84 lines
3.5 KiB
Go
84 lines
3.5 KiB
Go
// Copyright (C) 2020 Storj Labs, Inc.
|
|
// See LICENSE for copying information.
|
|
|
|
package satellitedb_test
|
|
|
|
import (
|
|
"testing"
|
|
"time"
|
|
|
|
"github.com/stretchr/testify/require"
|
|
"go.uber.org/zap"
|
|
|
|
"storj.io/common/testcontext"
|
|
"storj.io/storj/private/testplanet"
|
|
"storj.io/storj/satellite"
|
|
)
|
|
|
|
func TestAuditHistoryBasic(t *testing.T) {
|
|
testplanet.Run(t, testplanet.Config{
|
|
SatelliteCount: 1, StorageNodeCount: 1,
|
|
Reconfigure: testplanet.Reconfigure{
|
|
Satellite: func(log *zap.Logger, index int, config *satellite.Config) {
|
|
config.Overlay.AuditHistory.WindowSize = time.Hour
|
|
config.Overlay.AuditHistory.TrackingPeriod = 2 * time.Hour
|
|
},
|
|
},
|
|
}, func(t *testing.T, ctx *testcontext.Context, planet *testplanet.Planet) {
|
|
node := planet.StorageNodes[0]
|
|
cache := planet.Satellites[0].DB.OverlayCache()
|
|
auditHistoryConfig := planet.Satellites[0].Config.Overlay.AuditHistory
|
|
|
|
startingWindow := time.Now().Truncate(time.Hour)
|
|
windowsInTrackingPeriod := int(auditHistoryConfig.TrackingPeriod.Seconds() / auditHistoryConfig.WindowSize.Seconds())
|
|
currentWindow := startingWindow
|
|
|
|
// online score should be 1 until the first window is finished
|
|
history, err := cache.UpdateAuditHistory(ctx, node.ID(), currentWindow.Add(2*time.Minute), false, auditHistoryConfig)
|
|
require.NoError(t, err)
|
|
require.EqualValues(t, 1, history.GetScore())
|
|
|
|
history, err = cache.UpdateAuditHistory(ctx, node.ID(), currentWindow.Add(20*time.Minute), true, auditHistoryConfig)
|
|
require.NoError(t, err)
|
|
require.EqualValues(t, 1, history.GetScore())
|
|
|
|
// move to next window
|
|
currentWindow = currentWindow.Add(time.Hour)
|
|
|
|
// online score should be now be 0.5 since the first window is complete with one online audit and one offline audit
|
|
history, err = cache.UpdateAuditHistory(ctx, node.ID(), currentWindow.Add(2*time.Minute), false, auditHistoryConfig)
|
|
require.NoError(t, err)
|
|
require.EqualValues(t, 0.5, history.GetScore())
|
|
|
|
history, err = cache.UpdateAuditHistory(ctx, node.ID(), currentWindow.Add(20*time.Minute), true, auditHistoryConfig)
|
|
require.NoError(t, err)
|
|
require.EqualValues(t, 0.5, history.GetScore())
|
|
|
|
// move to next window
|
|
currentWindow = currentWindow.Add(time.Hour)
|
|
|
|
// try to add an audit for an old window, expect error
|
|
_, err = cache.UpdateAuditHistory(ctx, node.ID(), startingWindow, true, auditHistoryConfig)
|
|
require.Error(t, err)
|
|
|
|
// add another online audit for the latest window; score should still be 0.5
|
|
history, err = cache.UpdateAuditHistory(ctx, node.ID(), currentWindow, true, auditHistoryConfig)
|
|
require.NoError(t, err)
|
|
require.EqualValues(t, 0.5, history.GetScore())
|
|
// add another online audit for the latest window; score should still be 0.5
|
|
history, err = cache.UpdateAuditHistory(ctx, node.ID(), currentWindow.Add(45*time.Minute), true, auditHistoryConfig)
|
|
require.NoError(t, err)
|
|
require.EqualValues(t, 0.5, history.GetScore())
|
|
|
|
currentWindow = currentWindow.Add(time.Hour)
|
|
// in the current state, there are windowsInTrackingPeriod windows with a score of 0.5
|
|
// and one window with a score of 1.0. The Math below calculates the new score when the latest
|
|
// window gets included in the tracking period, and the earliest 0.5 window gets dropped.
|
|
expectedScore := (0.5*float64(windowsInTrackingPeriod-1) + 1) / float64(windowsInTrackingPeriod)
|
|
// add online audit for next window; score should now be expectedScore
|
|
history, err = cache.UpdateAuditHistory(ctx, node.ID(), currentWindow.Add(time.Minute), true, auditHistoryConfig)
|
|
require.NoError(t, err)
|
|
require.EqualValues(t, expectedScore, history.GetScore())
|
|
})
|
|
}
|