storj/cmd/uplink
Andrew Harding 5efb08cd7b cmd/uplink: skip abort on committed multipart writes
The copyFile method has some safeguards to ensure that the multipart
write is aborted. This is accomplished by always calling abort on the
MultiWriteHandle when the copy is finished, whether or not there was a
failure or it was successfully committed. If the copy was committed,
then this RPC is a no-op on the metainfo server.

Regardless, the calls to abort to constitute an additional RPC to the
satellite for no benefit. This is exacerbated by the fact that the code
currently ends up calling abort twice.

This change updates the libuplink-backed MultiWriteHandle implementation
to not call abort if the write is committed and vice-versa. This
eliminates the two wasteful RPC calls.

Change-Id: I13679234f6f473e9a93179e6791fb57eac512f25
2023-01-05 18:30:23 +00:00
..
cmd cmd/uplinkng: become cmd/uplink 2022-02-09 17:02:21 +00:00
ulext all: fix deprecated ioutil commands 2022-10-11 15:27:29 +00:00
ulfs cmd/uplink: skip abort on committed multipart writes 2023-01-05 18:30:23 +00:00
ulloc cmd/uplinkng: become cmd/uplink 2022-02-09 17:02:21 +00:00
ultest all: fix deprecated ioutil commands 2022-10-11 15:27:29 +00:00
access_maker.go go.mod: bump clingy dependency 2022-08-31 10:24:27 +00:00
access_permissions.go cmd/uplink: fix some issues with share 2022-12-08 17:46:02 +00:00
cmd_access_create.go cmd/uplink: remove io/ioutil 2022-09-27 15:53:07 +00:00
cmd_access_export.go go.mod: bump clingy dependency 2022-08-31 10:24:27 +00:00
cmd_access_import.go go.mod: bump clingy dependency 2022-08-31 10:24:27 +00:00
cmd_access_inspect_test.go cmd/uplinkng: become cmd/uplink 2022-02-09 17:02:21 +00:00
cmd_access_inspect.go go.mod: bump clingy dependency 2022-08-31 10:24:27 +00:00
cmd_access_list.go go.mod: bump clingy dependency 2022-08-31 10:24:27 +00:00
cmd_access_register.go go.mod: bump clingy dependency 2022-08-31 10:24:27 +00:00
cmd_access_remove.go go.mod: bump clingy dependency 2022-08-31 10:24:27 +00:00
cmd_access_restrict.go go.mod: bump clingy dependency 2022-08-31 10:24:27 +00:00
cmd_access_revoke.go go.mod: bump clingy dependency 2022-08-31 10:24:27 +00:00
cmd_access_setup.go go.mod: bump clingy dependency 2022-08-31 10:24:27 +00:00
cmd_access_use.go go.mod: bump clingy dependency 2022-08-31 10:24:27 +00:00
cmd_cp_test.go cmd/uplink: improve cp behavior 2022-09-27 10:23:41 +00:00
cmd_cp.go cmd/uplink: add buffering while reading from stdin 2022-12-23 16:40:54 +00:00
cmd_ls_test.go cmd/uplink: fix recursive copy and improve tests 2022-05-11 15:17:16 -04:00
cmd_ls.go go.mod: bump clingy dependency 2022-08-31 10:24:27 +00:00
cmd_mb.go go.mod: bump clingy dependency 2022-08-31 10:24:27 +00:00
cmd_meta_get.go go.mod: bump clingy dependency 2022-08-31 10:24:27 +00:00
cmd_mv_test.go cmd/uplinkng: become cmd/uplink 2022-02-09 17:02:21 +00:00
cmd_mv.go go.mod: bump clingy dependency 2022-08-31 10:24:27 +00:00
cmd_rb.go go.mod: bump clingy dependency 2022-08-31 10:24:27 +00:00
cmd_rm_test.go cmd/uplink: disable deleting local files 2022-06-27 10:30:04 -04:00
cmd_rm.go go.mod: bump clingy dependency 2022-08-31 10:24:27 +00:00
cmd_share_test.go cmd/uplinkng: fix linkshare bugs 2022-03-03 16:00:10 +00:00
cmd_share.go cmd/uplink: fix some issues with share 2022-12-08 17:46:02 +00:00
cmd_version.go go.mod: bump clingy dependency 2022-08-31 10:24:27 +00:00
external_access.go cmd/uplink: Update error message referring to 'import' 2022-11-25 18:54:51 +01:00
external_config.go cmd/uplink: add eventkit 2022-10-07 12:08:08 -04:00
external_migrate.go cmd/uplink: fix migration for some old configs 2022-02-16 21:13:52 +00:00
external_project.go cmd/uplink: fix recursive copy and improve tests 2022-05-11 15:17:16 -04:00
external.go cmd/uplink: add options to save pprof/trace information 2022-11-30 11:53:29 +00:00
initial_setup.go cmd/uplink: add eventkit 2022-10-07 12:08:08 -04:00
main.go cmd/uplink: experimental environment variable to change piece hash algorithm 2022-09-08 10:41:04 +00:00
stdlib_flags_test.go storagenode/console/consoleapi: use fixed time.Now() 2022-07-01 12:36:01 +03:00
stdlib_flags.go cmd/uplink: fix some issues with share 2022-12-08 17:46:02 +00:00
tabbed_writer.go cmd/uplinkng: become cmd/uplink 2022-02-09 17:02:21 +00:00
ulimit_other.go cmd/uplink: raise fd limits 2022-04-27 18:11:44 +00:00
ulimit.go cmd/uplink: raise fd limits 2022-04-27 18:11:44 +00:00