// Copyright (C) 2019 Storj Labs, Inc. // See LICENSE for copying information. package checker import ( "context" "time" "github.com/spacemonkeygo/monkit/v3" "github.com/zeebo/errs" "go.uber.org/zap" "storj.io/common/errs2" "storj.io/common/pb" "storj.io/common/storj" "storj.io/common/sync2" "storj.io/storj/satellite/internalpb" "storj.io/storj/satellite/metabase" "storj.io/storj/satellite/metabase/metaloop" "storj.io/storj/satellite/overlay" "storj.io/storj/satellite/repair" "storj.io/storj/satellite/repair/queue" ) // Error is a standard error class for this package. var ( Error = errs.Class("repair checker") mon = monkit.Package() ) // Checker contains the information needed to do checks for missing pieces. // // architecture: Chore type Checker struct { logger *zap.Logger repairQueue queue.RepairQueue metabase *metabase.DB metaLoop *metaloop.Service nodestate *ReliabilityCache statsCollector *statsCollector repairOverrides RepairOverridesMap nodeFailureRate float64 Loop *sync2.Cycle } // NewChecker creates a new instance of checker. func NewChecker(logger *zap.Logger, repairQueue queue.RepairQueue, metabase *metabase.DB, metaLoop *metaloop.Service, overlay *overlay.Service, config Config) *Checker { return &Checker{ logger: logger, repairQueue: repairQueue, metabase: metabase, metaLoop: metaLoop, nodestate: NewReliabilityCache(overlay, config.ReliabilityCacheStaleness), statsCollector: newStatsCollector(), repairOverrides: config.RepairOverrides.GetMap(), nodeFailureRate: config.NodeFailureRate, Loop: sync2.NewCycle(config.Interval), } } // Run the checker loop. func (checker *Checker) Run(ctx context.Context) (err error) { defer mon.Task()(&ctx)(&err) return checker.Loop.Run(ctx, checker.IdentifyInjuredSegments) } // getNodesEstimate updates the estimate of the total number of nodes. It is guaranteed // to return a number greater than 0 when the error is nil. // // We can't calculate this upon first starting a Checker, because there may not be any // nodes yet. We expect that there will be nodes before there are segments, though. func (checker *Checker) getNodesEstimate(ctx context.Context) (int, error) { // this should be safe to call frequently; it is an efficient caching lookup. totalNumNodes, err := checker.nodestate.NumNodes(ctx) if err != nil { // We could proceed here by returning the last good value, or by returning a fallback // constant estimate, like "20000", and we'd probably be fine, but it would be better // not to have that happen silently for too long. Also, if we can't get this from the // database, we probably can't modify the injured segments queue, so it won't help to // proceed with this repair operation. return 0, err } if totalNumNodes == 0 { return 0, Error.New("segment health is meaningless: there are no nodes") } return totalNumNodes, nil } // RefreshReliabilityCache forces refreshing node online status cache. func (checker *Checker) RefreshReliabilityCache(ctx context.Context) error { return checker.nodestate.Refresh(ctx) } // Close halts the Checker loop. func (checker *Checker) Close() error { checker.Loop.Close() return nil } // IdentifyInjuredSegments checks for missing pieces off of the metainfo and overlay. func (checker *Checker) IdentifyInjuredSegments(ctx context.Context) (err error) { defer mon.Task()(&ctx)(&err) startTime := time.Now() observer := &checkerObserver{ repairQueue: checker.repairQueue, nodestate: checker.nodestate, statsCollector: checker.statsCollector, monStats: aggregateStats{}, repairOverrides: checker.repairOverrides, nodeFailureRate: checker.nodeFailureRate, getNodesEstimate: checker.getNodesEstimate, log: checker.logger, } err = checker.metaLoop.Join(ctx, observer) if err != nil { if !errs2.IsCanceled(err) { checker.logger.Error("IdentifyInjuredSegments error", zap.Error(err)) } return err } // remove all segments which were not seen as unhealthy by this checker iteration healthyDeleted, err := checker.repairQueue.Clean(ctx, startTime) if err != nil { return Error.Wrap(err) } checker.statsCollector.collectAggregates() mon.IntVal("remote_files_checked").Observe(observer.monStats.objectsChecked) //mon:locked mon.IntVal("remote_segments_checked").Observe(observer.monStats.remoteSegmentsChecked) //mon:locked mon.IntVal("remote_segments_failed_to_check").Observe(observer.monStats.remoteSegmentsFailedToCheck) //mon:locked mon.IntVal("remote_segments_needing_repair").Observe(observer.monStats.remoteSegmentsNeedingRepair) //mon:locked mon.IntVal("new_remote_segments_needing_repair").Observe(observer.monStats.newRemoteSegmentsNeedingRepair) //mon:locked mon.IntVal("remote_segments_lost").Observe(observer.monStats.remoteSegmentsLost) //mon:locked mon.IntVal("remote_files_lost").Observe(int64(len(observer.monStats.remoteSegmentInfo))) //mon:locked mon.IntVal("remote_segments_over_threshold_1").Observe(observer.monStats.remoteSegmentsOverThreshold[0]) //mon:locked mon.IntVal("remote_segments_over_threshold_2").Observe(observer.monStats.remoteSegmentsOverThreshold[1]) //mon:locked mon.IntVal("remote_segments_over_threshold_3").Observe(observer.monStats.remoteSegmentsOverThreshold[2]) //mon:locked mon.IntVal("remote_segments_over_threshold_4").Observe(observer.monStats.remoteSegmentsOverThreshold[3]) //mon:locked mon.IntVal("remote_segments_over_threshold_5").Observe(observer.monStats.remoteSegmentsOverThreshold[4]) //mon:locked mon.IntVal("healthy_segments_removed_from_queue").Observe(healthyDeleted) //mon:locked allUnhealthy := observer.monStats.remoteSegmentsNeedingRepair + observer.monStats.remoteSegmentsFailedToCheck allChecked := observer.monStats.remoteSegmentsChecked allHealthy := allChecked - allUnhealthy mon.FloatVal("remote_segments_healthy_percentage").Observe(100 * float64(allHealthy) / float64(allChecked)) //mon:locked return nil } var _ metaloop.Observer = (*checkerObserver)(nil) // checkerObserver implements the metainfo loop Observer interface. // // architecture: Observer type checkerObserver struct { repairQueue queue.RepairQueue nodestate *ReliabilityCache statsCollector *statsCollector monStats aggregateStats // TODO(cam): once we verify statsCollector reports data correctly, remove this repairOverrides RepairOverridesMap nodeFailureRate float64 getNodesEstimate func(ctx context.Context) (int, error) log *zap.Logger // we need to delay counting objects to ensure they get associated with the correct redundancy only once objectCounted bool } // checks for a object location in slice. func containsObjectLocation(a []metabase.ObjectLocation, x metabase.ObjectLocation) bool { for _, n := range a { if x == n { return true } } return false } func (obs *checkerObserver) getStatsByRS(redundancy storj.RedundancyScheme) *stats { rsString := getRSString(obs.loadRedundancy(redundancy)) return obs.statsCollector.getStatsByRS(rsString) } func (obs *checkerObserver) loadRedundancy(redundancy storj.RedundancyScheme) (int, int, int, int) { repair := int(redundancy.RepairShares) overrideValue := obs.repairOverrides.GetOverrideValue(redundancy) if overrideValue != 0 { repair = int(overrideValue) } return int(redundancy.RequiredShares), repair, int(redundancy.OptimalShares), int(redundancy.TotalShares) } // LoopStarted is called at each start of a loop. func (obs *checkerObserver) LoopStarted(context.Context, metaloop.LoopInfo) (err error) { return nil } func (obs *checkerObserver) RemoteSegment(ctx context.Context, segment *metaloop.Segment) (err error) { defer mon.Task()(&ctx)(&err) // ignore segment if expired if segment.Expired(time.Now()) { return nil } stats := obs.getStatsByRS(segment.Redundancy) if !obs.objectCounted { obs.objectCounted = true stats.iterationAggregates.objectsChecked++ } obs.monStats.remoteSegmentsChecked++ stats.iterationAggregates.remoteSegmentsChecked++ // ensure we get values, even if only zero values, so that redash can have an alert based on this mon.Counter("checker_segments_below_min_req").Inc(0) //mon:locked stats.segmentsBelowMinReq.Inc(0) pieces := segment.Pieces if len(pieces) == 0 { obs.log.Debug("no pieces on remote segment") return nil } pbPieces := make([]*pb.RemotePiece, len(pieces)) for i, piece := range pieces { pbPieces[i] = &pb.RemotePiece{ PieceNum: int32(piece.Number), NodeId: piece.StorageNode, } } totalNumNodes, err := obs.getNodesEstimate(ctx) if err != nil { return Error.New("could not get estimate of total number of nodes: %w", err) } createdAt := time.Time{} if segment.CreatedAt != nil { createdAt = *segment.CreatedAt } repairedAt := time.Time{} if segment.RepairedAt != nil { repairedAt = *segment.RepairedAt } missingPieces, err := obs.nodestate.MissingPieces(ctx, createdAt, segment.Pieces) if err != nil { obs.monStats.remoteSegmentsFailedToCheck++ stats.iterationAggregates.remoteSegmentsFailedToCheck++ return errs.Combine(Error.New("error getting missing pieces"), err) } numHealthy := len(pieces) - len(missingPieces) mon.IntVal("checker_segment_total_count").Observe(int64(len(pieces))) //mon:locked stats.segmentTotalCount.Observe(int64(len(pieces))) mon.IntVal("checker_segment_healthy_count").Observe(int64(numHealthy)) //mon:locked stats.segmentHealthyCount.Observe(int64(numHealthy)) segmentAge := time.Since(createdAt) mon.IntVal("checker_segment_age").Observe(int64(segmentAge.Seconds())) //mon:locked stats.segmentAge.Observe(int64(segmentAge.Seconds())) required, repairThreshold, successThreshold, _ := obs.loadRedundancy(segment.Redundancy) segmentHealth := repair.SegmentHealth(numHealthy, required, totalNumNodes, obs.nodeFailureRate) mon.FloatVal("checker_segment_health").Observe(segmentHealth) //mon:locked stats.segmentHealth.Observe(segmentHealth) key := segment.Location.Encode() // we repair when the number of healthy pieces is less than or equal to the repair threshold and is greater or equal to // minimum required pieces in redundancy // except for the case when the repair and success thresholds are the same (a case usually seen during testing) if numHealthy <= repairThreshold && numHealthy < successThreshold { mon.FloatVal("checker_injured_segment_health").Observe(segmentHealth) //mon:locked stats.injuredSegmentHealth.Observe(segmentHealth) obs.monStats.remoteSegmentsNeedingRepair++ stats.iterationAggregates.remoteSegmentsNeedingRepair++ alreadyInserted, err := obs.repairQueue.Insert(ctx, &internalpb.InjuredSegment{ Path: key, LostPieces: missingPieces, InsertedTime: time.Now().UTC(), }, segmentHealth) if err != nil { obs.log.Error("error adding injured segment to queue", zap.Error(err)) return nil } if !alreadyInserted { obs.monStats.newRemoteSegmentsNeedingRepair++ stats.iterationAggregates.newRemoteSegmentsNeedingRepair++ } // monitor irreperable segments if numHealthy < required { lostSegInfo := segment.Location.Object() if !containsObjectLocation(obs.monStats.remoteSegmentInfo, lostSegInfo) { obs.monStats.remoteSegmentInfo = append(obs.monStats.remoteSegmentInfo, lostSegInfo) } if !containsObjectLocation(stats.iterationAggregates.remoteSegmentInfo, lostSegInfo) { stats.iterationAggregates.remoteSegmentInfo = append(stats.iterationAggregates.remoteSegmentInfo, lostSegInfo) } var segmentAge time.Duration if createdAt.Before(repairedAt) { segmentAge = time.Since(repairedAt) } else { segmentAge = time.Since(createdAt) } mon.IntVal("checker_segment_time_until_irreparable").Observe(int64(segmentAge.Seconds())) //mon:locked stats.segmentTimeUntilIrreparable.Observe(int64(segmentAge.Seconds())) obs.monStats.remoteSegmentsLost++ stats.iterationAggregates.remoteSegmentsLost++ mon.Counter("checker_segments_below_min_req").Inc(1) //mon:locked stats.segmentsBelowMinReq.Inc(1) } } else { if numHealthy > repairThreshold && numHealthy <= (repairThreshold+len(obs.monStats.remoteSegmentsOverThreshold)) { // record metrics for segments right above repair threshold // numHealthy=repairThreshold+1 through numHealthy=repairThreshold+5 for i := range obs.monStats.remoteSegmentsOverThreshold { if numHealthy == (repairThreshold + i + 1) { obs.monStats.remoteSegmentsOverThreshold[i]++ break } } } if numHealthy > repairThreshold && numHealthy <= (repairThreshold+len(stats.iterationAggregates.remoteSegmentsOverThreshold)) { // record metrics for segments right above repair threshold // numHealthy=repairThreshold+1 through numHealthy=repairThreshold+5 for i := range stats.iterationAggregates.remoteSegmentsOverThreshold { if numHealthy == (repairThreshold + i + 1) { stats.iterationAggregates.remoteSegmentsOverThreshold[i]++ break } } } } return nil } func (obs *checkerObserver) Object(ctx context.Context, object *metaloop.Object) (err error) { defer mon.Task()(&ctx)(&err) obs.monStats.objectsChecked++ // TODO: check for expired objects if object.SegmentCount == 0 { stats := obs.getStatsByRS(storj.RedundancyScheme{}) stats.iterationAggregates.objectsChecked++ return nil } obs.objectCounted = false return nil } func (obs *checkerObserver) InlineSegment(ctx context.Context, segment *metaloop.Segment) (err error) { defer mon.Task()(&ctx)(&err) // TODO: check for expired segments if !obs.objectCounted { // Note: this may give false stats when an object starts with a inline segment. obs.objectCounted = true stats := obs.getStatsByRS(storj.RedundancyScheme{}) stats.iterationAggregates.objectsChecked++ } return nil }