// Copyright (C) 2018 Storj Labs, Inc. // See LICENSE for copying information. package overlay import ( "context" "os" "path/filepath" "testing" "github.com/gogo/protobuf/proto" "github.com/stretchr/testify/assert" "github.com/zeebo/errs" "storj.io/storj/internal/test" "storj.io/storj/pkg/utils" "storj.io/storj/protos/overlay" "storj.io/storj/storage" "storj.io/storj/storage/boltdb" "storj.io/storj/storage/redis" ) type dbClient int type responses map[dbClient]*overlay.NodeAddress type errors map[dbClient]error const ( mock dbClient = iota bolt _redis ) var ( getCases = []struct { testID string expectedTimesCalled int key string expectedResponses responses expectedErrors errors data test.KvStore }{ { testID: "valid Get", expectedTimesCalled: 1, key: "foo", expectedResponses: func() responses { na := &overlay.NodeAddress{Transport: overlay.NodeTransport_TCP, Address: "127.0.0.1:9999"} return responses{ mock: na, bolt: na, _redis: na, } }(), expectedErrors: errors{ mock: nil, bolt: nil, _redis: nil, }, data: test.KvStore{"foo": func() storage.Value { na := &overlay.NodeAddress{Transport: overlay.NodeTransport_TCP, Address: "127.0.0.1:9999"} d, err := proto.Marshal(na) if err != nil { panic(err) } return d }()}, }, { testID: "forced get error", expectedTimesCalled: 1, key: "error", expectedResponses: func() responses { na := &overlay.NodeAddress{Transport: overlay.NodeTransport_TCP, Address: "127.0.0.1:9999"} return responses{ mock: nil, bolt: na, _redis: na, } }(), expectedErrors: errors{ mock: test.ErrForced, bolt: nil, _redis: nil, }, data: test.KvStore{"error": func() storage.Value { na := &overlay.NodeAddress{Transport: overlay.NodeTransport_TCP, Address: "127.0.0.1:9999"} d, err := proto.Marshal(na) if err != nil { panic(err) } return d }()}, }, { testID: "get missing key", expectedTimesCalled: 1, key: "bar", expectedResponses: responses{ mock: nil, bolt: nil, _redis: nil, }, // TODO(bryanchriswhite): compare actual errors expectedErrors: errors{ mock: test.ErrMissingKey, bolt: errs.New("boltdb error"), _redis: errs.New("redis error"), }, data: test.KvStore{"foo": func() storage.Value { na := &overlay.NodeAddress{Transport: overlay.NodeTransport_TCP, Address: "127.0.0.1:9999"} d, err := proto.Marshal(na) if err != nil { panic(err) } return d }()}, }, } putCases = []struct { testID string expectedTimesCalled int key string value overlay.NodeAddress expectedErrors errors data test.KvStore }{ { testID: "valid Put", expectedTimesCalled: 1, key: "foo", value: overlay.NodeAddress{Transport: overlay.NodeTransport_TCP, Address: "127.0.0.1:9999"}, expectedErrors: errors{ mock: nil, bolt: nil, _redis: nil, }, data: test.KvStore{}, }, } ) func redisTestClient(t *testing.T, data test.KvStore) storage.KeyValueStore { client, err := redis.NewClient("127.0.0.1:6379", "", 1) assert.NoError(t, err) populateStorage(t, client, data) return client } func boltTestClient(t *testing.T, data test.KvStore) (_ storage.KeyValueStore, _ func()) { boltPath, err := filepath.Abs("test_bolt.db") assert.NoError(t, err) logger, err := utils.NewLogger("dev") assert.NoError(t, err) client, err := boltdb.NewClient(logger, boltPath, "testBoltdb") assert.NoError(t, err) cleanup := func() { err := os.Remove(boltPath) assert.NoError(t, err) } populateStorage(t, client, data) return client, cleanup } func populateStorage(t *testing.T, client storage.KeyValueStore, data test.KvStore) { for k, v := range data { err := client.Put(storage.Key(k), v) assert.NoError(t, err) } } func TestRedisGet(t *testing.T) { done := test.EnsureRedis(t) defer done() for _, c := range getCases { t.Run(c.testID, func(t *testing.T) { db := redisTestClient(t, c.data) oc := Cache{DB: db} resp, err := oc.Get(context.Background(), c.key) if expectedErr := c.expectedErrors[_redis]; expectedErr != nil { assert.Error(t, err) } else { assert.Equal(t, expectedErr, err) } assert.Equal(t, c.expectedResponses[_redis], resp) }) } } func TestRedisPut(t *testing.T) { done := test.EnsureRedis(t) defer done() for _, c := range putCases { t.Run(c.testID, func(t *testing.T) { db, cleanup := boltTestClient(t, c.data) defer cleanup() oc := Cache{DB: db} err := oc.Put(c.key, c.value) assert.Equal(t, c.expectedErrors[_redis], err) v, err := db.Get([]byte(c.key)) assert.NoError(t, err) na := &overlay.NodeAddress{} assert.NoError(t, proto.Unmarshal(v, na)) assert.Equal(t, na, &c.value) }) } } func TestBoltGet(t *testing.T) { for _, c := range getCases { t.Run(c.testID, func(t *testing.T) { db, cleanup := boltTestClient(t, c.data) defer cleanup() oc := Cache{DB: db} resp, err := oc.Get(context.Background(), c.key) if expectedErr := c.expectedErrors[bolt]; expectedErr != nil { assert.Error(t, err) } else { assert.Equal(t, expectedErr, err) } assert.Equal(t, c.expectedResponses[bolt], resp) }) } } func TestBoltPut(t *testing.T) { for _, c := range putCases { t.Run(c.testID, func(t *testing.T) { db, cleanup := boltTestClient(t, c.data) defer cleanup() oc := Cache{DB: db} err := oc.Put(c.key, c.value) assert.Equal(t, c.expectedErrors[_redis], err) v, err := db.Get([]byte(c.key)) assert.NoError(t, err) na := &overlay.NodeAddress{} assert.NoError(t, proto.Unmarshal(v, na)) assert.Equal(t, na, &c.value) }) } } func TestMockGet(t *testing.T) { for _, c := range getCases { t.Run(c.testID, func(t *testing.T) { db := test.NewMockKeyValueStore(c.data) oc := Cache{DB: db} assert.Equal(t, 0, db.GetCalled) resp, err := oc.Get(context.Background(), c.key) assert.Equal(t, c.expectedErrors[mock], err) assert.Equal(t, c.expectedResponses[mock], resp) assert.Equal(t, c.expectedTimesCalled, db.GetCalled) }) } } func TestMockPut(t *testing.T) { for _, c := range putCases { t.Run(c.testID, func(t *testing.T) { db := test.NewMockKeyValueStore(c.data) oc := Cache{DB: db} assert.Equal(t, 0, db.PutCalled) err := oc.Put(c.key, c.value) assert.Equal(t, c.expectedErrors[mock], err) assert.Equal(t, c.expectedTimesCalled, db.PutCalled) v := db.Data[c.key] na := &overlay.NodeAddress{} assert.NoError(t, proto.Unmarshal(v, na)) assert.Equal(t, na, &c.value) }) } }