JakeHillion/storj
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

storagenode/retain: don't quit on error

Browse Source 
It has been noted in the forum that, during a Retain operation, when a
piece can't be deleted, the process never completes. The error is
written to the log, but the completion line "Moved pieces to trash
during retain" never is.

This `return` line is the reason. We should instead continue the loop.

Change-Id: I0f51d34aba0e81ad60a75802069b42dc135ad907
Refs: https://github.com/storj/storj/issues/6482
This commit is contained in:
paul cannon 2023-11-06 10:48:22 -06:00
parent 015cb94909
commit fd55dad735
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
storagenode/retain/retain.go
View File

@ -343,7 +343,7 @@ func (s *Service) retainPieces(ctx context.Context, req Request) (err error) {
zap.Stringer("Satellite ID", satelliteID), zap.Stringer("Satellite ID", satelliteID),
zap.Stringer("Piece ID", pieceID), zap.Stringer("Piece ID", pieceID),
zap.Error(err)) zap.Error(err))
return nil continue
} }
} }
numDeleted++ numDeleted++