From f8b59a50ffd9137f4e333f853032ca9f31cdc651 Mon Sep 17 00:00:00 2001
From: Jeremy Wharton <jeremy.e.wharton@gmail.com>
Date: Tue, 17 Oct 2023 05:08:19 -0500
Subject: [PATCH] satellite/console: configure sending invites to unregistered
 emails

This change adds a flag to the satellite config indicating whether
unregistered email addresses should receive project invitation emails.

Change-Id: I0396f25574ddae3f9adaea32a6e7cd15b931bf12
---
 satellite/console/config.go                   | 27 ++++++++++---------
 satellite/console/consoleweb/config.go        |  1 +
 satellite/console/consoleweb/server.go        |  1 +
 satellite/console/service.go                  |  2 +-
 scripts/testdata/satellite-config.yaml.lock   |  3 +++
 .../components/modals/AddTeamMemberModal.vue  | 18 +++++++++++--
 .../src/components/team/HeaderArea.vue        | 14 ++++++++--
 .../components/team/ProjectMembersArea.vue    | 17 ++++++++++--
 .../src/store/modules/notificationsStore.ts   |  3 ++-
 web/satellite/src/types/config.gen.ts         |  4 ++-
 .../src/utils/plugins/notificator.ts          |  4 +--
 .../src/components/TeamTableComponent.vue     | 12 +++++++--
 .../dialogs/AddTeamMemberDialog.vue           | 14 +++++++++-
 13 files changed, 93 insertions(+), 27 deletions(-)

diff --git a/satellite/console/config.go b/satellite/console/config.go
index 34090fe5d..976d97567 100644
--- a/satellite/console/config.go
+++ b/satellite/console/config.go
@@ -14,19 +14,20 @@ import (
 
 // Config keeps track of core console service configuration parameters.
 type Config struct {
-	PasswordCost                int                       `help:"password hashing cost (0=automatic)" testDefault:"4" default:"0"`
-	OpenRegistrationEnabled     bool                      `help:"enable open registration" default:"false" testDefault:"true"`
-	DefaultProjectLimit         int                       `help:"default project limits for users" default:"1" testDefault:"5"`
-	AsOfSystemTimeDuration      time.Duration             `help:"default duration for AS OF SYSTEM TIME" devDefault:"-5m" releaseDefault:"-5m" testDefault:"0"`
-	LoginAttemptsWithoutPenalty int                       `help:"number of times user can try to login without penalty" default:"3"`
-	FailedLoginPenalty          float64                   `help:"incremental duration of penalty for failed login attempts in minutes" default:"2.0"`
-	ProjectInvitationExpiration time.Duration             `help:"duration that project member invitations are valid for" default:"168h"`
-	UserBalanceForUpgrade       int64                     `help:"amount of base units of US micro dollars needed to upgrade user's tier status" default:"10000000"`
-	PlacementEdgeURLOverrides   PlacementEdgeURLOverrides `help:"placement-specific edge service URL overrides in the format {\"placementID\": {\"authService\": \"...\", \"publicLinksharing\": \"...\", \"internalLinksharing\": \"...\"}, \"placementID2\": ...}"`
-	BlockExplorerURL            string                    `help:"url of the transaction block explorer" default:"https://etherscan.io/"`
-	UsageLimits                 UsageLimitsConfig
-	Captcha                     CaptchaConfig
-	Session                     SessionConfig
+	PasswordCost                    int                       `help:"password hashing cost (0=automatic)" testDefault:"4" default:"0"`
+	OpenRegistrationEnabled         bool                      `help:"enable open registration" default:"false" testDefault:"true"`
+	DefaultProjectLimit             int                       `help:"default project limits for users" default:"1" testDefault:"5"`
+	AsOfSystemTimeDuration          time.Duration             `help:"default duration for AS OF SYSTEM TIME" devDefault:"-5m" releaseDefault:"-5m" testDefault:"0"`
+	LoginAttemptsWithoutPenalty     int                       `help:"number of times user can try to login without penalty" default:"3"`
+	FailedLoginPenalty              float64                   `help:"incremental duration of penalty for failed login attempts in minutes" default:"2.0"`
+	ProjectInvitationExpiration     time.Duration             `help:"duration that project member invitations are valid for" default:"168h"`
+	UnregisteredInviteEmailsEnabled bool                      `help:"indicates whether invitation emails can be sent to unregistered email addresses" default:"false"`
+	UserBalanceForUpgrade           int64                     `help:"amount of base units of US micro dollars needed to upgrade user's tier status" default:"10000000"`
+	PlacementEdgeURLOverrides       PlacementEdgeURLOverrides `help:"placement-specific edge service URL overrides in the format {\"placementID\": {\"authService\": \"...\", \"publicLinksharing\": \"...\", \"internalLinksharing\": \"...\"}, \"placementID2\": ...}"`
+	BlockExplorerURL                string                    `help:"url of the transaction block explorer" default:"https://etherscan.io/"`
+	UsageLimits                     UsageLimitsConfig
+	Captcha                         CaptchaConfig
+	Session                         SessionConfig
 }
 
 // CaptchaConfig contains configurations for login/registration captcha system.
diff --git a/satellite/console/consoleweb/config.go b/satellite/console/consoleweb/config.go
index 7ed234e9b..76e92cb52 100644
--- a/satellite/console/consoleweb/config.go
+++ b/satellite/console/consoleweb/config.go
@@ -51,6 +51,7 @@ type FrontendConfig struct {
 	NeededTransactionConfirmations  int                   `json:"neededTransactionConfirmations"`
 	ObjectBrowserPaginationEnabled  bool                  `json:"objectBrowserPaginationEnabled"`
 	BillingFeaturesEnabled          bool                  `json:"billingFeaturesEnabled"`
+	UnregisteredInviteEmailsEnabled bool                  `json:"unregisteredInviteEmailsEnabled"`
 }
 
 // Satellites is a configuration value that contains a list of satellite names and addresses.
diff --git a/satellite/console/consoleweb/server.go b/satellite/console/consoleweb/server.go
index 1b707e834..58b742055 100644
--- a/satellite/console/consoleweb/server.go
+++ b/satellite/console/consoleweb/server.go
@@ -750,6 +750,7 @@ func (server *Server) frontendConfigHandler(w http.ResponseWriter, r *http.Reque
 		NeededTransactionConfirmations:  server.neededTokenPaymentConfirmations,
 		ObjectBrowserPaginationEnabled:  server.config.ObjectBrowserPaginationEnabled,
 		BillingFeaturesEnabled:          server.config.BillingFeaturesEnabled,
+		UnregisteredInviteEmailsEnabled: server.config.UnregisteredInviteEmailsEnabled,
 	}
 
 	err := json.NewEncoder(w).Encode(&cfg)
diff --git a/satellite/console/service.go b/satellite/console/service.go
index bae0249b2..4677c8c5f 100644
--- a/satellite/console/service.go
+++ b/satellite/console/service.go
@@ -3821,7 +3821,7 @@ func (s *Service) inviteProjectMembers(ctx context.Context, sender *User, projec
 				}
 			}
 			unverifiedUsers = append(unverifiedUsers, oldest)
-		} else {
+		} else if s.config.UnregisteredInviteEmailsEnabled {
 			newUserEmails = append(newUserEmails, email)
 		}
 	}
diff --git a/scripts/testdata/satellite-config.yaml.lock b/scripts/testdata/satellite-config.yaml.lock
index 63274c8e3..695a5be78 100755
--- a/scripts/testdata/satellite-config.yaml.lock
+++ b/scripts/testdata/satellite-config.yaml.lock
@@ -400,6 +400,9 @@ compensation.withheld-percents: 75,75,75,50,50,50,25,25,25,0,0,0,0,0,0
 # url link to terms and conditions page
 # console.terms-and-conditions-url: https://www.storj.io/terms-of-service/
 
+# indicates whether invitation emails can be sent to unregistered email addresses
+# console.unregistered-invite-emails-enabled: false
+
 # the default free-tier bandwidth usage limit
 # console.usage-limits.bandwidth.free: 25.00 GB
 
diff --git a/web/satellite/src/components/modals/AddTeamMemberModal.vue b/web/satellite/src/components/modals/AddTeamMemberModal.vue
index b332487a5..6517167e9 100644
--- a/web/satellite/src/components/modals/AddTeamMemberModal.vue
+++ b/web/satellite/src/components/modals/AddTeamMemberModal.vue
@@ -61,7 +61,7 @@
 </template>
 
 <script setup lang='ts'>
-import { computed, ref } from 'vue';
+import { computed, h, ref } from 'vue';
 
 import { Validator } from '@/utils/validation';
 import { AnalyticsErrorEventSource, AnalyticsEvent } from '@/utils/constants/analyticsEventNames';
@@ -71,6 +71,7 @@ import { useProjectMembersStore } from '@/store/modules/projectMembersStore';
 import { useAppStore } from '@/store/modules/appStore';
 import { useProjectsStore } from '@/store/modules/projectsStore';
 import { useAnalyticsStore } from '@/store/modules/analyticsStore';
+import { useConfigStore } from '@/store/modules/configStore';
 import { useLoading } from '@/composables/useLoading';
 import { MODALS } from '@/utils/constants/appStatePopUps';
 
@@ -86,6 +87,8 @@ const appStore = useAppStore();
 const pmStore = useProjectMembersStore();
 const usersStore = useUsersStore();
 const projectsStore = useProjectsStore();
+const configStore = useConfigStore();
+
 const notify = useNotify();
 const { isLoading, withLoading } = useLoading();
 
@@ -135,7 +138,18 @@ async function onPrimaryClick(): Promise<void> {
         }
 
         analyticsStore.eventTriggered(AnalyticsEvent.PROJECT_MEMBERS_INVITE_SENT);
-        notify.notify('Invite sent!');
+
+        if (configStore.state.config.unregisteredInviteEmailsEnabled) {
+            notify.notify('Invite sent!');
+        } else {
+            notify.notify(() => [
+                h('p', { class: 'message-title' }, 'Invite sent!'),
+                h('p', { class: 'message-info' }, [
+                    'An invitation will be sent to the email address if it belongs to a user on this satellite.',
+                ]),
+            ]);
+        }
+
         pmStore.setSearchQuery('');
 
         try {
diff --git a/web/satellite/src/components/team/HeaderArea.vue b/web/satellite/src/components/team/HeaderArea.vue
index 9e032ff79..95875ea8a 100644
--- a/web/satellite/src/components/team/HeaderArea.vue
+++ b/web/satellite/src/components/team/HeaderArea.vue
@@ -73,7 +73,7 @@
 </template>
 
 <script setup lang="ts">
-import { computed, onMounted, onBeforeUnmount, ref } from 'vue';
+import { computed, onMounted, onBeforeUnmount, ref, h } from 'vue';
 
 import { AnalyticsErrorEventSource, AnalyticsEvent } from '@/utils/constants/analyticsEventNames';
 import { MODALS } from '@/utils/constants/appStatePopUps';
@@ -168,7 +168,17 @@ async function resendInvites(): Promise<void> {
 
         try {
             await pmStore.reinviteMembers(pmStore.state.selectedProjectMembersEmails, projectsStore.state.selectedProject.id);
-            notify.success('Invites re-sent!');
+
+            if (configStore.state.config.unregisteredInviteEmailsEnabled) {
+                notify.success('Invites re-sent!');
+            } else {
+                notify.success(() => [
+                    h('p', { class: 'message-title' }, 'Invites re-sent!'),
+                    h('p', { class: 'message-info' }, [
+                        'Invitations will be re-sent to the email addresses that belong to users on this satellite.',
+                    ]),
+                ]);
+            }
         } catch (error) {
             error.message = `Unable to resend project invitations. ${error.message}`;
             notify.notifyError(error, AnalyticsErrorEventSource.PROJECT_MEMBERS_HEADER);
diff --git a/web/satellite/src/components/team/ProjectMembersArea.vue b/web/satellite/src/components/team/ProjectMembersArea.vue
index 688519774..676f02e5c 100644
--- a/web/satellite/src/components/team/ProjectMembersArea.vue
+++ b/web/satellite/src/components/team/ProjectMembersArea.vue
@@ -46,7 +46,7 @@
 </template>
 
 <script setup lang="ts">
-import { computed, onMounted, ref } from 'vue';
+import { computed, h, onMounted, ref } from 'vue';
 
 import { ProjectMemberItemModel } from '@/types/projectMembers';
 import { AnalyticsErrorEventSource, AnalyticsEvent } from '@/utils/constants/analyticsEventNames';
@@ -57,6 +57,7 @@ import { useLoading } from '@/composables/useLoading';
 import { MODALS } from '@/utils/constants/appStatePopUps';
 import { useAppStore } from '@/store/modules/appStore';
 import { useAnalyticsStore } from '@/store/modules/analyticsStore';
+import { useConfigStore } from '@/store/modules/configStore';
 
 import VLoader from '@/components/common/VLoader.vue';
 import HeaderArea from '@/components/team/HeaderArea.vue';
@@ -69,6 +70,7 @@ const analyticsStore = useAnalyticsStore();
 const appStore = useAppStore();
 const pmStore = useProjectMembersStore();
 const projectsStore = useProjectsStore();
+const configStore = useConfigStore();
 const notify = useNotify();
 
 const { withLoading } = useLoading();
@@ -153,7 +155,18 @@ function onResendClick(member: ProjectMemberItemModel) {
         analyticsStore.eventTriggered(AnalyticsEvent.RESEND_INVITE_CLICKED);
         try {
             await pmStore.reinviteMembers([member.getEmail()], projectsStore.state.selectedProject.id);
-            notify.notify('Invite resent!');
+
+            if (configStore.state.config.unregisteredInviteEmailsEnabled) {
+                notify.success('Invite re-sent!');
+            } else {
+                notify.success(() => [
+                    h('p', { class: 'message-title' }, 'Invites re-sent!'),
+                    h('p', { class: 'message-info' }, [
+                        'The invitation will be re-sent to the email address if it belongs to a user on this satellite.',
+                    ]),
+                ]);
+            }
+
             pmStore.setSearchQuery('');
         } catch (error) {
             error.message = `Error resending invite. ${error.message}`;
diff --git a/web/satellite/src/store/modules/notificationsStore.ts b/web/satellite/src/store/modules/notificationsStore.ts
index 08051cd38..f23cc06d3 100644
--- a/web/satellite/src/store/modules/notificationsStore.ts
+++ b/web/satellite/src/store/modules/notificationsStore.ts
@@ -57,11 +57,12 @@ export const useNotificationsStore = defineStore('notifications', () => {
         addNotification(notification);
     }
 
-    function notifyInfo(message: NotificationMessage): void {
+    function notifyInfo(message: NotificationMessage, title?: string): void {
         const notification = new DelayedNotification(
             () => deleteNotification(notification.id),
             NotificationType.Info,
             message,
+            title,
         );
 
         addNotification(notification);
diff --git a/web/satellite/src/types/config.gen.ts b/web/satellite/src/types/config.gen.ts
index f2410e563..82334b337 100644
--- a/web/satellite/src/types/config.gen.ts
+++ b/web/satellite/src/types/config.gen.ts
@@ -13,7 +13,7 @@ export class FrontendConfig {
     satelliteName: string;
     satelliteNodeURL: string;
     stripePublicKey: string;
-    partneredSatellites: PartneredSatellite[];
+    partneredSatellites?: PartneredSatellite[];
     defaultProjectLimit: number;
     generalRequestURL: string;
     projectLimitsIncreaseRequestURL: string;
@@ -48,6 +48,7 @@ export class FrontendConfig {
     neededTransactionConfirmations: number;
     objectBrowserPaginationEnabled: boolean;
     billingFeaturesEnabled: boolean;
+    unregisteredInviteEmailsEnabled: boolean;
 }
 
 export class MultiCaptchaConfig {
@@ -55,6 +56,7 @@ export class MultiCaptchaConfig {
     hcaptcha: SingleCaptchaConfig;
 }
 
+// TODO: This class was added manually because TypeScript generation is broken.
 export class PartneredSatellite {
     name: string;
     address: string;
diff --git a/web/satellite/src/utils/plugins/notificator.ts b/web/satellite/src/utils/plugins/notificator.ts
index c9a2b4ba7..87132b4e7 100644
--- a/web/satellite/src/utils/plugins/notificator.ts
+++ b/web/satellite/src/utils/plugins/notificator.ts
@@ -38,9 +38,9 @@ export class Notificator {
         notificationsStore.notifyError(message, source);
     }
 
-    public notify(message: NotificationMessage): void {
+    public notify(message: NotificationMessage, title?: string): void {
         const notificationsStore = useNotificationsStore();
-        notificationsStore.notifyInfo(message);
+        notificationsStore.notifyInfo(message, title);
     }
 
     public warning(message: NotificationMessage): void {
diff --git a/web/satellite/vuetify-poc/src/components/TeamTableComponent.vue b/web/satellite/vuetify-poc/src/components/TeamTableComponent.vue
index 22395dfe1..3ae3da44a 100644
--- a/web/satellite/vuetify-poc/src/components/TeamTableComponent.vue
+++ b/web/satellite/vuetify-poc/src/components/TeamTableComponent.vue
@@ -157,6 +157,7 @@ import { useNotify } from '@/utils/hooks';
 import { Project } from '@/types/projects';
 import { SortDirection, tableSizeOptions } from '@/types/common';
 import { useUsersStore } from '@/store/modules/usersStore';
+import { useConfigStore } from '@/store/modules/configStore';
 
 import IconTrash from '@poc/components/icons/IconTrash.vue';
 import IconCopy from '@poc/components/icons/IconCopy.vue';
@@ -174,9 +175,9 @@ type RenderedItem = {
 
 const usersStore = useUsersStore();
 const analyticsStore = useAnalyticsStore();
-const appStore = useAppStore();
 const pmStore = useProjectMembersStore();
 const projectsStore = useProjectsStore();
+const configStore = useConfigStore();
 
 const router = useRouter();
 const notify = useNotify();
@@ -304,7 +305,14 @@ async function resendInvite(email: string): Promise<void> {
         analyticsStore.eventTriggered(AnalyticsEvent.RESEND_INVITE_CLICKED);
         try {
             await pmStore.reinviteMembers([email], selectedProject.value.id);
-            notify.notify('Invite resent!');
+            if (configStore.state.config.unregisteredInviteEmailsEnabled) {
+                notify.notify('Invite re-sent!');
+            } else {
+                notify.notify(
+                    'The invitation will be re-sent to the email address if it belongs to a user on this satellite.',
+                    'Invite re-sent!',
+                );
+            }
         } catch (error) {
             error.message = `Error resending invite. ${error.message}`;
             notify.notifyError(error, AnalyticsErrorEventSource.PROJECT_MEMBERS_PAGE);
diff --git a/web/satellite/vuetify-poc/src/components/dialogs/AddTeamMemberDialog.vue b/web/satellite/vuetify-poc/src/components/dialogs/AddTeamMemberDialog.vue
index b16c5b524..7d958b559 100644
--- a/web/satellite/vuetify-poc/src/components/dialogs/AddTeamMemberDialog.vue
+++ b/web/satellite/vuetify-poc/src/components/dialogs/AddTeamMemberDialog.vue
@@ -131,6 +131,7 @@ import { useProjectMembersStore } from '@/store/modules/projectMembersStore';
 import { useNotify } from '@/utils/hooks';
 import { useLoading } from '@/composables/useLoading';
 import { useUsersStore } from '@/store/modules/usersStore';
+import { useConfigStore } from '@/store/modules/configStore';
 
 import UpgradeAccountDialog from '@poc/components/dialogs/upgradeAccountFlow/UpgradeAccountDialog.vue';
 
@@ -151,6 +152,8 @@ const model = computed<boolean>({
 const usersStore = useUsersStore();
 const analyticsStore = useAnalyticsStore();
 const pmStore = useProjectMembersStore();
+const configStore = useConfigStore();
+
 const notify = useNotify();
 const { isLoading, withLoading } = useLoading();
 
@@ -184,7 +187,16 @@ async function onPrimaryClick(): Promise<void> {
     await withLoading(async () => {
         try {
             await pmStore.inviteMember(email.value, props.projectId);
-            notify.success('Invite sent!');
+
+            if (configStore.state.config.unregisteredInviteEmailsEnabled) {
+                notify.success('Invite sent!');
+            } else {
+                notify.success(
+                    'An invitation will be sent to the email address if it belongs to a user on this satellite.',
+                    'Invite sent!',
+                );
+            }
+
             email.value = '';
         } catch (error) {
             error.message = `Error inviting project member. ${error.message}`;