cmd/segment-reaper: Implement unit test for observer (#3658)
Implement some unit test cases for the observer.processSegment method and fix a bug found by these tests. A production snapshot is more certain but it's huge for having in the repository and run the test with it by the CI. We want to have tests for the different cases to detect zombie segments and relaying on production data cannot guarantee to have all of them. NOTE the test has been implemented with random values for not having always the same combination of segments list and the same values avoiding that the implementation gets stale due to the test. The issue about this is that it's harder to understand and we could get only sometimes failures in the CI in case that the implementation has some bug. The random tests allow to eventually check cases that a static test may now cover because it is not expressed or because it is needed to implement a large number of cases. Because we are worried that the test implementation is complex and we could have bugs on it despite that the same bugs should exist in both, the implementation and the test, moreover that we have to consider that the implementation and the tests have been written by different people. Because of that, we may replace entirely these random tests by a list of static ones.
This commit is contained in:
Ivan Fraixedes
GitHub
parent
de30d232cc
commit
e961b1840c
@ -17,8 +17,6 @@ import (
|
||||
"storj.io/storj/satellite/metainfo"
|
||||
)
|
||||
|
||||
const maxNumOfSegments = 64
|
||||
|
||||
var (
|
||||
detectCmd = &cobra.Command{
|
||||
Use: "detect",
|
||||
|
||||
@ -19,11 +19,16 @@ import (
|
||||
"storj.io/storj/satellite/metainfo"
|
||||
)
|
||||
|
||||
const lastSegment = int(-1)
|
||||
const (
|
||||
maxNumOfSegments = 64
|
||||
lastSegment = int(-1)
|
||||
)
|
||||
|
||||
// object represents object with segments.
|
||||
type object struct {
|
||||
// TODO verify if we have more than 64 segments for object in network
|
||||
// TODO verify if we have more than 65 segments for object in network.
|
||||
// 65 because the observer tracks in the bitmask all the segments execept the
|
||||
// last one (the 'l' segment)
|
||||
segments bitmask
|
||||
|
||||
expectedNumberOfSegments byte
|
||||
@ -94,6 +99,17 @@ func (obsvr *observer) Object(ctx context.Context, path metainfo.ScopedPath, poi
|
||||
return nil
|
||||
}
|
||||
|
||||
// processSegment aggregates, in the observer internal state, the objects that
|
||||
// belong the same project, tracking their segments indexes and aggregated
|
||||
// information of them for calling analyzeProject method, before a new project
|
||||
// list of object segments list starts and the internal status is reset.
|
||||
//
|
||||
// It also aggregates some stats about all the segments independently of the
|
||||
// object to which belong.
|
||||
//
|
||||
// NOTE it's expected that this method is called continually for the objects
|
||||
// which belong to a same project before calling it with objects of another
|
||||
// project.
|
||||
func (obsvr *observer) processSegment(ctx context.Context, path metainfo.ScopedPath, pointer *pb.Pointer) error {
|
||||
if obsvr.lastProjectID != "" && obsvr.lastProjectID != path.ProjectIDString {
|
||||
err := obsvr.analyzeProject(ctx)
|
||||
@ -119,7 +135,9 @@ func (obsvr *observer) processSegment(ctx context.Context, path metainfo.ScopedP
|
||||
}
|
||||
|
||||
if streamMeta.NumberOfSegments > 0 {
|
||||
if streamMeta.NumberOfSegments > int64(maxNumOfSegments) {
|
||||
// We can support the size of the bitmask + 1 because the last segment
|
||||
// ins't tracked in it.
|
||||
if streamMeta.NumberOfSegments > (int64(maxNumOfSegments) + 1) {
|
||||
object.skip = true
|
||||
zap.S().Warn("unsupported number of segments", zap.Int64("index", streamMeta.NumberOfSegments))
|
||||
}
|
||||
@ -133,20 +151,20 @@ func (obsvr *observer) processSegment(ctx context.Context, path metainfo.ScopedP
|
||||
if segmentIndex >= int(maxNumOfSegments) {
|
||||
object.skip = true
|
||||
zap.S().Warn("unsupported segment index", zap.Int("index", segmentIndex))
|
||||
}
|
||||
} else {
|
||||
ok, err := object.segments.Has(segmentIndex)
|
||||
if err != nil {
|
||||
return err
|
||||
}
|
||||
if ok {
|
||||
// TODO make path displayable
|
||||
return errs.New("fatal error this segment is duplicated: %s", path.Raw)
|
||||
}
|
||||
|
||||
ok, err := object.segments.Has(segmentIndex)
|
||||
if err != nil {
|
||||
return err
|
||||
}
|
||||
if ok {
|
||||
// TODO make path displayable
|
||||
return errs.New("fatal error this segment is duplicated: %s", path.Raw)
|
||||
}
|
||||
|
||||
err = object.segments.Set(segmentIndex)
|
||||
if err != nil {
|
||||
return err
|
||||
err = object.segments.Set(segmentIndex)
|
||||
if err != nil {
|
||||
return err
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
|
||||
@ -5,18 +5,214 @@ package main
|
||||
|
||||
import (
|
||||
"bytes"
|
||||
"context"
|
||||
"fmt"
|
||||
"math"
|
||||
"math/rand"
|
||||
"os"
|
||||
"strconv"
|
||||
"strings"
|
||||
"testing"
|
||||
"time"
|
||||
|
||||
"github.com/gogo/protobuf/proto"
|
||||
"github.com/skyrings/skyring-common/tools/uuid"
|
||||
"github.com/stretchr/testify/assert"
|
||||
"github.com/stretchr/testify/require"
|
||||
|
||||
"storj.io/storj/pkg/pb"
|
||||
"storj.io/storj/pkg/storj"
|
||||
"storj.io/storj/private/testcontext"
|
||||
"storj.io/storj/private/testrand"
|
||||
"storj.io/storj/satellite/metainfo"
|
||||
)
|
||||
|
||||
func Test_observer_analyzeProject(t *testing.T) {
|
||||
func TestMain(m *testing.M) {
|
||||
rand.Seed(time.Now().UnixNano())
|
||||
os.Exit(m.Run())
|
||||
}
|
||||
|
||||
func TestObserver_processSegment(t *testing.T) {
|
||||
t.Run("valid objects of different projects", func(t *testing.T) {
|
||||
ctx := testcontext.New(t)
|
||||
defer ctx.Cleanup()
|
||||
|
||||
obsvr := &observer{
|
||||
objects: make(bucketsObjects),
|
||||
}
|
||||
|
||||
testdata1 := generateTestdataObjects(ctx.Context, t, false, false)
|
||||
// Call processSegment with testadata objects of the first project
|
||||
for _, objSeg := range testdata1.objSegments {
|
||||
err := obsvr.processSegment(ctx.Context, objSeg.path, objSeg.pointer)
|
||||
require.NoError(t, err)
|
||||
}
|
||||
|
||||
testdata2 := generateTestdataObjects(ctx.Context, t, false, false)
|
||||
// Call processSegment with testadata objects of the second project
|
||||
for _, objSeg := range testdata2.objSegments {
|
||||
err := obsvr.processSegment(ctx.Context, objSeg.path, objSeg.pointer)
|
||||
require.NoError(t, err)
|
||||
}
|
||||
|
||||
// Inspect observer internal state to assert that it only has the state
|
||||
// related to the second project
|
||||
assertObserver(t, obsvr, testdata2)
|
||||
|
||||
// Assert that objserver keep track global stats of all the segments which
|
||||
// have received through processSegment calls
|
||||
assert.Equal(t,
|
||||
testdata1.expectedInlineSegments+testdata2.expectedInlineSegments,
|
||||
obsvr.inlineSegments,
|
||||
"inlineSegments",
|
||||
)
|
||||
assert.Equal(t,
|
||||
testdata1.expectedInlineSegments+testdata2.expectedInlineSegments,
|
||||
obsvr.lastInlineSegments,
|
||||
"lastInlineSegments",
|
||||
)
|
||||
assert.Equal(t,
|
||||
testdata1.expectedRemoteSegments+testdata2.expectedRemoteSegments,
|
||||
obsvr.remoteSegments,
|
||||
"remoteSegments",
|
||||
)
|
||||
})
|
||||
|
||||
t.Run("object without last segment", func(t *testing.T) {
|
||||
ctx := testcontext.New(t)
|
||||
defer ctx.Cleanup()
|
||||
|
||||
var (
|
||||
testdata = generateTestdataObjects(ctx.Context, t, true, false)
|
||||
obsvr = &observer{
|
||||
objects: make(bucketsObjects),
|
||||
}
|
||||
)
|
||||
|
||||
// Call processSegment with the testdata
|
||||
for _, objSeg := range testdata.objSegments {
|
||||
err := obsvr.processSegment(ctx.Context, objSeg.path, objSeg.pointer)
|
||||
require.NoError(t, err)
|
||||
}
|
||||
|
||||
// Assert observer internal state
|
||||
assertObserver(t, obsvr, testdata)
|
||||
|
||||
// Assert observer global stats
|
||||
assert.Equal(t, testdata.expectedInlineSegments, obsvr.inlineSegments, "inlineSegments")
|
||||
assert.Equal(t, testdata.expectedInlineSegments, obsvr.lastInlineSegments, "lastInlineSegments")
|
||||
assert.Equal(t, testdata.expectedRemoteSegments, obsvr.remoteSegments, "remoteSegments")
|
||||
})
|
||||
|
||||
t.Run("object with 65 segments without expected number of segments", func(t *testing.T) {
|
||||
ctx := testcontext.New(t)
|
||||
defer ctx.Cleanup()
|
||||
|
||||
var (
|
||||
bucketName = "a bucket"
|
||||
projectID = testrand.UUID()
|
||||
numSegments = 65
|
||||
obsvr = observer{
|
||||
objects: make(bucketsObjects),
|
||||
}
|
||||
objPath, objSegmentsRefs = createNewObjectSegments(
|
||||
ctx.Context, t, numSegments, &projectID, bucketName, false, false,
|
||||
)
|
||||
)
|
||||
|
||||
for _, objSeg := range objSegmentsRefs {
|
||||
err := obsvr.processSegment(ctx.Context, objSeg.path, objSeg.pointer)
|
||||
require.NoError(t, err)
|
||||
}
|
||||
|
||||
// Assert observer internal state
|
||||
assert.Equal(t, projectID.String(), obsvr.lastProjectID, "lastProjectID")
|
||||
assert.Equal(t, 1, len(obsvr.objects), "objects number")
|
||||
if assert.Contains(t, obsvr.objects, bucketName, "bucket in objects map") {
|
||||
if assert.Equal(t, 1, len(obsvr.objects[bucketName]), "objects in object map") {
|
||||
if assert.Contains(t, obsvr.objects[bucketName], objPath, "path in bucket objects map") {
|
||||
obj := obsvr.objects[bucketName][objPath]
|
||||
assert.Zero(t, obj.expectedNumberOfSegments, "Object.expectedNumSegments")
|
||||
assert.True(t, obj.hasLastSegment, "Object.hasLastSegment")
|
||||
assert.False(t, obj.skip, "Object.skip")
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
// Assert observer global stats
|
||||
assert.Zero(t, obsvr.inlineSegments, "inlineSegments")
|
||||
assert.Zero(t, obsvr.lastInlineSegments, "lastInlineSegments")
|
||||
assert.Equal(t, numSegments, obsvr.remoteSegments, "remoteSegments")
|
||||
})
|
||||
|
||||
t.Run("object with 65 segments with expected number of segments", func(t *testing.T) {
|
||||
ctx := testcontext.New(t)
|
||||
defer ctx.Cleanup()
|
||||
|
||||
var (
|
||||
bucketName = "a bucket"
|
||||
projectID = testrand.UUID()
|
||||
numSegments = 65
|
||||
obsvr = observer{
|
||||
objects: make(bucketsObjects),
|
||||
}
|
||||
objPath, objSegmentsRefs = createNewObjectSegments(
|
||||
ctx.Context, t, numSegments, &projectID, bucketName, false, true,
|
||||
)
|
||||
)
|
||||
|
||||
for _, objSeg := range objSegmentsRefs {
|
||||
err := obsvr.processSegment(ctx.Context, objSeg.path, objSeg.pointer)
|
||||
require.NoError(t, err)
|
||||
}
|
||||
|
||||
// Assert observer internal state
|
||||
assert.Equal(t, projectID.String(), obsvr.lastProjectID, "lastProjectID")
|
||||
assert.Equal(t, 1, len(obsvr.objects), "objects number")
|
||||
if assert.Contains(t, obsvr.objects, bucketName, "bucket in objects map") {
|
||||
if assert.Equal(t, 1, len(obsvr.objects[bucketName]), "objects in object map") {
|
||||
if assert.Contains(t, obsvr.objects[bucketName], objPath, "path in bucket objects map") {
|
||||
obj := obsvr.objects[bucketName][objPath]
|
||||
assert.Equal(t, numSegments, int(obj.expectedNumberOfSegments), "Object.expectedNumSegments")
|
||||
assert.True(t, obj.hasLastSegment, "Object.hasLastSegment")
|
||||
assert.False(t, obj.skip, "Object.skip")
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
// Assert observer global stats
|
||||
assert.Zero(t, obsvr.inlineSegments, "inlineSegments")
|
||||
assert.Zero(t, obsvr.lastInlineSegments, "lastInlineSegments")
|
||||
assert.Equal(t, numSegments, obsvr.remoteSegments, "remoteSegments")
|
||||
})
|
||||
|
||||
t.Run("objects with at least one has more than 65 segments", func(t *testing.T) {
|
||||
ctx := testcontext.New(t)
|
||||
defer ctx.Cleanup()
|
||||
|
||||
var (
|
||||
testdata = generateTestdataObjects(ctx.Context, t, false, true)
|
||||
obsvr = &observer{
|
||||
objects: make(bucketsObjects),
|
||||
}
|
||||
)
|
||||
|
||||
for _, objSeg := range testdata.objSegments {
|
||||
err := obsvr.processSegment(ctx.Context, objSeg.path, objSeg.pointer)
|
||||
require.NoError(t, err)
|
||||
}
|
||||
|
||||
// Assert observer internal state
|
||||
assertObserver(t, obsvr, testdata)
|
||||
|
||||
// Assert observer global stats
|
||||
assert.Equal(t, testdata.expectedInlineSegments, obsvr.inlineSegments, "inlineSegments")
|
||||
assert.Equal(t, testdata.expectedInlineSegments, obsvr.lastInlineSegments, "lastInlineSegments")
|
||||
assert.Equal(t, testdata.expectedRemoteSegments, obsvr.remoteSegments, "remoteSegments")
|
||||
})
|
||||
}
|
||||
|
||||
func TestObserver_analyzeProject(t *testing.T) {
|
||||
ctx := testcontext.New(t)
|
||||
defer ctx.Cleanup()
|
||||
|
||||
@ -95,7 +291,248 @@ func Test_observer_analyzeProject(t *testing.T) {
|
||||
}
|
||||
}
|
||||
|
||||
require.Equalf(t, tt.segmentsAfter, segmentsAfter, "segments before and after comparison faild: want %s got %s, case %d ", tt.segmentsAfter, segmentsAfter, testNum)
|
||||
require.Equalf(t, tt.segmentsAfter, segmentsAfter, "segments before and after comparison failed: want %s got %s, case %d ", tt.segmentsAfter, segmentsAfter, testNum)
|
||||
})
|
||||
}
|
||||
}
|
||||
|
||||
// segmentRef is an object segment reference to be used for simulating calls to
|
||||
// observer.processSegment
|
||||
type segmentRef struct {
|
||||
path metainfo.ScopedPath
|
||||
pointer *pb.Pointer
|
||||
}
|
||||
|
||||
// createNewObjectSegments creates a list of segment references which belongs to
|
||||
// a same object.
|
||||
//
|
||||
// If inline is true the last segment will be of INLINE type.
|
||||
//
|
||||
// If withNumSegments is true the last segment pointer will have the
|
||||
// NumberOfSegments set.
|
||||
//
|
||||
// It returns the object path and the list of object segment references.
|
||||
func createNewObjectSegments(
|
||||
ctx context.Context, t *testing.T, numSegments int, projectID *uuid.UUID, bucketName string, inline bool, withNumSegments bool,
|
||||
) (objectPath string, _ []segmentRef) {
|
||||
t.Helper()
|
||||
|
||||
var (
|
||||
objectID = testrand.UUID().String()
|
||||
projectIDString = projectID.String()
|
||||
references = make([]segmentRef, 0, numSegments)
|
||||
encryptedPath = fmt.Sprintf("%s-%s-%s", projectIDString, bucketName, objectID)
|
||||
)
|
||||
|
||||
for i := 0; i < (numSegments - 1); i++ {
|
||||
raw, err := metainfo.CreatePath(ctx, *projectID, int64(i), []byte(bucketName), []byte(objectID))
|
||||
require.NoError(t, err)
|
||||
|
||||
references = append(references, segmentRef{
|
||||
path: metainfo.ScopedPath{
|
||||
ProjectID: *projectID,
|
||||
ProjectIDString: projectIDString,
|
||||
BucketName: bucketName,
|
||||
Segment: fmt.Sprintf("s%d", i),
|
||||
EncryptedObjectPath: encryptedPath,
|
||||
Raw: raw,
|
||||
},
|
||||
pointer: &pb.Pointer{
|
||||
Type: pb.Pointer_REMOTE,
|
||||
},
|
||||
})
|
||||
}
|
||||
|
||||
pointerType := pb.Pointer_REMOTE
|
||||
if inline {
|
||||
pointerType = pb.Pointer_INLINE
|
||||
}
|
||||
|
||||
var pointerNumSegments int64
|
||||
if withNumSegments {
|
||||
pointerNumSegments = int64(numSegments)
|
||||
}
|
||||
|
||||
metadata, err := proto.Marshal(&pb.StreamMeta{
|
||||
NumberOfSegments: pointerNumSegments,
|
||||
})
|
||||
require.NoError(t, err)
|
||||
|
||||
raw, err := metainfo.CreatePath(ctx, *projectID, -1, []byte(bucketName), []byte(objectID))
|
||||
require.NoError(t, err)
|
||||
|
||||
references = append(references, segmentRef{
|
||||
path: metainfo.ScopedPath{
|
||||
ProjectID: *projectID,
|
||||
ProjectIDString: projectIDString,
|
||||
BucketName: bucketName,
|
||||
Segment: "l",
|
||||
EncryptedObjectPath: encryptedPath,
|
||||
Raw: raw,
|
||||
},
|
||||
pointer: &pb.Pointer{
|
||||
Type: pointerType,
|
||||
Metadata: metadata,
|
||||
},
|
||||
})
|
||||
|
||||
return encryptedPath, references
|
||||
}
|
||||
|
||||
type testdataObjects struct {
|
||||
// expectations
|
||||
expectedNumSegments int
|
||||
expectedInlineSegments int
|
||||
expectedRemoteSegments int
|
||||
expectedObjects bucketsObjects
|
||||
|
||||
// data used for calling processSegment
|
||||
objSegments []segmentRef
|
||||
projectID *uuid.UUID
|
||||
}
|
||||
|
||||
// generateTestdataObjects generate a testdataObjecst with a random number of
|
||||
// segments of a random number of objects and buckets but under the same
|
||||
// project.
|
||||
//
|
||||
// When withoutLastSegment is true, there will be objects without last segment,
|
||||
// otherwise all of them will have a last segment.
|
||||
//
|
||||
// When withMoreThanMaxNumSegments is true, there will be objects with more
|
||||
// segments than the maxNumOfSegments, otherwise all of them will have less or
|
||||
// equal than it.
|
||||
func generateTestdataObjects(
|
||||
ctx context.Context, t *testing.T, withoutLastSegment bool, withMoreThanMaxNumSegments bool,
|
||||
) testdataObjects {
|
||||
t.Helper()
|
||||
|
||||
var (
|
||||
testdata = testdataObjects{
|
||||
expectedObjects: make(bucketsObjects),
|
||||
}
|
||||
bucketName = "0"
|
||||
numObjs = rand.Intn(10) + 2
|
||||
projID = testrand.UUID()
|
||||
withoutLastSegmentCount = 0
|
||||
withMoreThanMaxNumSegmentsCount = 0
|
||||
numMaxGeneratedSegments = 10
|
||||
)
|
||||
|
||||
if withMoreThanMaxNumSegments {
|
||||
numMaxGeneratedSegments = 100
|
||||
}
|
||||
|
||||
testdata.projectID = &projID
|
||||
|
||||
for i := 0; i < numObjs; i++ {
|
||||
var (
|
||||
inline = (rand.Int() % 2) == 0
|
||||
withNumSegments = (rand.Int() % 2) == 0
|
||||
numSegments = rand.Intn(numMaxGeneratedSegments) + 2
|
||||
)
|
||||
|
||||
if numSegments > (maxNumOfSegments + 1) {
|
||||
withMoreThanMaxNumSegmentsCount++
|
||||
}
|
||||
|
||||
// If withMoreThanMaxNumSegments is true and all the objects created in all
|
||||
// the previous iterations have less or equal than maximum number of segments
|
||||
// and this is the last iteration then force that the object crated in this
|
||||
// iteration has more segments than the maximum.
|
||||
if withMoreThanMaxNumSegments &&
|
||||
withMoreThanMaxNumSegmentsCount == 0 &&
|
||||
i == (numObjs-1) {
|
||||
numSegments += maxNumOfSegments
|
||||
withMoreThanMaxNumSegmentsCount++
|
||||
}
|
||||
|
||||
if rand.Int()%2 == 0 {
|
||||
bucketName = fmt.Sprintf("bucket-%d", i)
|
||||
}
|
||||
objPath, objSegmentsProj := createNewObjectSegments(
|
||||
ctx, t, numSegments, &projID, bucketName, inline, withNumSegments,
|
||||
)
|
||||
testdata.objSegments = append(testdata.objSegments, objSegmentsProj...)
|
||||
|
||||
expectedObj := findOrCreate(bucketName, objPath, testdata.expectedObjects)
|
||||
|
||||
// only create segments mask if the number of segments is less or equal than
|
||||
// maxNumOfSegments + 1 because the last segment isn't in the bitmask
|
||||
if numSegments <= (maxNumOfSegments + 1) {
|
||||
// segments mask doesn't contain the last segment, hence we move 1 bit more
|
||||
expectedObj.segments = math.MaxUint64 >> (maxNumOfSegments - numSegments + 1)
|
||||
expectedObj.skip = false
|
||||
} else {
|
||||
expectedObj.skip = true
|
||||
}
|
||||
|
||||
// If withoutLastSegment is true, then choose random objects without last
|
||||
// segment or force to remove it from the object generated in the last
|
||||
// iteration if in any object of the previous iterations have the last
|
||||
// segment
|
||||
if withoutLastSegment &&
|
||||
((rand.Int()%2) == 0 || (i == (numObjs-1) && withoutLastSegmentCount == 0)) {
|
||||
withoutLastSegmentCount++
|
||||
expectedObj.hasLastSegment = false
|
||||
numSegments--
|
||||
testdata.objSegments = testdata.objSegments[:len(testdata.objSegments)-1]
|
||||
testdata.expectedRemoteSegments += numSegments
|
||||
} else {
|
||||
expectedObj.hasLastSegment = true
|
||||
|
||||
if inline {
|
||||
testdata.expectedInlineSegments++
|
||||
testdata.expectedRemoteSegments += (numSegments - 1)
|
||||
} else {
|
||||
testdata.expectedRemoteSegments += numSegments
|
||||
}
|
||||
|
||||
if withNumSegments {
|
||||
expectedObj.expectedNumberOfSegments = byte(numSegments)
|
||||
}
|
||||
}
|
||||
|
||||
testdata.expectedNumSegments += numSegments
|
||||
}
|
||||
|
||||
// Shuffle the segments for not having a object segments serial order
|
||||
rand.Shuffle(len(testdata.objSegments), func(i, j int) {
|
||||
testdata.objSegments[i], testdata.objSegments[j] = testdata.objSegments[j], testdata.objSegments[i]
|
||||
})
|
||||
|
||||
return testdata
|
||||
}
|
||||
|
||||
// assertObserver assert the observer values with the testdata ones.
|
||||
func assertObserver(t *testing.T, obsvr *observer, testdata testdataObjects) {
|
||||
t.Helper()
|
||||
|
||||
assert.Equal(t, testdata.projectID.String(), obsvr.lastProjectID, "lastProjectID")
|
||||
if assert.Equal(t, len(testdata.expectedObjects), len(obsvr.objects), "objects number") {
|
||||
for bucket, bucketObjs := range obsvr.objects {
|
||||
expBucketObjs, ok := testdata.expectedObjects[bucket]
|
||||
if !assert.Truef(t, ok, "bucket '%s' shouldn't exist in objects map", bucket) {
|
||||
continue
|
||||
}
|
||||
|
||||
if !assert.Equalf(t, len(expBucketObjs), len(bucketObjs), "objects per bucket (%s) number", bucket) {
|
||||
continue
|
||||
}
|
||||
|
||||
for expPath, expObj := range expBucketObjs {
|
||||
if !assert.Contains(t, bucketObjs, expPath, "path in bucket objects map") {
|
||||
continue
|
||||
}
|
||||
|
||||
obj := bucketObjs[expPath]
|
||||
assert.Equal(t, expObj.expectedNumberOfSegments, obj.expectedNumberOfSegments, "Object.expectedNumSegments")
|
||||
assert.Equal(t, expObj.hasLastSegment, obj.hasLastSegment, "Object.hasLastSegment")
|
||||
assert.Equal(t, expObj.skip, obj.skip, "Object.skip")
|
||||
|
||||
if !expObj.skip {
|
||||
assert.Equal(t, expObj.segments, obj.segments, "Object.segments")
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
Loading…
Reference in New Issue
Block a user