satellite/admin: update geofence endpoints to follow response conventions

Change-Id: Ieff91c16f91f9720e9c3d8ead0e13c47651d23f5

satellite/admin/README.md

@@ -8,6 +8,7 @@ Requires setting `Authorization` header for requests.
 <!-- toc -->
 - [satellite/admin](#satelliteadmin)
     * [API design](#api-design)
+        * [Successful responses](#successful-responses)
         * [Error responses](#error-responses)
     * [API Endpoints](#api-endpoints)
         * [User Management](#user-management)
@@ -42,6 +43,11 @@ Requires setting `Authorization` header for requests.
 
 ## API design
 
+### Successful responses
+
+For non-get requests (`PUT`, `POST`, `DELETE`), endpoints should return an empty response body on success. `GET`
+requests can return a non-empty body for the resource that we're interacting with.
+
 ### Error responses
 
 When an API endpoint returns a client error (status code 4XX) it returns a JSON error response which contains 2 fields:

satellite/admin/bucket.go

@@ -74,7 +74,7 @@ func (server *Server) updateBucket(w http.ResponseWriter, r *http.Request, place
 
 	b.Placement = placement
 
-	b, err = server.buckets.UpdateBucket(ctx, b)
+	_, err = server.buckets.UpdateBucket(ctx, b)
 	if err != nil {
 		switch {
 		case storj.ErrBucketNotFound.Has(err):
@@ -87,12 +87,7 @@ func (server *Server) updateBucket(w http.ResponseWriter, r *http.Request, place
 		return
 	}
 
-	data, err := json.Marshal(b)
+	w.WriteHeader(http.StatusOK)
-	if err != nil {
-		sendJSONError(w, "failed to marshal bucket", err.Error(), http.StatusInternalServerError)
-	} else {
-		sendJSONData(w, http.StatusOK, data)
-	}
 }
 
 func (server *Server) createGeofenceForBucket(w http.ResponseWriter, r *http.Request) {

satellite/admin/ui/src/lib/api.ts

@@ -49,8 +49,11 @@ export class Admin {
 					['Project ID', new InputText('text', true)],
 					['Bucket name', new InputText('text', true)]
 				],
-				func: async (projectId: string, bucketName: string): Promise<Record<string, unknown>> => {
+				func: async (projectId: string, bucketName: string): Promise<null> => {
-					return this.fetch('DELETE', `projects/${projectId}/buckets/${bucketName}/geofence`);
+					return this.fetch(
+						'DELETE',
+						`projects/${projectId}/buckets/${bucketName}/geofence`
+					) as Promise<null>;
 				}
 			},
 			{
@@ -69,17 +72,17 @@ export class Admin {
 						])
 					]
 				],
-				func: async (
+				func: async (projectId: string, bucketName: string, region: string): Promise<null> => {
-					projectId: string,
-					bucketName: string,
-					region: string
-				): Promise<Record<string, unknown>> => {
 					const query = this.urlQueryFromObject({ region });
 					if (query === '') {
 						throw new APIError('region cannot be empty');
 					}
 
-					return this.fetch('POST', `projects/${projectId}/buckets/${bucketName}/geofence`, query);
+					return this.fetch(
+						'POST',
+						`projects/${projectId}/buckets/${bucketName}/geofence`,
+						query
+					) as Promise<null>;
 				}
 			}
 		],