From b3675c14d489aef1369f788ad13f5f2639a350e9 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?M=C3=A1rton=20Elek?= Date: Wed, 2 Mar 2022 15:31:50 +0100 Subject: [PATCH] repairer: log piece id in case of a repair error Change-Id: Ia8da2da491a6674f669e62148fa42538278119ba --- satellite/repair/repairer/ec.go | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/satellite/repair/repairer/ec.go b/satellite/repair/repairer/ec.go index 479969de1..0c227ad4f 100644 --- a/satellite/repair/repairer/ec.go +++ b/satellite/repair/repairer/ec.go @@ -155,7 +155,9 @@ func (ec *ECRepairer) Get(ctx context.Context, limits []*pb.AddressedOrderLimit, // gather nodes where the calculated piece hash doesn't match the uplink signed piece hash if ErrPieceHashVerifyFailed.Has(err) { - ec.log.Info("audit failed", zap.Stringer("node ID", limit.GetLimit().StorageNodeId), + ec.log.Info("audit failed", + zap.Stringer("node ID", limit.GetLimit().StorageNodeId), + zap.Stringer("Piece ID", limit.Limit.PieceId), zap.String("reason", err.Error())) pieces.Failed = append(pieces.Failed, piece) return @@ -166,24 +168,28 @@ func (ec *ECRepairer) Get(ctx context.Context, limits []*pb.AddressedOrderLimit, case audit.PieceAuditFailure: ec.log.Debug("Failed to download pieces for repair: piece not found (audit failed)", zap.Stringer("Node ID", limit.GetLimit().StorageNodeId), + zap.Stringer("Piece ID", limit.Limit.PieceId), zap.Error(err)) pieces.Failed = append(pieces.Failed, piece) case audit.PieceAuditOffline: ec.log.Debug("Failed to download pieces for repair: dial timeout (offline)", zap.Stringer("Node ID", limit.GetLimit().StorageNodeId), + zap.Stringer("Piece ID", limit.Limit.PieceId), zap.Error(err)) pieces.Offline = append(pieces.Offline, piece) case audit.PieceAuditContained: ec.log.Info("Failed to download pieces for repair: download timeout (contained)", zap.Stringer("Node ID", limit.GetLimit().StorageNodeId), + zap.Stringer("Piece ID", limit.Limit.PieceId), zap.Error(err)) pieces.Contained = append(pieces.Contained, piece) case audit.PieceAuditUnknown: ec.log.Info("Failed to download pieces for repair: unknown transport error (skipped)", zap.Stringer("Node ID", limit.GetLimit().StorageNodeId), + zap.Stringer("Piece ID", limit.Limit.PieceId), zap.Error(err)) pieces.Unknown = append(pieces.Unknown, piece) }