JakeHillion/storj
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

satellite/metabase: add tests to UpdateMetadata for versioning

Browse Source 
Change-Id: I4503f92b19212e7c4cf1907edd7e529ff75cca3e
This commit is contained in:
dlamarmorgan 2023-10-25 16:16:34 -07:00 committed by Egon Elbre
parent 8be7414a52
commit aeec4bd213
2 changed files with 302 additions and 73 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
satellite/metabase/metabasetest/create.go
View File

@ -42,8 +42,8 @@ func RandEncryptedKeyAndNonce(position int) metabase.EncryptedKeyAndNonce {
}
// CreatePendingObject creates a new pending object with the specified number of segments.
func CreatePendingObject(ctx *testcontext.Context, t testing.TB, db *metabase.DB, obj metabase.ObjectStream, numberOfSegments byte) {
BeginObjectExactVersion{
func CreatePendingObject(ctx *testcontext.Context, t testing.TB, db *metabase.DB, obj metabase.ObjectStream, numberOfSegments byte) metabase.Object {
object := BeginObjectExactVersion{
Opts: metabase.BeginObjectExactVersion{
ObjectStream: obj,
Encryption: DefaultEncryption,
@ -51,6 +51,7 @@ func CreatePendingObject(ctx *testcontext.Context, t testing.TB, db *metabase.DB
}.Check(ctx, t, db)
CreateSegments(ctx, t, db, obj, nil, numberOfSegments)
return object
}
// CreatePendingObjectNew creates a new pending object with the specified number of segments.

370
satellite/metabase/metadata_test.go
View File

@ -17,9 +17,6 @@ import (
func TestUpdateObjectLastCommittedMetadata(t *testing.T) {
metabasetest.Run(t, func(ctx *testcontext.Context, t *testing.T, db *metabase.DB) {
obj := metabasetest.RandObjectStream()
now := time.Now()
zombieDeadline := now.Add(24 * time.Hour)
for _, test := range metabasetest.InvalidObjectLocations(obj.Location()) {
test := test
t.Run(test.Name, func(t *testing.T) {
@ -39,6 +36,8 @@ func TestUpdateObjectLastCommittedMetadata(t *testing.T) {
t.Run("StreamID missing", func(t *testing.T) {
defer metabasetest.DeleteAll{}.Check(ctx, t, db)
obj := metabasetest.RandObjectStream()
metabasetest.UpdateObjectLastCommittedMetadata{
Opts: metabase.UpdateObjectLastCommittedMetadata{
ProjectID: obj.ProjectID,
@ -55,6 +54,7 @@ func TestUpdateObjectLastCommittedMetadata(t *testing.T) {
t.Run("Metadata missing", func(t *testing.T) {
defer metabasetest.DeleteAll{}.Check(ctx, t, db)
obj := metabasetest.RandObjectStream()
metabasetest.UpdateObjectLastCommittedMetadata{
Opts: metabase.UpdateObjectLastCommittedMetadata{
ProjectID: obj.ProjectID,
@ -71,23 +71,13 @@ func TestUpdateObjectLastCommittedMetadata(t *testing.T) {
t.Run("Update metadata", func(t *testing.T) {
defer metabasetest.DeleteAll{}.Check(ctx, t, db)
metabasetest.CreateTestObject{}.Run(ctx, t, db, obj, 0)
obj := metabasetest.RandObjectStream()
object := metabasetest.CreateObject(ctx, t, db, obj, 0)
encryptedMetadata := testrand.Bytes(1024)
encryptedMetadataNonce := testrand.Nonce()
encryptedMetadataKey := testrand.Bytes(265)
metabasetest.Verify{
Objects: []metabase.RawObject{
{
ObjectStream: obj,
CreatedAt: now,
Status: metabase.CommittedUnversioned,
Encryption: metabasetest.DefaultEncryption,
},
},
}.Check(ctx, t, db)
metabasetest.UpdateObjectLastCommittedMetadata{
Opts: metabase.UpdateObjectLastCommittedMetadata{
ProjectID: obj.ProjectID,
@ -100,18 +90,13 @@ func TestUpdateObjectLastCommittedMetadata(t *testing.T) {
},
}.Check(ctx, t, db)
object.EncryptedMetadata = encryptedMetadata
object.EncryptedMetadataNonce = encryptedMetadataNonce[:]
object.EncryptedMetadataEncryptedKey = encryptedMetadataKey
metabasetest.Verify{
Objects: []metabase.RawObject{
{
ObjectStream: obj,
CreatedAt: now,
Status: metabase.CommittedUnversioned,
Encryption: metabasetest.DefaultEncryption,
EncryptedMetadata: encryptedMetadata,
EncryptedMetadataNonce: encryptedMetadataNonce[:],
EncryptedMetadataEncryptedKey: encryptedMetadataKey,
},
metabase.RawObject(object),
},
}.Check(ctx, t, db)
})
@ -119,71 +104,314 @@ func TestUpdateObjectLastCommittedMetadata(t *testing.T) {
t.Run("Update metadata with version != 1", func(t *testing.T) {
defer metabasetest.DeleteAll{}.Check(ctx, t, db)
newObj := metabasetest.RandObjectStream()
metabasetest.CreatePendingObject(ctx, t, db, newObj, 0)
obj := metabasetest.RandObjectStream()
object := metabasetest.CreatePendingObject(ctx, t, db, obj, 0)
newObjDiffVersion := newObj
newObjDiffVersion.Version = newObj.Version + 10000
metabasetest.CreateTestObject{}.Run(ctx, t, db, newObjDiffVersion, 0)
obj2 := obj
obj2.Version++
object2 := metabasetest.CreateObject(ctx, t, db, obj2, 0)
encryptedMetadata := testrand.Bytes(1024)
encryptedMetadataNonce := testrand.Nonce()
encryptedMetadataKey := testrand.Bytes(265)
metabasetest.Verify{
Objects: []metabase.RawObject{
{
ObjectStream: newObj,
CreatedAt: now,
Status: metabase.Pending,
Encryption: metabasetest.DefaultEncryption,
ZombieDeletionDeadline: &zombieDeadline,
},
{
ObjectStream: newObjDiffVersion,
CreatedAt: now,
Status: metabase.CommittedUnversioned,
Encryption: metabasetest.DefaultEncryption,
},
},
}.Check(ctx, t, db)
metabasetest.UpdateObjectLastCommittedMetadata{
Opts: metabase.UpdateObjectLastCommittedMetadata{
ProjectID: newObj.ProjectID,
BucketName: newObj.BucketName,
ObjectKey: newObj.ObjectKey,
StreamID: newObj.StreamID,
ProjectID: object2.ProjectID,
BucketName: object2.BucketName,
ObjectKey: object2.ObjectKey,
StreamID: object2.StreamID,
EncryptedMetadata: encryptedMetadata,
EncryptedMetadataNonce: encryptedMetadataNonce[:],
EncryptedMetadataEncryptedKey: encryptedMetadataKey,
},
}.Check(ctx, t, db)
object2.EncryptedMetadata = encryptedMetadata
object2.EncryptedMetadataNonce = encryptedMetadataNonce[:]
object2.EncryptedMetadataEncryptedKey = encryptedMetadataKey
metabasetest.Verify{
Objects: []metabase.RawObject{
{
ObjectStream: newObj,
CreatedAt: now,
Status: metabase.Pending,
Encryption: metabasetest.DefaultEncryption,
ZombieDeletionDeadline: &zombieDeadline,
},
{
ObjectStream: newObjDiffVersion,
CreatedAt: now,
Status: metabase.CommittedUnversioned,
Encryption: metabasetest.DefaultEncryption,
EncryptedMetadata: encryptedMetadata,
EncryptedMetadataNonce: encryptedMetadataNonce[:],
EncryptedMetadataEncryptedKey: encryptedMetadataKey,
},
metabase.RawObject(object),
metabase.RawObject(object2),
},
}.Check(ctx, t, db)
})
// TODO(ver): add tests for committed/deletemarker versioned/unversioned
// TODO(ver): check that we cannot add metadata to a delete marker
t.Run("update metadata of versioned object", func(t *testing.T) {
defer metabasetest.DeleteAll{}.Check(ctx, t, db)
obj := metabasetest.RandObjectStream()
object := metabasetest.CreateObjectVersioned(ctx, t, db, obj, 0)
encryptedMetadata := testrand.Bytes(1024)
encryptedMetadataNonce := testrand.Nonce()
encryptedMetadataKey := testrand.Bytes(265)
metabasetest.UpdateObjectLastCommittedMetadata{
Opts: metabase.UpdateObjectLastCommittedMetadata{
ProjectID: object.ProjectID,
BucketName: object.BucketName,
ObjectKey: object.ObjectKey,
StreamID: object.StreamID,
EncryptedMetadata: encryptedMetadata,
EncryptedMetadataNonce: encryptedMetadataNonce[:],
EncryptedMetadataEncryptedKey: encryptedMetadataKey,
},
}.Check(ctx, t, db)
object.EncryptedMetadata = encryptedMetadata
object.EncryptedMetadataNonce = encryptedMetadataNonce[:]
object.EncryptedMetadataEncryptedKey = encryptedMetadataKey
metabasetest.Verify{
Objects: []metabase.RawObject{
metabase.RawObject(object),
},
}.Check(ctx, t, db)
})
t.Run("update metadata of versioned delete marker", func(t *testing.T) {
defer metabasetest.DeleteAll{}.Check(ctx, t, db)
obj := metabasetest.RandObjectStream()
object := metabasetest.CreateObjectVersioned(ctx, t, db, obj, 0)
encryptedMetadata := testrand.Bytes(1024)
encryptedMetadataNonce := testrand.Nonce()
encryptedMetadataKey := testrand.Bytes(265)
marker := metabase.Object{
ObjectStream: object.ObjectStream,
Status: metabase.DeleteMarkerVersioned,
CreatedAt: time.Now(),
}
marker.StreamID = uuid.UUID{}
marker.Version++
metabasetest.DeleteObjectLastCommitted{
Opts: metabase.DeleteObjectLastCommitted{
ObjectLocation: object.Location(),
Versioned: true,
},
Result: metabase.DeleteObjectResult{
Markers: []metabase.Object{marker},
},
}.Check(ctx, t, db)
// verify we cannot update the metadata of a deleted object
metabasetest.UpdateObjectLastCommittedMetadata{
Opts: metabase.UpdateObjectLastCommittedMetadata{
ProjectID: object.ProjectID,
BucketName: object.BucketName,
ObjectKey: object.ObjectKey,
StreamID: object.StreamID,
EncryptedMetadata: encryptedMetadata,
EncryptedMetadataNonce: encryptedMetadataNonce[:],
EncryptedMetadataEncryptedKey: encryptedMetadataKey,
},
ErrClass: &metabase.ErrObjectNotFound,
ErrText: "object with specified version and committed status is missing",
}.Check(ctx, t, db)
// verify cannot update the metadata of the delete marker either
metabasetest.UpdateObjectLastCommittedMetadata{
Opts: metabase.UpdateObjectLastCommittedMetadata{
ProjectID: marker.ProjectID,
BucketName: marker.BucketName,
ObjectKey: marker.ObjectKey,
StreamID: marker.StreamID,
EncryptedMetadata: encryptedMetadata,
EncryptedMetadataNonce: encryptedMetadataNonce[:],
EncryptedMetadataEncryptedKey: encryptedMetadataKey,
},
ErrClass: &metabase.ErrInvalidRequest,
ErrText: "StreamID missing",
}.Check(ctx, t, db)
metabasetest.Verify{
Objects: []metabase.RawObject{
metabase.RawObject(object),
metabase.RawObject(marker),
},
}.Check(ctx, t, db)
})
t.Run("update metadata of unversioned delete marker", func(t *testing.T) {
defer metabasetest.DeleteAll{}.Check(ctx, t, db)
obj := metabasetest.RandObjectStream()
object := metabasetest.CreateObjectVersioned(ctx, t, db, obj, 0)
obj2 := obj
obj2.Version++
object2 := metabasetest.CreateObject(ctx, t, db, obj2, 0)
marker := metabase.Object{
ObjectStream: object2.ObjectStream,
Status: metabase.DeleteMarkerUnversioned,
CreatedAt: time.Now(),
}
marker.Version++
marker.StreamID = uuid.UUID{}
metabasetest.DeleteObjectLastCommitted{
Opts: metabase.DeleteObjectLastCommitted{
ObjectLocation: object2.Location(),
Versioned: false,
Suspended: true,
},
Result: metabase.DeleteObjectResult{
Markers: []metabase.Object{marker},
Removed: []metabase.Object{object2},
},
}.Check(ctx, t, db)
encryptedMetadata := testrand.Bytes(1024)
encryptedMetadataNonce := testrand.Nonce()
encryptedMetadataKey := testrand.Bytes(265)
// verify we cannot update the metadata of a deleted object
metabasetest.UpdateObjectLastCommittedMetadata{
Opts: metabase.UpdateObjectLastCommittedMetadata{
ProjectID: object2.ProjectID,
BucketName: object2.BucketName,
ObjectKey: object2.ObjectKey,
StreamID: object2.StreamID,
EncryptedMetadata: encryptedMetadata,
EncryptedMetadataNonce: encryptedMetadataNonce[:],
EncryptedMetadataEncryptedKey: encryptedMetadataKey,
},
ErrClass: &metabase.ErrObjectNotFound,
ErrText: "object with specified version and committed status is missing",
}.Check(ctx, t, db)
// verify cannot update the metadata of the delete marker either
metabasetest.UpdateObjectLastCommittedMetadata{
Opts: metabase.UpdateObjectLastCommittedMetadata{
ProjectID: marker.ProjectID,
BucketName: marker.BucketName,
ObjectKey: marker.ObjectKey,
StreamID: marker.StreamID,
EncryptedMetadata: encryptedMetadata,
EncryptedMetadataNonce: encryptedMetadataNonce[:],
EncryptedMetadataEncryptedKey: encryptedMetadataKey,
},
ErrClass: &metabase.ErrInvalidRequest,
ErrText: "StreamID missing",
}.Check(ctx, t, db)
metabasetest.Verify{
Objects: []metabase.RawObject{
metabase.RawObject(object),
metabase.RawObject(marker),
},
}.Check(ctx, t, db)
})
t.Run("update metadata of versioned object with previous delete marker", func(t *testing.T) {
defer metabasetest.DeleteAll{}.Check(ctx, t, db)
obj := metabasetest.RandObjectStream()
object := metabasetest.CreateObjectVersioned(ctx, t, db, obj, 0)
marker := metabase.Object{
ObjectStream: object.ObjectStream,
Status: metabase.DeleteMarkerVersioned,
CreatedAt: time.Now(),
}
marker.StreamID = uuid.UUID{}
marker.Version++
metabasetest.DeleteObjectLastCommitted{
Opts: metabase.DeleteObjectLastCommitted{
ObjectLocation: object.Location(),
Versioned: true,
},
Result: metabase.DeleteObjectResult{
Markers: []metabase.Object{marker},
},
}.Check(ctx, t, db)
obj2 := obj
obj2.StreamID = testrand.UUID()
obj2.Version = marker.Version + 1
object2 := metabasetest.CreateObjectVersioned(ctx, t, db, obj2, 0)
encryptedMetadata := testrand.Bytes(1024)
encryptedMetadataNonce := testrand.Nonce()
encryptedMetadataKey := testrand.Bytes(265)
metabasetest.UpdateObjectLastCommittedMetadata{
Opts: metabase.UpdateObjectLastCommittedMetadata{
ProjectID: object2.ProjectID,
BucketName: object2.BucketName,
ObjectKey: object2.ObjectKey,
StreamID: object2.StreamID,
EncryptedMetadata: encryptedMetadata,
EncryptedMetadataNonce: encryptedMetadataNonce[:],
EncryptedMetadataEncryptedKey: encryptedMetadataKey,
},
}.Check(ctx, t, db)
object2.EncryptedMetadata = encryptedMetadata
object2.EncryptedMetadataNonce = encryptedMetadataNonce[:]
object2.EncryptedMetadataEncryptedKey = encryptedMetadataKey
metabasetest.Verify{
Objects: []metabase.RawObject{
metabase.RawObject(object),
metabase.RawObject(marker),
metabase.RawObject(object2),
},
}.Check(ctx, t, db)
})
t.Run("update metadata of unversioned object with previous version", func(t *testing.T) {
defer metabasetest.DeleteAll{}.Check(ctx, t, db)
obj := metabasetest.RandObjectStream()
object := metabasetest.CreateObjectVersioned(ctx, t, db, obj, 0)
obj2 := obj
obj2.StreamID = testrand.UUID()
obj2.Version = obj.Version + 1
object2 := metabasetest.CreateObjectVersioned(ctx, t, db, obj2, 0)
obj3 := obj
obj3.StreamID = testrand.UUID()
obj3.Version = obj2.Version + 1
object3 := metabasetest.CreateObject(ctx, t, db, obj3, 0)
encryptedMetadata := testrand.Bytes(1024)
encryptedMetadataNonce := testrand.Nonce()
encryptedMetadataKey := testrand.Bytes(265)
metabasetest.UpdateObjectLastCommittedMetadata{
Opts: metabase.UpdateObjectLastCommittedMetadata{
ProjectID: object3.ProjectID,
BucketName: object3.BucketName,
ObjectKey: object3.ObjectKey,
StreamID: object3.StreamID,
EncryptedMetadata: encryptedMetadata,
EncryptedMetadataNonce: encryptedMetadataNonce[:],
EncryptedMetadataEncryptedKey: encryptedMetadataKey,
},
}.Check(ctx, t, db)
object3.EncryptedMetadata = encryptedMetadata
object3.EncryptedMetadataNonce = encryptedMetadataNonce[:]
object3.EncryptedMetadataEncryptedKey = encryptedMetadataKey
metabasetest.Verify{
Objects: []metabase.RawObject{
metabase.RawObject(object),
metabase.RawObject(object2),
metabase.RawObject(object3),
},
}.Check(ctx, t, db)
})
})
}