JakeHillion/storj
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

cmd/uplink: use tracing.enabled flag

Browse Source 
Previously we are using tracing.sampled to be the switch for turning on/off tracing.
However we would like to separate sampling rate from being the switch,
so we can set sampling rate to be 0 but still intialize tracing for
satellite and storagenodes

Change-Id: I27e6ba25ea6f6b612b4e1a57cf1301889ded41ec
This commit is contained in:
Yingrong Zhao 2020-04-24 14:09:59 -04:00 committed by Yingrong Zhao
parent ef913be234
commit 9b4a3f8fcc
4 changed files with 16 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
cmd/uplink/cmd/common.go
View File

@ -27,5 +27,5 @@ func withTelemetry(cmd *cobra.Command) (context.Context, context.CancelFunc) {
}
func enableTracing(config map[string]interface{}) {
config["tracing.sample"] = 1
config["tracing.enabled"] = true
}

8
go.mod
View File

@ -25,7 +25,7 @@ require (
github.com/nsf/termbox-go v0.0.0-20190121233118-02980233997d
github.com/shopspring/decimal v0.0.0-20200105231215-408a2507e114
github.com/sirupsen/logrus v1.4.2 // indirect
github.com/spacemonkeygo/monkit/v3 v3.0.6-0.20200417171149-7f4a2b305c34
github.com/spacemonkeygo/monkit/v3 v3.0.6
github.com/spf13/cast v1.3.0
github.com/spf13/cobra v0.0.6
github.com/spf13/pflag v1.0.5
@ -41,9 +41,9 @@ require (
golang.org/x/sys v0.0.0-20200202164722-d101bd2416d5
golang.org/x/time v0.0.0-20191024005414-555d28b269f0
google.golang.org/grpc v1.28.0
storj.io/common v0.0.0-20200424145118-a435ff00192e
storj.io/common v0.0.0-20200424175742-65ac59022f4f
storj.io/drpc v0.0.12-0.20200413163255-debb458a7474
storj.io/monkit-jaeger v0.0.0-20200421202833-be94db601895
storj.io/private v0.0.0-20200421205950-b0446725b807
storj.io/monkit-jaeger v0.0.0-20200424180155-d5f5530ea079
storj.io/private v0.0.0-20200427160924-e00b0e612cfb
storj.io/uplink v1.0.4
)

15
go.sum
View File

@ -342,6 +342,8 @@ github.com/spacemonkeygo/monkit/v3 v3.0.5 h1:vMW8Ne6WAUU/OMYaSv7KGW9h/sRNgeh6TyB
github.com/spacemonkeygo/monkit/v3 v3.0.5/go.mod h1:JcK1pCbReQsOsMKF/POFSZCq7drXFybgGmbc27tuwes=
github.com/spacemonkeygo/monkit/v3 v3.0.6-0.20200417171149-7f4a2b305c34 h1:N6DG0i/Qa4+iTVy6rMJ0YpiadnR6VEHi7KvekQ5I1cU=
github.com/spacemonkeygo/monkit/v3 v3.0.6-0.20200417171149-7f4a2b305c34/go.mod h1:kj1ViJhlyADa7DiA4xVnTuPA46lFKbM7mxQTrXCuJP4=
github.com/spacemonkeygo/monkit/v3 v3.0.6 h1:BKPrEaLokVAxlwHkD7jawViBa/IU9/bgXbZLWgjbdSM=
github.com/spacemonkeygo/monkit/v3 v3.0.6/go.mod h1:kj1ViJhlyADa7DiA4xVnTuPA46lFKbM7mxQTrXCuJP4=
github.com/spacemonkeygo/monotime v0.0.0-20180824235756-e3f48a95f98a h1:8+cCjxhToanKmxLIbuyBNe2EnpgwhiivsIaRJstDRFA=
github.com/spacemonkeygo/monotime v0.0.0-20180824235756-e3f48a95f98a/go.mod h1:ul4bvvnCOPZgq8w0nTkSmWVg/hauVpFS97Am1YM1XXo=
github.com/spacemonkeygo/spacelog v0.0.0-20180420211403-2296661a0572 h1:RC6RW7j+1+HkWaX/Yh71Ee5ZHaHYt7ZP4sQgUrm6cDU=
@ -624,20 +626,19 @@ honnef.co/go/tools v0.0.0-20190523083050-ea95bdfd59fc/go.mod h1:rf3lG4BRIbNafJWh
honnef.co/go/tools v0.0.1-2019.2.3 h1:3JgtbtFHMiCmsznwGVTUWbgGov+pVqnlf1dEJTNAXeM=
honnef.co/go/tools v0.0.1-2019.2.3/go.mod h1:a3bituU0lyd329TUQxRnasdCoJDkEUEAqEt0JzvZhAg=
rsc.io/binaryregexp v0.2.0/go.mod h1:qTv7/COck+e2FymRvadv62gMdZztPaShugOCi3I+8D8=
storj.io/common v0.0.0-20200420155406-c7673e5d3216/go.mod h1:pZyXiIE7bGETIRXtfs0nICqMwp7PM8HqnDuyUeldNA0=
storj.io/common v0.0.0-20200423123959-c1b3f92807ea h1:TV7/Do6oYxdVOnp43nPyFmxxKHbWobjDc6k42zXvrx0=
storj.io/common v0.0.0-20200423123959-c1b3f92807ea/go.mod h1:pZyXiIE7bGETIRXtfs0nICqMwp7PM8HqnDuyUeldNA0=
storj.io/common v0.0.0-20200424145118-a435ff00192e h1:QgNfhCMQX4l5020zHmmpKaGtxeN3cXv3ahLGRvt2jFE=
storj.io/common v0.0.0-20200424145118-a435ff00192e/go.mod h1:pZyXiIE7bGETIRXtfs0nICqMwp7PM8HqnDuyUeldNA0=
storj.io/common v0.0.0-20200424175742-65ac59022f4f h1:HPRWr2HQzPD12vhHIaYhh9HT0vYlULkqA453YEV/BXU=
storj.io/common v0.0.0-20200424175742-65ac59022f4f/go.mod h1:pZyXiIE7bGETIRXtfs0nICqMwp7PM8HqnDuyUeldNA0=
storj.io/drpc v0.0.11 h1:6vLxfpSbwCLtqzAoXzXx/SxBqBtbzbmquXPqfcWKqfw=
storj.io/drpc v0.0.11 h1:6vLxfpSbwCLtqzAoXzXx/SxBqBtbzbmquXPqfcWKqfw=
storj.io/drpc v0.0.11/go.mod h1:TiFc2obNjL9/3isMW1Rpxjy8V9uE0B2HMeMFGiiI7Iw=
storj.io/drpc v0.0.11/go.mod h1:TiFc2obNjL9/3isMW1Rpxjy8V9uE0B2HMeMFGiiI7Iw=
storj.io/drpc v0.0.12-0.20200413163255-debb458a7474 h1:ToKfIf2Lyz5/cEeoqdeL3xydqUhU2tWRYvsCB3aXsuY=
storj.io/drpc v0.0.12-0.20200413163255-debb458a7474/go.mod h1:82nfl+6YwRwF6UG31cEWWUqv/FaKvP5SGqUvoqTxCMA=
storj.io/monkit-jaeger v0.0.0-20200421202833-be94db601895 h1:Fn3M3BlFVRirzTS6ewbxjF6GLcylvm3n+UO6s5nPW38=
storj.io/monkit-jaeger v0.0.0-20200421202833-be94db601895/go.mod h1:5waizKsXtoLwcWJhKyeSiWS3K8yFz+sbOpN+wDFJVm8=
storj.io/private v0.0.0-20200421205950-b0446725b807 h1:OVP5g1tdj2UghHARlywTJRJES0TJwTOxBEXDTLjsZ28=
storj.io/private v0.0.0-20200421205950-b0446725b807/go.mod h1:+15lqp0koVNCU5Grlvzo2bwsAVBkZi2sc5koBHAxBbU=
storj.io/monkit-jaeger v0.0.0-20200424180155-d5f5530ea079 h1:m9929nD0RNuCN4defscZYf1tOOr+vDyW5lBv1z8LI04=
storj.io/monkit-jaeger v0.0.0-20200424180155-d5f5530ea079/go.mod h1:aqJsyh+eR2wm8JFSTSCBWwvOBI9TgTBzb/uZOWJZ9K0=
storj.io/private v0.0.0-20200427160924-e00b0e612cfb h1:KSeSkZE79XmpnWx5HMSYjJbjvsaVWt7ppu05Nce4jF8=
storj.io/private v0.0.0-20200427160924-e00b0e612cfb/go.mod h1:fU2XXdFHiWincQagQjvIfE2+ge9JMAcQAeYqiEXb7ZM=
storj.io/uplink v1.0.4 h1:ydQ9MMtjWhkDA8NH5ikFLVTg52w4HpHqDi2QPvTKQpA=
storj.io/uplink v1.0.4/go.mod h1:CqC3eFfAAliZABx2jjjnavvypKrW66KRNkBJsouLGIE=

3
scripts/testdata/satellite-config.yaml.lock vendored
View File

@ -603,6 +603,9 @@ server.private-address: 127.0.0.1:7778
# buffer size for collector batch packet size
# tracing.buffer-size: 0
# whether tracing collector is enabled
# tracing.enabled: false
# how frequently to flush traces to tracing agent
# tracing.interval: 0s