From 958d8676d0212581b934032776d1d49216dda210 Mon Sep 17 00:00:00 2001 From: paul cannon Date: Tue, 16 May 2023 15:50:21 -0500 Subject: [PATCH] satellite/overlay: remove unnecessary test helper Change-Id: I8439eec4ed440f60353fc620ca906a917a03613c --- satellite/overlay/service.go | 5 ----- satellite/repair/checker/observer_test.go | 4 ++-- satellite/repair/repair_test.go | 2 +- 3 files changed, 3 insertions(+), 8 deletions(-) diff --git a/satellite/overlay/service.go b/satellite/overlay/service.go index 695a81c37..e2e579900 100644 --- a/satellite/overlay/service.go +++ b/satellite/overlay/service.go @@ -932,11 +932,6 @@ func (service *Service) TestNodeCountryCode(ctx context.Context, nodeID storj.No return nil } -// TestRefreshUploadSelectionCache refreshes the upload selection cache. -func (service *Service) TestRefreshUploadSelectionCache(ctx context.Context) (err error) { - return service.UploadSelectionCache.Refresh(ctx) -} - func (service *Service) insertReputationNodeEvents(ctx context.Context, email string, id storj.NodeID, repEvents []nodeevents.Type) { defer mon.Task()(&ctx)(nil) diff --git a/satellite/repair/checker/observer_test.go b/satellite/repair/checker/observer_test.go index d5117a47c..c6ffd1a51 100644 --- a/satellite/repair/checker/observer_test.go +++ b/satellite/repair/checker/observer_test.go @@ -302,7 +302,7 @@ func TestCleanRepairQueueObserver(t *testing.T) { } require.NoError(t, observer.RefreshReliabilityCache(ctx)) - require.NoError(t, planet.Satellites[0].RangedLoop.Overlay.Service.TestRefreshUploadSelectionCache(ctx)) + require.NoError(t, planet.Satellites[0].RangedLoop.Overlay.Service.UploadSelectionCache.Refresh(ctx)) // check that repair queue is empty to avoid false positive count, err := repairQueue.Count(ctx) @@ -324,7 +324,7 @@ func TestCleanRepairQueueObserver(t *testing.T) { } require.NoError(t, observer.RefreshReliabilityCache(ctx)) - require.NoError(t, planet.Satellites[0].RangedLoop.Overlay.Service.TestRefreshUploadSelectionCache(ctx)) + require.NoError(t, planet.Satellites[0].RangedLoop.Overlay.Service.UploadSelectionCache.Refresh(ctx)) // The checker will not insert/update the now healthy segments causing // them to be removed from the queue at the end of the checker iteration diff --git a/satellite/repair/repair_test.go b/satellite/repair/repair_test.go index 60ce1853d..ab020f10e 100644 --- a/satellite/repair/repair_test.go +++ b/satellite/repair/repair_test.go @@ -3279,7 +3279,7 @@ func TestRepairClumpedPieces(t *testing.T) { } err = satellite.DB.OverlayCache().UpdateCheckIn(ctx, checkInInfo, time.Now().UTC(), overlay.NodeSelectionConfig{}) require.NoError(t, err) - err = satellite.RangedLoop.Overlay.Service.TestRefreshUploadSelectionCache(ctx) + err = satellite.RangedLoop.Overlay.Service.UploadSelectionCache.Refresh(ctx) require.NoError(t, err) // running repair checker again should put the segment into the repair queue