auto-updater: download versions and archive with binary (#2922)

This commit is contained in:
Michal Niewrzal 2019-09-05 23:10:05 +02:00 committed by GitHub
parent 6d363fb756
commit 587be8f206
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 215 additions and 2 deletions

View File

@ -4,16 +4,28 @@
package main
import (
"bufio"
"bytes"
"context"
"encoding/json"
"fmt"
"io"
"io/ioutil"
"log"
"net/http"
"os"
"os/exec"
"os/signal"
"runtime"
"strings"
"syscall"
"time"
"github.com/spf13/cobra"
"github.com/zeebo/errs"
"storj.io/storj/internal/sync2"
"storj.io/storj/internal/version"
)
var (
@ -39,6 +51,28 @@ var (
binaryLocation string
)
// Response response from version server.
type Response struct {
Processes Processes `json:"processes"`
}
// Processes describes versions for each binary.
type Processes struct {
Storagenode Process `json:"storagenode"`
}
// Process versions for specific binary.
type Process struct {
Minimum Version `json:"minimum"`
Suggested Version `json:"suggested"`
}
// Version represents version and download URL for binary.
type Version struct {
Version string `json:"version"`
URL string `json:"url"`
}
func init() {
rootCmd.AddCommand(runCmd)
@ -48,6 +82,10 @@ func init() {
}
func cmdRun(cmd *cobra.Command, args []string) (err error) {
if !fileExists(binaryLocation) {
return errs.New("unable to find storage node executable binary")
}
ctx, cancel := context.WithCancel(context.Background())
c := make(chan os.Signal, 1)
signal.Notify(c, syscall.SIGINT, syscall.SIGTERM)
@ -61,12 +99,53 @@ func cmdRun(cmd *cobra.Command, args []string) (err error) {
loopInterval, err := time.ParseDuration(interval)
if err != nil {
return fmt.Errorf("unable to parse interval parameter: %v", err)
return errs.New("unable to parse interval parameter: %v", err)
}
loop := sync2.NewCycle(loopInterval)
update := func(ctx context.Context) (err error) {
currentVersion, err := binaryVersion(binaryLocation)
if err != nil {
return err
}
log.Println("downloading versions from", versionURL)
suggestedVersion, downloadURL, err := suggestedVersion()
if err != nil {
return err
}
downloadURL = strings.Replace(downloadURL, "{os}", runtime.GOOS, 1)
downloadURL = strings.Replace(downloadURL, "{arch}", runtime.GOARCH, 1)
if currentVersion.Compare(suggestedVersion) < 0 {
tempArchive, err := ioutil.TempFile(os.TempDir(), "storagenode")
if err != nil {
return errs.New("cannot create temporary archive: %v", err)
}
defer func() { err = errs.Combine(err, os.Remove(tempArchive.Name())) }()
log.Println("start downloading", downloadURL, "to", tempArchive.Name())
err = downloadArchive(ctx, tempArchive, downloadURL)
if err != nil {
return err
}
log.Println("finished downloading", downloadURL, "to", tempArchive.Name())
// TODO next PRs
// * rename current binary into `storagenode.old.<release>.exe`.
// * unzip downloaded binary in place of current binary
// * compare extracted binary with version from suggested version
// * restart storage node service
}
return nil
}
err = loop.Run(ctx, func(ctx context.Context) (err error) {
fmt.Println("check new version")
if err := update(ctx); err != nil {
// don't finish loop in case of error just wait for another execution
log.Println(err)
}
return nil
})
if err != context.Canceled {
@ -75,6 +154,73 @@ func cmdRun(cmd *cobra.Command, args []string) (err error) {
return nil
}
func binaryVersion(location string) (version.SemVer, error) {
out, err := exec.Command(location, "version").Output()
if err != nil {
return version.SemVer{}, err
}
scanner := bufio.NewScanner(bytes.NewReader(out))
for scanner.Scan() {
line := scanner.Text()
prefix := "Version: "
if strings.HasPrefix(line, prefix) {
return version.NewSemVer(line[len(prefix):])
}
}
return version.SemVer{}, errs.New("unable to determine binary version")
}
func suggestedVersion() (ver version.SemVer, url string, err error) {
resp, err := http.Get(versionURL)
if err != nil {
return ver, url, err
}
defer func() { err = errs.Combine(err, resp.Body.Close()) }()
body, err := ioutil.ReadAll(resp.Body)
if err != nil {
return ver, url, err
}
var response Response
err = json.Unmarshal(body, &response)
if err != nil {
return ver, url, err
}
suggestedVersion := response.Processes.Storagenode.Suggested
ver, err = version.NewSemVer(suggestedVersion.Version)
if err != nil {
return ver, url, err
}
return ver, suggestedVersion.URL, nil
}
func downloadArchive(ctx context.Context, file io.Writer, url string) (err error) {
resp, err := http.Get(url)
if err != nil {
return err
}
defer func() { err = errs.Combine(err, resp.Body.Close()) }()
if resp.StatusCode != http.StatusOK {
return errs.New("bad status: %s", resp.Status)
}
_, err = sync2.Copy(ctx, file, resp.Body)
return err
}
func fileExists(filename string) bool {
info, err := os.Stat(filename)
if os.IsNotExist(err) {
return false
}
return info.Mode().IsRegular()
}
func main() {
_ = rootCmd.Execute()
}

View File

@ -93,6 +93,29 @@ func NewSemVer(v string) (sv SemVer, err error) {
return sv, nil
}
// Compare compare two versions, return -1 if compared version is greater, 0 if equal and 1 if less.
func (sem *SemVer) Compare(version SemVer) int {
result := sem.Major - version.Major
if result > 0 {
return 1
} else if result < 0 {
return -1
}
result = sem.Minor - version.Minor
if result > 0 {
return 1
} else if result < 0 {
return -1
}
result = sem.Patch - version.Patch
if result > 0 {
return 1
} else if result < 0 {
return -1
}
return 0
}
// String converts the SemVer struct to a more easy to handle string
func (sem *SemVer) String() (version string) {
return fmt.Sprintf("v%d.%d.%d", sem.Major, sem.Minor, sem.Patch)

View File

@ -0,0 +1,44 @@
// Copyright (C) 2019 Storj Labs, Inc.
// See LICENSE for copying information.
package version_test
import (
"testing"
"github.com/stretchr/testify/require"
"storj.io/storj/internal/version"
)
func TestSemVer_Compare(t *testing.T) {
version001, err := version.NewSemVer("v0.0.1")
require.NoError(t, err)
version002, err := version.NewSemVer("v0.0.2")
require.NoError(t, err)
version030, err := version.NewSemVer("v0.3.0")
require.NoError(t, err)
version040, err := version.NewSemVer("v0.4.0")
require.NoError(t, err)
version500, err := version.NewSemVer("v5.0.0")
require.NoError(t, err)
version600, err := version.NewSemVer("v6.0.0")
require.NoError(t, err)
// compare the same values
require.True(t, version001.Compare(version001) == 0)
require.True(t, version030.Compare(version030) == 0)
require.True(t, version500.Compare(version500) == 0)
require.True(t, version001.Compare(version002) < 0)
require.True(t, version030.Compare(version040) < 0)
require.True(t, version500.Compare(version600) < 0)
require.True(t, version001.Compare(version030) < 0)
require.True(t, version030.Compare(version500) < 0)
require.True(t, version002.Compare(version001) > 0)
require.True(t, version040.Compare(version030) > 0)
require.True(t, version600.Compare(version500) > 0)
require.True(t, version030.Compare(version002) > 0)
require.True(t, version600.Compare(version040) > 0)
}