JakeHillion/storj
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

satellite/orders: log bandwidth values we are dropping

Browse Source 
When we have problem with inserting bandwidth amounts into cache
or DB we are logging information about it but log entries are not
very detailed. This change adds bandwidth amounts to the log entry.

https://github.com/storj/storj/issues/5470

Change-Id: I55ccad837d17b141501d3def1dec7ad5f3acdb0b
This commit is contained in:
Michal Niewrzal 2023-01-19 10:26:27 +01:00 committed by Storj Robot
parent 8d69837f02
commit 4cbb1ed296
1 changed files with 20 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
satellite/orders/rollups_write_cache.go
View File

@ -147,7 +147,18 @@ func (cache *RollupsWriteCache) flush(ctx context.Context, pendingRollups Rollup
err := cache.DB.UpdateBandwidthBatch(ctx, rollups)
if err != nil {
mon.Event("rollups_write_cache_flush_lost")
cache.log.Error("MONEY LOST! Bucket bandwidth rollup batch flush failed", zap.Error(err))
// With error log only GET bandwidth because it's what we care most as we charge users for this.
var settled int64
var inline int64
for _, rollup := range rollups {
if rollup.Action == pb.PieceAction_GET {
settled += rollup.Settled
inline += rollup.Inline
}
}
cache.log.Error("MONEY LOST! Bucket bandwidth rollup batch flush failed", zap.Int64("settled", settled), zap.Int64("inline", inline), zap.Error(err))
}
}
@ -176,12 +187,18 @@ func (cache *RollupsWriteCache) updateCacheValue(ctx context.Context, projectID
IntervalStart: time.Date(intervalStart.Year(), intervalStart.Month(), intervalStart.Day(), intervalStart.Hour(), 0, 0, 0, intervalStart.Location()).Unix(),
}
// pevent unbounded memory memory growth if we're not flushing fast enough
// prevent unbounded memory growth if we're not flushing fast enough
// to keep up with incoming writes.
data, ok := cache.pendingRollups[key]
if !ok && len(cache.pendingRollups) >= cache.batchSize {
mon.Event("rollups_write_cache_update_lost")
cache.log.Error("MONEY LOST! Flushing too slow to keep up with demand")
cache.log.Error("MONEY LOST! Flushing too slow to keep up with demand",
zap.Stringer("ProjectID", projectID),
zap.Stringer("Action", action),
zap.Int64("Allocated", allocated),
zap.Int64("Inline", inline),
zap.Int64("Settled", settled),
)
} else {
data.Allocated += allocated