storj/storage/postgreskv/client.go

279 lines
6.7 KiB
Go
Raw Normal View History

2019-01-24 20:15:10 +00:00
// Copyright (C) 2019 Storj Labs, Inc.
// See LICENSE for copying information.
package postgreskv
import (
2020-01-16 23:48:59 +00:00
"bytes"
"context"
"database/sql"
"github.com/lib/pq"
"github.com/zeebo/errs"
2020-01-16 23:48:59 +00:00
"gopkg.in/spacemonkeygo/monkit.v2"
"storj.io/storj/private/dbutil"
2020-01-16 23:48:59 +00:00
"storj.io/storj/private/dbutil/pgutil"
"storj.io/storj/private/dbutil/txutil"
"storj.io/storj/private/tagsql"
"storj.io/storj/storage"
"storj.io/storj/storage/postgreskv/schema"
)
var (
mon = monkit.Package()
)
// Client is the entrypoint into a postgreskv data store
type Client struct {
db tagsql.DB
}
// New instantiates a new postgreskv client given db URL
func New(dbURL string) (*Client, error) {
2020-01-16 23:48:59 +00:00
dbURL = pgutil.CheckApplicationName(dbURL)
db, err := sql.Open("postgres", dbURL)
if err != nil {
return nil, err
}
2020-01-16 23:48:59 +00:00
dbutil.Configure(db, mon)
//TODO: Fix the parameters!!
err = schema.PrepareDB(context.TODO(), db, dbURL)
if err != nil {
return nil, err
}
return NewWith(tagsql.Wrap(db)), nil
2020-01-16 23:48:59 +00:00
}
// NewWith instantiates a new postgreskv client given db.
func NewWith(db tagsql.DB) *Client {
2020-01-16 23:48:59 +00:00
return &Client{db: db}
}
// Close closes the client
func (client *Client) Close() error {
return client.db.Close()
}
// Put sets the value for the provided key.
func (client *Client) Put(ctx context.Context, key storage.Key, value storage.Value) (err error) {
defer mon.Task()(&ctx)(&err)
if key.IsZero() {
2018-11-15 15:31:33 +00:00
return storage.ErrEmptyKey.New("")
}
2020-01-16 23:48:59 +00:00
q := `
2020-01-16 23:48:59 +00:00
INSERT INTO pathdata (fullpath, metadata)
VALUES ($1::BYTEA, $2::BYTEA)
ON CONFLICT (fullpath) DO UPDATE SET metadata = EXCLUDED.metadata
`
2020-01-16 23:48:59 +00:00
_, err = client.db.Exec(ctx, q, []byte(key), []byte(value))
2020-01-16 23:48:59 +00:00
return Error.Wrap(err)
}
// Get looks up the provided key and returns its value (or an error).
func (client *Client) Get(ctx context.Context, key storage.Key) (_ storage.Value, err error) {
defer mon.Task()(&ctx)(&err)
2018-11-15 15:31:33 +00:00
if key.IsZero() {
return nil, storage.ErrEmptyKey.New("")
}
2020-01-16 23:48:59 +00:00
q := "SELECT metadata FROM pathdata WHERE fullpath = $1::BYTEA"
row := client.db.QueryRow(ctx, q, []byte(key))
[v3 2137] - Add more info to find out repair failures (#2623) * pkg/datarepair/repairer: Track always time for repair Make a minor change in the worker function of the repairer, that when successful, always track the metric time for repair independently if the time since checker queue metric can be tracked. * storage/postgreskv: Wrap error in Get func Wrap the returned error of the Get function as it is done when the query doesn't return any row. * satellite/metainfo: Move debug msg to the right place NewStore function was writing a debug log message when the DB was connected, however it was always writing it out despite if an error happened when getting the connection. * pkg/datarepair/repairer: Wrap error before logging it Wrap the error returned by process which is executed by the Run method of the repairer service to add context to the error log message. * pkg/datarepair/repairer: Make errors more specific in worker Make the error messages of the "worker" method of the Service more specific and the logged message for such errors. * pkg/storage/repair: Improve error reporting Repair In order of improving the error reporting by the pkg/storage/repair.Repair method, several errors of this method and functions/methods which this one relies one have been updated to be wrapper into their corresponding classes. * pkg/storage/segments: Track path param of Repair method Track in monkit the path parameter passed to the Repair method. * satellite/satellitedb: Wrap Error returned by Delete Wrap the error returned by repairQueue.Delete method to enhance the error with a class and stack and the pkg/storage/segments.Repairer.Repair method get a more contextualized error from it.
2019-07-23 15:28:06 +01:00
var val []byte
err = row.Scan(&val)
if err == sql.ErrNoRows {
2019-08-21 17:30:29 +01:00
return nil, storage.ErrKeyNotFound.New("%q", key)
}
[v3 2137] - Add more info to find out repair failures (#2623) * pkg/datarepair/repairer: Track always time for repair Make a minor change in the worker function of the repairer, that when successful, always track the metric time for repair independently if the time since checker queue metric can be tracked. * storage/postgreskv: Wrap error in Get func Wrap the returned error of the Get function as it is done when the query doesn't return any row. * satellite/metainfo: Move debug msg to the right place NewStore function was writing a debug log message when the DB was connected, however it was always writing it out despite if an error happened when getting the connection. * pkg/datarepair/repairer: Wrap error before logging it Wrap the error returned by process which is executed by the Run method of the repairer service to add context to the error log message. * pkg/datarepair/repairer: Make errors more specific in worker Make the error messages of the "worker" method of the Service more specific and the logged message for such errors. * pkg/storage/repair: Improve error reporting Repair In order of improving the error reporting by the pkg/storage/repair.Repair method, several errors of this method and functions/methods which this one relies one have been updated to be wrapper into their corresponding classes. * pkg/storage/segments: Track path param of Repair method Track in monkit the path parameter passed to the Repair method. * satellite/satellitedb: Wrap Error returned by Delete Wrap the error returned by repairQueue.Delete method to enhance the error with a class and stack and the pkg/storage/segments.Repairer.Repair method get a more contextualized error from it.
2019-07-23 15:28:06 +01:00
return val, Error.Wrap(err)
}
// GetAll finds all values for the provided keys (up to storage.LookupLimit).
// If more keys are provided than the maximum, an error will be returned.
func (client *Client) GetAll(ctx context.Context, keys storage.Keys) (_ storage.Values, err error) {
defer mon.Task()(&ctx)(&err)
if len(keys) > storage.LookupLimit {
return nil, storage.ErrLimitExceeded
}
q := `
SELECT metadata
FROM pathdata pd
RIGHT JOIN
2020-01-16 23:48:59 +00:00
unnest($1::BYTEA[]) WITH ORDINALITY pk(request, ord)
ON (pd.fullpath = pk.request)
ORDER BY pk.ord
`
rows, err := client.db.Query(ctx, q, pq.ByteaArray(keys.ByteSlices()))
if err != nil {
return nil, errs.Wrap(err)
}
2020-01-16 23:48:59 +00:00
defer func() { err = errs.Combine(err, Error.Wrap(rows.Close())) }()
values := make([]storage.Value, 0, len(keys))
for rows.Next() {
var value []byte
if err := rows.Scan(&value); err != nil {
2020-01-16 23:48:59 +00:00
return nil, Error.Wrap(err)
}
values = append(values, storage.Value(value))
}
2020-01-16 23:48:59 +00:00
return values, Error.Wrap(rows.Err())
}
2020-01-16 23:48:59 +00:00
// Delete deletes the given key and its associated value.
func (client *Client) Delete(ctx context.Context, key storage.Key) (err error) {
defer mon.Task()(&ctx)(&err)
if key.IsZero() {
return storage.ErrEmptyKey.New("")
}
2020-01-16 23:48:59 +00:00
q := "DELETE FROM pathdata WHERE fullpath = $1::BYTEA"
result, err := client.db.Exec(ctx, q, []byte(key))
if err != nil {
2020-01-16 23:48:59 +00:00
return err
}
2020-01-16 23:48:59 +00:00
numRows, err := result.RowsAffected()
if err != nil {
return err
}
2020-01-16 23:48:59 +00:00
if numRows == 0 {
return storage.ErrKeyNotFound.New("%q", key)
}
2020-01-16 23:48:59 +00:00
return nil
}
2020-01-16 23:48:59 +00:00
// List returns either a list of known keys, in order, or an error.
func (client *Client) List(ctx context.Context, first storage.Key, limit int) (_ storage.Keys, err error) {
defer mon.Task()(&ctx)(&err)
2020-01-16 23:48:59 +00:00
return storage.ListKeys(ctx, client, first, limit)
}
2020-01-16 23:48:59 +00:00
// Iterate calls the callback with an iterator over the keys.
func (client *Client) Iterate(ctx context.Context, opts storage.IterateOptions, fn func(context.Context, storage.Iterator) error) (err error) {
defer mon.Task()(&ctx)(&err)
2020-01-16 23:48:59 +00:00
if opts.Limit <= 0 || opts.Limit > storage.LookupLimit {
opts.Limit = storage.LookupLimit
2020-01-16 23:48:59 +00:00
}
opi, err := newOrderedPostgresIterator(ctx, client, opts)
if err != nil {
return err
}
defer func() {
2018-12-21 10:54:20 +00:00
err = errs.Combine(err, opi.Close())
}()
return fn(ctx, opi)
}
// CompareAndSwap atomically compares and swaps oldValue with newValue
func (client *Client) CompareAndSwap(ctx context.Context, key storage.Key, oldValue, newValue storage.Value) (err error) {
defer mon.Task()(&ctx)(&err)
if key.IsZero() {
return storage.ErrEmptyKey.New("")
}
if oldValue == nil && newValue == nil {
2020-01-16 23:48:59 +00:00
q := "SELECT metadata FROM pathdata WHERE fullpath = $1::BYTEA"
row := client.db.QueryRow(ctx, q, []byte(key))
2020-01-16 23:48:59 +00:00
var val []byte
err = row.Scan(&val)
if err == sql.ErrNoRows {
return nil
}
2020-01-16 23:48:59 +00:00
if err != nil {
return Error.Wrap(err)
}
2019-08-21 17:30:29 +01:00
return storage.ErrValueChanged.New("%q", key)
}
if oldValue == nil {
q := `
2020-01-16 23:48:59 +00:00
INSERT INTO pathdata (fullpath, metadata) VALUES ($1::BYTEA, $2::BYTEA)
ON CONFLICT DO NOTHING
RETURNING 1
`
row := client.db.QueryRow(ctx, q, []byte(key), []byte(newValue))
2020-01-16 23:48:59 +00:00
var val []byte
err = row.Scan(&val)
if err == sql.ErrNoRows {
2019-08-21 17:30:29 +01:00
return storage.ErrValueChanged.New("%q", key)
}
return Error.Wrap(err)
}
return txutil.WithTx(ctx, client.db, nil, func(_ context.Context, txn tagsql.Tx) error {
2020-01-16 23:48:59 +00:00
q := "SELECT metadata FROM pathdata WHERE fullpath = $1::BYTEA;"
row := txn.QueryRowContext(ctx, q, []byte(key))
var metadata []byte
err = row.Scan(&metadata)
if err == sql.ErrNoRows {
// Row not found for this fullpath.
// Potentially because another concurrent transaction changed the row.
return storage.ErrKeyNotFound.New("%q", key)
}
if err != nil {
return Error.Wrap(err)
}
if equal := bytes.Compare(metadata, oldValue); equal != 0 {
// If the row is found but the metadata has been already changed
// we can't continue to delete it.
return storage.ErrValueChanged.New("%q", key)
}
var res sql.Result
if newValue == nil {
q = `
DELETE FROM pathdata
WHERE pathdata.fullpath = $1::BYTEA
AND pathdata.metadata = $2::BYTEA
`
2020-01-16 23:48:59 +00:00
res, err = txn.ExecContext(ctx, q, []byte(key), []byte(oldValue))
} else {
q = `
UPDATE pathdata
SET metadata = $3::BYTEA
WHERE pathdata.fullpath = $1::BYTEA
AND pathdata.metadata = $2::BYTEA
`
2020-01-16 23:48:59 +00:00
res, err = txn.ExecContext(ctx, q, []byte(key), []byte(oldValue), []byte(newValue))
}
2020-01-16 23:48:59 +00:00
if err != nil {
return Error.Wrap(err)
}
affected, err := res.RowsAffected()
if err != nil {
return Error.Wrap(err)
}
if affected != 1 {
return storage.ErrValueChanged.New("%q", key)
}
return nil
})
}