JakeHillion/scx-upstream
1
0
Fork 0
mirror of https://github.com/sched-ext/scx.git synced 2024-12-01 15:07:10 +00:00
Code Issues Packages Projects Releases Wiki Activity

scx_rustland: dispatch interactive tasks on any CPU

Browse Source 
Dispatch non-interactive tasks on the CPU selected by the built-in idle
selection logic and allow interactive tasks to be dispatched on any CPU.

Signed-off-by: Andrea Righi <andrea.righi@canonical.com>
This commit is contained in:
Andrea Righi 2024-05-21 16:56:08 +02:00
parent 6c129e9b4b
commit 23b0bb5ff5
1 changed files with 13 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
scheds/rust/scx_rustland/src/main.rs
View File

@ -101,13 +101,13 @@ struct Opts {
#[clap(short = 'b', long, default_value = "100")] #[clap(short = 'b', long, default_value = "100")]
slice_boost: u64, slice_boost: u64,
/// If specified, rely on the sched-ext built-in idle selection logic to dispatch tasks. /// If specified, always enforce the built-in idle selection logic to dispatch tasks.
/// Otherwise dispatch tasks on the first CPU available. /// Otherwise allow to dispatch interactive tasks on the first CPU available.
/// ///
/// Relying on the built-in logic can improve throughput (since tasks are more likely to remain /// Relying on the built-in logic can improve throughput (since tasks are more likely to remain
/// on the same CPU when the system is overloaded), but it can reduce system responsiveness. /// on the same CPU when the system is overloaded), but it can reduce system responsiveness.
/// ///
/// By default always dispatch tasks on the first CPU available to increase system /// By default always dispatch interactive tasks on the first CPU available to increase system
/// responsiveness over throughput, especially when the system is overloaded. /// responsiveness over throughput, especially when the system is overloaded.
/// ///
/// NOTE: this option cannot be used with --full-user. /// NOTE: this option cannot be used with --full-user.
@ -550,15 +550,21 @@ impl<'a> Scheduler<'a> {
// available. // available.
let mut dispatched_task = DispatchedTask::new(&task.qtask); let mut dispatched_task = DispatchedTask::new(&task.qtask);
// Interactive tasks will be dispatched on the first CPU available and they are
// allowed to preempt other tasks.
if task.is_interactive {
dispatched_task.set_flag(RL_CPU_ANY);
if !self.no_preemption {
dispatched_task.set_flag(RL_PREEMPT_CPU);
}
}
dispatched_task.set_slice_ns(self.effective_slice_ns(nr_scheduled));
// In full-user mode we skip the built-in idle selection logic, so simply // In full-user mode we skip the built-in idle selection logic, so simply
// dispatch all the tasks on the first CPU available. // dispatch all the tasks on the first CPU available.
if self.full_user || !self.builtin_idle { if self.full_user || !self.builtin_idle {
dispatched_task.set_flag(RL_CPU_ANY); dispatched_task.set_flag(RL_CPU_ANY);
} }
if task.is_interactive && !self.no_preemption {
dispatched_task.set_flag(RL_PREEMPT_CPU);
}
dispatched_task.set_slice_ns(self.effective_slice_ns(nr_scheduled));
// Send task to the BPF dispatcher. // Send task to the BPF dispatcher.
match self.bpf.dispatch_task(&dispatched_task) { match self.bpf.dispatch_task(&dispatched_task) {