mirror of
https://github.com/JakeHillion/object-introspection.git
synced 2024-09-19 19:19:05 +01:00
d71307cb43
Summary: Previously on large types OIL would have problems with corrupting the `std::stack<exporter::inst::Inst>` that is passed to the processors. This change hides the implementation of the stack from the processors by wrapping the call to emplace in a `std::function` written by the non-generated code, which solves the test case I've seen for this crashing. It also allows us to easily change the stack implementation in future - I plan to change it to a `std::stack<T, std::vector<T>>` in a follow up. Reviewed By: tyroguru Differential Revision: D49273116
82 lines
2.5 KiB
C++
82 lines
2.5 KiB
C++
/*
|
|
* Copyright (c) Meta Platforms, Inc. and affiliates.
|
|
*
|
|
* Licensed under the Apache License, Version 2.0 (the "License");
|
|
* you may not use this file except in compliance with the License.
|
|
* You may obtain a copy of the License at
|
|
*
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
*
|
|
* Unless required by applicable law or agreed to in writing, software
|
|
* distributed under the License is distributed on an "AS IS" BASIS,
|
|
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
* See the License for the specific language governing permissions and
|
|
* limitations under the License.
|
|
*/
|
|
#include <oi/IntrospectionResult.h>
|
|
#include <oi/exporters/ParsedData.h>
|
|
#include <oi/types/dy.h>
|
|
|
|
#include <cassert>
|
|
#include <iterator>
|
|
#include <stdexcept>
|
|
|
|
template <typename T>
|
|
inline constexpr bool always_false_v = false;
|
|
|
|
namespace oi {
|
|
|
|
IntrospectionResult::const_iterator&
|
|
IntrospectionResult::const_iterator::operator++() {
|
|
if (stack_.empty()) {
|
|
next_ = std::nullopt;
|
|
return *this;
|
|
}
|
|
|
|
auto el = stack_.top();
|
|
stack_.pop();
|
|
|
|
return std::visit(
|
|
[this](auto&& r) -> IntrospectionResult::const_iterator& {
|
|
using U = std::decay_t<decltype(r)>;
|
|
if constexpr (std::is_same_v<U, exporters::inst::PopTypePath>) {
|
|
type_path_.pop_back();
|
|
return operator++();
|
|
} else {
|
|
// reference wrapper
|
|
auto ty = r.get();
|
|
using T = std::decay_t<decltype(ty)>;
|
|
|
|
if constexpr (std::is_same_v<T, exporters::inst::Field>) {
|
|
type_path_.emplace_back(ty.name);
|
|
stack_.emplace(exporters::inst::PopTypePath{});
|
|
next_ = result::Element{
|
|
.name = ty.name,
|
|
.type_path = type_path_,
|
|
.type_names = ty.type_names,
|
|
.static_size = ty.static_size,
|
|
.exclusive_size = ty.exclusive_size,
|
|
.container_stats = std::nullopt,
|
|
.is_set_stats = std::nullopt,
|
|
};
|
|
|
|
for (const auto& [dy, handler] : ty.processors) {
|
|
auto parsed = exporters::ParsedData::parse(data_, dy);
|
|
handler(
|
|
*next_, [this](auto i) { stack_.emplace(i); }, parsed);
|
|
}
|
|
for (auto it = ty.fields.rbegin(); it != ty.fields.rend(); ++it) {
|
|
stack_.emplace(*it);
|
|
}
|
|
|
|
return *this;
|
|
} else {
|
|
static_assert(always_false_v<T>, "non-exhaustive visitor!");
|
|
}
|
|
}
|
|
},
|
|
el);
|
|
}
|
|
|
|
} // namespace oi
|