mirror of
https://github.com/JakeHillion/object-introspection.git
synced 2024-11-09 13:14:55 +00:00
db289c1a1a
CodeGen v2 permits template parameters to be qualified. This means that if we call `make_field` with a template parameter it will be qualified. However, we don't qualify the types when generating meta functions such as `NameProvider` and `TypeHandler`. This means these qualified types don't match up with the expected type. Use `std::decay_t` when forwarding the type to `NameProvider` and `TypeHandler` so they're always the base type that they were generated with. Most of this is covered by `make_field`, but there are direct references to `TypeHandler<Ctx, T>` in a lot of `TypeHandler::type` fields. Fix the problematic types manually for now, there may need to be a better solution with meta functions for this in the future. Test Plan: - CI - Added a test for `std::unique_ptr<const uint64_t>` to exercise this. Failed before, passes after. - Added a test for `std::unique_ptr<const std::vector<uint64_t>>` to test a non-primitive type. Failed before, passes after. |
||
|---|---|---|
| .. | ||
| integration | ||
| ci.oid.toml | ||
| CMakeLists.txt | ||
| integration_entry_doStuff_arg0.oid | ||
| integration_entry_doStuff_this.oid | ||
| integration_entry_inc_arg0.oid | ||
| integration_mttest.cpp | ||
| integration_return_incN_arg0.oid | ||
| integration_sleepy.cpp | ||
| integration.py | ||
| main.cpp | ||
| mocks.h | ||
| mttest.h | ||
| test_add_children.cpp | ||
| test_add_padding.cpp | ||
| test_alignment_calc.cpp | ||
| test_codegen.cpp | ||
| test_compiler.cpp | ||
| test_container_info.cpp | ||
| test_drgn_parser.cpp | ||
| test_drgn_parser.h | ||
| test_enforce_compatibility.cpp | ||
| test_flattener.cpp | ||
| test_identify_containers.cpp | ||
| test_key_capture.cpp | ||
| test_name_gen.cpp | ||
| test_node_tracker.cpp | ||
| test_parser.cpp | ||
| test_prune.cpp | ||
| test_remove_members.cpp | ||
| test_remove_top_level_pointer.cpp | ||
| test_topo_sorter.cpp | ||
| test_type_identifier.cpp | ||
| type_graph_utils.cpp | ||
| type_graph_utils.h | ||
| TypeGraphParser.cpp | ||
| TypeGraphParser.h | ||