object-introspection/test/integration/pointers_incomplete.toml
Jake Hillion 4975b6e9fa test: add features field to integration tests
Previously we tested different feature flags by using the `cli_options` field
in the test `.toml`. This works for OID but doesn't work for JIT OIL and won't
work for AoT OIL when those tests get added.

This change adds a new higher level `features` field to the test `.toml` which
adds the features to the config file as a prefix. This works with all methods
of generation.

Change the existing `cli_options` features to `features` except for where
they're testing something specific. Enable tests that were previously disabled
for OIL but only didn't work because of not being able to enable features.
Change pointer tests that are currently broken for OIL from `oil_disable` to
`oil_skip` - they can work, but codegen is broken for them at the minute.

Test plan:
- CI
- `make test` is no worse
2024-01-16 16:23:21 +00:00

142 lines
5.4 KiB
TOML

includes = ["memory", "optional"]
definitions = '''
struct IncompleteType;
struct IncompleteTypeContainer {
IncompleteType *ptrundef;
// std::unique_ptr<IncompleteType> unundef; // std::unique_ptr requires its template param to have a size
char __makePad1;
std::shared_ptr<IncompleteType> shundef;
char __makePad2;
std::optional<std::shared_ptr<IncompleteType>> shoptundef;
char __makePad3;
std::optional<IncompleteType *> optundef;
};
void incomplete_type_deleter(IncompleteType *ptr) {
::operator delete(ptr);
}
'''
[cases]
[cases.raw]
oid_skip = "oid codegen fails on this" # https://github.com/facebookexperimental/object-introspection/issues/17
oil_skip = "oil codegen fails on top level incomplete objects" # https://github.com/facebookexperimental/object-introspection/issues/459
param_types = ["IncompleteType*"]
setup = "return static_cast<IncompleteType*>(::operator new(5));"
features = ["chase-raw-pointers"]
expect_json = '''[{
"typeName": "IncompleteType",
"staticSize": 0,
"dynamicSize": 0,
"NOT": "members"
}]'''
[cases.raw_no_follow]
oid_skip = "oid codegen fails on this" # https://github.com/facebookexperimental/object-introspection/issues/17
oil_skip = "oil codegen fails on top level incomplete objects" # https://github.com/facebookexperimental/object-introspection/issues/459
param_types = ["IncompleteType*"]
setup = "return static_cast<IncompleteType*>(::operator new(5));"
expect_json = '''[{
"typeName": "IncompleteType",
"staticSize": 0,
"dynamicSize": 0,
"NOT": "members"
}]'''
[cases.raw_null]
oid_skip = "oid codegen fails on this" # https://github.com/facebookexperimental/object-introspection/issues/17
oil_skip = "oil codegen fails on top level incomplete objects" # https://github.com/facebookexperimental/object-introspection/issues/459
param_types = ["IncompleteType*"]
setup = "return nullptr;"
expect_json = '''[{
"typeName": "IncompleteType",
"staticSize": 0,
"dynamicSize": 0,
"NOT": "members"
}]'''
[cases.unique_ptr]
param_types = ["const std::unique_ptr<IncompleteType, decltype(&incomplete_type_deleter)>&"]
setup = '''
auto raw_ptr = static_cast<IncompleteType*>(::operator new(5));
return std::unique_ptr<IncompleteType, decltype(&incomplete_type_deleter)>(
raw_ptr, &incomplete_type_deleter);
'''
expect_json = '[{"staticSize":16, "dynamicSize":0, "NOT":"members"}]'
expect_json_v2 = '[{"staticSize":16, "exclusiveSize":16}]'
[cases.unique_ptr_null]
param_types = ["const std::unique_ptr<IncompleteType, decltype(&incomplete_type_deleter)>&"]
setup = '''
return std::unique_ptr<IncompleteType, decltype(&incomplete_type_deleter)>(
nullptr, &incomplete_type_deleter);
'''
expect_json = '[{"staticSize":16, "dynamicSize":0, "NOT":"members"}]'
expect_json_v2 = '[{"staticSize":16, "exclusiveSize":16}]'
[cases.shared_ptr]
param_types = ["const std::shared_ptr<IncompleteType>&"]
setup = '''
auto raw_ptr = static_cast<IncompleteType*>(::operator new(5));
return std::shared_ptr<IncompleteType>(raw_ptr , &incomplete_type_deleter);
'''
expect_json = '[{"staticSize":16, "dynamicSize":0, "NOT":"members"}]'
expect_json_v2 = '[{"staticSize":16, "exclusiveSize":16}]'
[cases.shared_ptr_null]
param_types = ["const std::shared_ptr<IncompleteType>"]
setup = "return nullptr;"
expect_json = '[{"staticSize":16, "dynamicSize":0, "NOT":"members"}]'
expect_json_v2 = '[{"staticSize":16, "exclusiveSize":16}]'
[cases.containing_struct]
oil_skip = "pointers are broken in tbv2" # https://github.com/facebookexperimental/object-introspection/issues/458
param_types = ["const IncompleteTypeContainer&"]
setup = "return IncompleteTypeContainer{};"
features = ["chase-raw-pointers"]
expect_json = '''[{
"staticSize": 88,
"dynamicSize": 0,
"members": [
{ "name": "ptrundef", "staticSize": 8, "dynamicSize": 0 },
{ "name": "__makePad1", "staticSize": 1, "dynamicSize": 0 },
{ "name": "shundef", "staticSize": 16, "dynamicSize": 0 },
{ "name": "__makePad2", "staticSize": 1, "dynamicSize": 0 },
{ "name": "shoptundef",
"staticSize": 24,
"dynamicSize": 0,
"length": 0,
"capacity": 1,
"elementStaticSize": 16
},
{ "name": "__makePad3", "staticSize": 1, "dynamicSize": 0 },
{ "name": "optundef",
"staticSize": 16,
"dynamicSize": 0,
"length": 0,
"capacity": 1,
"elementStaticSize": 8
}
]
}]'''
[cases.containing_struct_no_follow]
param_types = ["const IncompleteTypeContainer&"]
setup = "return IncompleteTypeContainer{};"
expect_json = '''[{
"staticSize": 88,
"members": [
{ "name": "ptrundef", "staticSize": 8 },
{ "name": "__makePad1", "staticSize": 1 },
{ "name": "shundef", "staticSize": 16 },
{ "name": "__makePad2", "staticSize": 1 },
{ "name": "shoptundef",
"staticSize": 24,
"length": 0,
"capacity": 1
},
{ "name": "__makePad3", "staticSize": 1 },
{ "name": "optundef",
"staticSize": 16,
"length": 0,
"capacity": 1
}
]
}]'''