JakeHillion/object-introspection
1
0
Fork 0
mirror of https://github.com/JakeHillion/object-introspection.git synced 2024-09-19 11:09:05 +01:00
Code Issues Packages Projects Releases Wiki Activity

clangparser: mark incomplete arrays as incomplete without failing

Browse Source 
Attempting to complete a type which can't be completed currently fails oilgen.
For incomplete arrays, which we know are not possible to complete, return false
deliberately.

`requireCompleteType` likely needs to not fail in all cases in the future. For
now this works.

Test plan:
- `std::unique_ptr<long[]>` used to fail the generation. Now it can
  successfully codegen.
This commit is contained in:
Jake Hillion 2023-12-20 16:17:02 +00:00 committed by Jake Hillion
parent c5ecb9aaa2
commit beb404e41c
1 changed files with 11 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
oi/type_graph/ClangTypeParser.cpp
View File

@ -410,8 +410,17 @@ ContainerInfo* ClangTypeParser::getContainerInfo(
namespace {
bool requireCompleteType(clang::Sema& sema, const clang::Type& ty) {
if (ty.isSpecificBuiltinType(clang::BuiltinType::Void))
return true; // treat as complete
switch (ty.getTypeClass()) {
case clang::Type::Builtin: {
if (ty.isSpecificBuiltinType(clang::BuiltinType::Void))
return true; // treat as complete
break;
}
case clang::Type::IncompleteArray:
return false; // would fail completion
default:
break;
}
// TODO: This is a terrible warning.
return !sema.RequireCompleteType(